Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mAT3N-0003a9-Qo for pgadmin-hackers@arkaria.postgresql.org; Mon, 02 Aug 2021 08:12:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mAT3M-0003fC-Qf for pgadmin-hackers@arkaria.postgresql.org; Mon, 02 Aug 2021 08:12:04 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mAT3M-0003ew-2i for pgadmin-hackers@lists.postgresql.org; Mon, 02 Aug 2021 08:12:04 +0000 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mAT3K-0005T3-55 for pgadmin-hackers@postgresql.org; Mon, 02 Aug 2021 08:12:03 +0000 Received: by mail-ej1-x62a.google.com with SMTP id nd39so29536993ejc.5 for ; Mon, 02 Aug 2021 01:12:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tIF3iLBX00onMXOVv0wcthqxDnegzNSusB7fcK5z5YY=; b=VAz+I/tNCTaqSpJUJxaaL8C80ssRfPOWkjgqd9oJt0qeSB/UiWIkOu5fXfeiNAlMNr 6lh3A1J2eHNRHCNohII5Y4T/wX3ruNbDimzgOrbeM0F/xTx9KFplT45GzI9TTAcM6HQH 7P2OsX3boqfR1ngLfFZfx9HIoPRJrOaMADu5qm9i/+nWFjOB3SunO33Yl1ue2beE4vwK 6uCRt2B1xva7lnP5dseeIoKrT7WHXGiQcoNu8UmEA1NF4CqCzSqZC9RaLsTY9G9Ohngn VTsQJwsgHMmrfLQcXWlbH7u7Ec9zzQIbwJzvXOy62r50IcfAvn3XOY5InMnnyUsFtFuu 0mgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tIF3iLBX00onMXOVv0wcthqxDnegzNSusB7fcK5z5YY=; b=jfBRgAI2uDPxQqOU4GuGd5L8yvHqD6Ibsteg4upiNimlcXihU/CMDni8jsu0v064WB huTgI7WHWa+jQ66eCPrCPTk8x/nw/SwJc2bK2fnppEnd/9Xe5Fl7HbD8VtZpUoJuNbTk VT2V9+92FKnCgSt3xHU7HrQVnwOSVzAPXtgT9JLsECQXevTpUwaTB8d7lFGSMh0idvXb qEB8g+VsfxN+mlP2fEvTkN7fPIdcctqwn4DDSrR3AQj30fGCkyNpl+nGSExt7PhPWgNo WnEGSnNhH9w0BkC4jBXibPuqEUh1wy4m+8Cj7kMCb2XTjGxMNwu33hcCDt2IruVzmhLF yKSA== X-Gm-Message-State: AOAM532PpJxQMZet/7COIpVtBbQV3U8jCpkJYgBa/0HBsZHpjwj81KFh y0AEnNPU/z7xfrbRQkyrzQJBIXdjyxE+qxa/lDnMzQ== X-Google-Smtp-Source: ABdhPJzXF6+27JVLMD4G+uyiROUzQ4496JBQT3/mLNQ1EjV2h4ikxPQl+m39+tkbwh/kpAsfZEQYlV3TkyhmcHsQ5vo= X-Received: by 2002:a17:906:b0c8:: with SMTP id bk8mr14331418ejb.412.1627891921327; Mon, 02 Aug 2021 01:12:01 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Mon, 2 Aug 2021 09:11:50 +0100 Message-ID: Subject: Re: PFA: Patch to generate universal(arm64, x86_64) binaries for macOS To: Semab Tariq Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000b42afc05c88f1f6d" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000b42afc05c88f1f6d Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Mon, Aug 2, 2021 at 2:44 AM Semab Tariq wrote: > Hi Team > > In my previous email, I attached a link to the JIRA ticket and I was > hoping that you can access that ticket and see the details about my patch > but I was unaware that JIRA is not accessible to the community so now I am > attaching the details here > > *Details about my patch* > > While trying to generate *pgAgent-4.2.1* universal binaries on *macOS > BigSur x86_64* architecture via following command > 1BOOST_ROOT=/tmp/PG-pgAgent PGDIR=/tmp/PG-pgAgent /Applications/CMake.app/ > Contents/bin/cmake -DCMAKE_INSTALL_PREFIX=/tmp/PG-pgAgent - > DCMAKE_OSX_ARCHITECTURES:STRING="x86_64;arm64" - > DCMAKE_OSX_DEPLOYMENT_TARGET:STRING=10.14 -DSTATIC_BUILD=NO -D > CMAKE_OSX_SYSROOT:FILEPATH=/Library/Developer/CommandLineTools/SDKs/ > MacOSX11.1.sdk CMakeLists.txt > > I got this error in configure log > 1CMake Error at CMakeLists.txt:43 (IF): 2 if given arguments: 3 "NOT" > "x86_64" "arm64" "STREQUAL" "" 4 Unknown arguments specified 5-- > Configuring incomplete, errors occurred! > > After some debugging, I found out that the > *pgAgent-4.2.1-Source/CMakeLists.txt* file doesn't have proper double > quotes around *CMAKE_OSX_ARCHITECTURES* variable inside *if* condition so > I added that, and now I am able to build pgAgent universal binaries > successfully. If you don't have any concerns with my patch can someone > please push the changes to the source? Thanks & Regards, > Semab > > On Fri, Jul 30, 2021 at 3:40 PM Semab Tariq > wrote: > >> Hi Team >> >> Can someone please push this patch to the *master* branch of *pgAgent* >> repo? >> For more details Please refer to JIRA PPS-310 >> >> >> -- >> Thanks & Regards, >> Semab >> > > > -- > -- Dave Page Blog: https://pgsnake.blogspot.com Twitter: @pgsnake EDB: https://www.enterprisedb.com --000000000000b42afc05c88f1f6d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Mon, Aug 2, 2021 at 2:44 AM Semab= Tariq <semab.tariq@ente= rprisedb.com> wrote:
Hi Team=C2=A0

In my previous email, I attached a link t= o the JIRA ticket and I was hoping that you can access that ticket and see = the details about my patch but I was unaware=C2=A0that JIRA is not accessib= le to the community so now I am attaching the details here

Detai= ls about my patch

While= trying to generate pgAgent-4.2.1 universal binaries on macOS = BigSur x86_64 architecture via following command

1BOOST_R= OOT=3D/tmp/PG= -pgAgent PGDIR=3D/tmp/= PG-pgAgent /Applications/CMake.app/Contents/bin/cmake -D= CMAKE_INSTALL_PREFIX=3D/tmp/= PG-pgAgent -DCMAKE_OSX_AR= CHITECTURES:STRING=3D"x86_64;arm64" -DCMAKE_O= SX_DEPLOYMENT_TARGET:STRING=3D10.14 -DSTATIC_BUILD=3DNO -D CMAKE_OSX_SYSROOT:FILEPATH=3D/<= /span>Library/Developer/CommandLineTools/SDKs/MacOSX11.1.sdk CMakeLists.txt

I g= ot this error in configure log

1CMake= Error at CMakeLists.txt:43 (IF)<= span style=3D"font-family:unset;font-size:unset;font-variant-caps:unset;fon= t-weight:unset;font-stretch:unset;line-height:unset;font-feature-settings:u= nset;text-orientation:unset;writing-mode:unset;zoom:unset;background-image:= unset;background-size:unset;background-origin:unset;background-clip:unset;b= ackground-color:unset;background-blend-mode:unset;border:unset;border-top-l= eft-radius:unset;border-top-right-radius:unset;border-bottom-right-radius:u= nset;border-bottom-left-radius:unset;border-collapse:unset;box-sizing:unset= ;break-after:unset;break-before:unset;break-inside:unset;caption-side:unset= ;clear:unset;column-width:unset;column-count:unset;column-fill:unset;column= -rule-width:unset;column-rule-style:unset;column-rule-color:unset;column-sp= an:unset;display:unset;empty-cells:unset;float:unset;height:unset;image-ori= entation:unset;isolation:unset;letter-spacing:unset;line-break:unset;list-s= tyle:unset;margin:unset;max-height:unset;max-width:unset;min-height:unset;m= in-width:unset;mix-blend-mode:unset;object-fit:unset;object-position:unset;= opacity:unset;outline:unset;overflow:unset;padding:unset;quotes:unset;table= -layout:unset;text-align:unset;text-decoration:unset;text-indent:unset;text= -overflow:unset;text-transform:unset;text-underline-position:unset;vertical= -align:unset;border-spacing:unset;white-space:unset;width:unset;word-break:= unset;word-spacing:unset;background-position:unset;background-repeat:unset"= >: 2 if given arguments= : 3 "= ;NOT" "x86_64" "arm64" "STREQUAL" "" 4 Unkno= wn arguments specified 5-- Configuring incomplete, errors occurred!

After some debugging, I found out that = the pgAgent-4.2.1-Source/CMakeLists.txt file doesn't have prop= er double quotes around CMAKE_OSX_ARCHITECTURES variable inside if condition so I added that, and now I am able to build pgAgent uni= versal binaries successfully.=20 If you don't have any concerns with my patch can someone please push th= e changes to the source? Thanks &= ; Regards,
Semab


On Fri, Jul 30, 2021 at 3:40 PM Semab Tariq <semab.tariq@enterpr= isedb.com> wrote:
Hi Te= am

Can someone please push this patch to the master branch of= pgAgent repo?
For more details Please refer to JIRA PPS-310= =C2=A0

--
Thanks & Regards,Semab


--


--
--000000000000b42afc05c88f1f6d--