MIME-Version: 1.0
In-Reply-To: 
 <CAKKotZRmvbScMdUtjMgUJdRe-EXaqDoDbYBxrMZrkbVDVR_iUg@mail.gmail.com>
References: 
 <CAFS4TJYDRi6fs+wrhkj89gFe3xaFOkoApCK+AU2O4DfU2XfXog@mail.gmail.com>
 <CAKKotZQSTtJVkBKMeFi9vTrPugBEbEE38dhbbn-hr+hpd0Qzbw@mail.gmail.com>
 <CA+OCxowChMtZzaSwrG5Sganh4LiMQcgL7BpoqhTxZga30DqDXw@mail.gmail.com>
 <CAKKotZRmvbScMdUtjMgUJdRe-EXaqDoDbYBxrMZrkbVDVR_iUg@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Thu, 18 May 2017 10:31:06 +0100
Message-ID: 
 <CA+OCxow3e=q9w_e=Kkw1ebZJ82EM8RyFmiTaXihdqhX6HbzZhw@mail.gmail.com>
Subject: Re: [pgAdmin4] [PATCH] History Tab rewrite in React
To: Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>
Cc: Matthew Kleiman <mkleiman@pivotal.io>,
 pgadmin-hackers <pgadmin-hackers@postgresql.org>,
	Shruti B Iyer <siyer@pivotal.io>
Content-Type: multipart/alternative; boundary="001a113ed3be85a058054fc91021"
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

--001a113ed3be85a058054fc91021
Content-Type: text/plain; charset="UTF-8"

Hi

On Thu, May 18, 2017 at 9:56 AM, Murtuza Zabuawala <murtuza.zabuawala@
enterprisedb.com> wrote:

>
> Go to 'pgadmin4/web' directory
>
> Try running,
>
> run 'yarn install'
>
> (if you have installed globally)
> then run 'grunt'
> OR
> run './node_modules/grunt-cli/bin/grunt'
>
>
> Then run pgAdmin4
>

OK, that worked - though pgAdmin now takes a lot longer to start up, which
is a problem.

The Jasmine tests now fail:

(pgadmin4)piranha:web dpage$ yarn run karma start --single-run
yarn run v0.24.4
$ "/Users/dpage/git/pgadmin4/web/node_modules/.bin/karma" start
18 05 2017 10:22:01.182:ERROR [plugin]: Error during loading
"karma-phantomjs-launcher" plugin:
  Path must be a string. Received null

webpack: Compiled successfully.
webpack: Compiling...
webpack: wait until bundle finished:
webpack: wait until bundle finished:
webpack: wait until bundle finished:
webpack: wait until bundle finished:
webpack: wait until bundle finished:
webpack: wait until bundle finished:
webpack: wait until bundle finished:
webpack: wait until bundle finished:
webpack: wait until bundle finished:
webpack: wait until bundle finished:
webpack: wait until bundle finished:
webpack: wait until bundle finished:
(node:12214) DeprecationWarning: loaderUtils.parseQuery() received a
non-string value which can be problematic, see https://github.com/webpack/
loader-utils/issues/56
parseQuery() will be replaced with getOptions() in the next major version
of loader-utils.
18 05 2017 10:22:07.281:WARN [karma]: No captured browser, open
http://localhost:9876/

webpack: Compiled successfully.
18 05 2017 10:22:07.294:ERROR [karma]: Found 1 load error
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this
command.


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--001a113ed3be85a058054fc91021
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi<br><div class=3D"gmail_extra"><br><div class=3D"gmail_q=
uote">On Thu, May 18, 2017 at 9:56 AM, Murtuza Zabuawala <span dir=3D"ltr">=
&lt;<a href=3D"mailto:murtuza.zabuawala@enterprisedb.com" target=3D"_blank"=
>murtuza.zabuawala@<wbr>enterprisedb.com</a>&gt;</span> wrote:<br><blockquo=
te class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px =
solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div><br></div><d=
iv>Go to &#39;pgadmin4/web&#39; directory</div><div><br></div><div>Try runn=
ing,<br></div><div><br></div><div>run &#39;yarn install&#39;</div><div><br>=
</div><div>(if you have installed globally)<br></div><div>then run &#39;gru=
nt&#39;=C2=A0</div><div>OR</div><div>run &#39;./node_modules/grunt-cli/bin/=
<wbr>grunt&#39;</div><div><br></div><div><br></div><div>Then run pgAdmin4</=
div></div></blockquote><div><br></div><div>OK, that worked - though pgAdmin=
 now takes a lot longer to start up, which is a problem.</div><div><br></di=
v><div>The Jasmine tests now fail:</div><div><br></div><div>(pgadmin4)piran=
ha:web dpage$ yarn run karma start --single-run</div><div>yarn run v0.24.4<=
/div><div>$ &quot;/Users/dpage/git/pgadmin4/<wbr>web/node_modules/.bin/karm=
a&quot; start</div><div>18 05 2017 10:22:01.182:ERROR [plugin]: Error durin=
g loading &quot;karma-phantomjs-launcher&quot; plugin:</div><div>=C2=A0 Pat=
h must be a string. Received null</div><div><br></div><div>webpack: Compile=
d successfully.</div><div>webpack: Compiling...</div><div>webpack: wait unt=
il bundle finished:=C2=A0</div><div>webpack: wait until bundle finished:=C2=
=A0</div><div>webpack: wait until bundle finished:=C2=A0</div><div>webpack:=
 wait until bundle finished:=C2=A0</div><div>webpack: wait until bundle fin=
ished:=C2=A0</div><div>webpack: wait until bundle finished:=C2=A0</div><div=
>webpack: wait until bundle finished:=C2=A0</div><div>webpack: wait until b=
undle finished:=C2=A0</div><div>webpack: wait until bundle finished:=C2=A0<=
/div><div>webpack: wait until bundle finished:=C2=A0</div><div>webpack: wai=
t until bundle finished:=C2=A0</div><div>webpack: wait until bundle finishe=
d:=C2=A0</div><div>(node:12214) DeprecationWarning: loaderUtils.parseQuery(=
) received a non-string value which can be problematic, see <a href=3D"http=
s://github.com/webpack/loader-utils/issues/56" target=3D"_blank">https://gi=
thub.com/webpack/<wbr>loader-utils/issues/56</a></div><div>parseQuery() wil=
l be replaced with getOptions() in the next major version of loader-utils.<=
/div><div>18 05 2017 10:22:07.281:WARN [karma]: No captured browser, open <=
a href=3D"http://localhost:9876/" target=3D"_blank">http://localhost:9876/<=
/a></div><div><br></div><div>webpack: Compiled successfully.</div><div>18 0=
5 2017 10:22:07.294:ERROR [karma]: Found 1 load error</div><div>error Comma=
nd failed with exit code 1.</div><div>info Visit <a href=3D"https://yarnpkg=
.com/en/docs/cli/run" target=3D"_blank">https://yarnpkg.com/en/docs/<wbr>cl=
i/run</a> for documentation about this command.=C2=A0</div><div><br></div><=
div><br></div></div><div><br></div>-- <br><div class=3D"m_58701951155578857=
65gmail_signature">Dave Page<br>Blog: <a href=3D"http://pgsnake.blogspot.co=
m" target=3D"_blank">http://pgsnake.blogspot.com</a><br>Twitter: @pgsnake<b=
r><br>EnterpriseDB UK: <a href=3D"http://www.enterprisedb.com" target=3D"_b=
lank">http://www.enterprisedb.com</a><br>The Enterprise PostgreSQL Company<=
br></div>
</div></div>

--001a113ed3be85a058054fc91021--