public inbox for [email protected]  

help / color / mirror / Atom feed
From: Dave Page <[email protected]>
To: Aditya Toshniwal <[email protected]>
Cc: Nikhil Mohite <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: Regarding removal for wcDocker and replace it with rc-dock #6479
Date: Fri, 11 Aug 2023 09:51:34 +0100
Message-ID: <CA+OCxow4AiwUDjYTTpjeYObLXjA1jYxN5mTLC3-PCiu=eQoARw@mail.gmail.com> (raw)
In-Reply-To: <CAM9w-_kvVZfjAPqfmaK3niUcpeE=SuZ_F8BW1WS9g8zCw-t6ew@mail.gmail.com>
References: <CAM9w-_muqgKY=se3NLgkHpWbOxMkLP9LkB2EMF2VoAkE0ffaJw@mail.gmail.com>
	<CAOBg0AOe6mOzHnThmy_YQj73+3bQzcmffsDOOun+nrk3fdfNRg@mail.gmail.com>
	<CAM9w-_nj1MaC9jdzoOWrsQroCNpL8BOeAG_7t3XjBSaHjbZeVg@mail.gmail.com>
	<CA+OCxozkx5iuKNzS9MEEUaBnWTG-e5AeU0gcg87gv+pqvBUxtA@mail.gmail.com>
	<CAM9w-_kvVZfjAPqfmaK3niUcpeE=SuZ_F8BW1WS9g8zCw-t6ew@mail.gmail.com>

On Fri, 11 Aug 2023 at 09:48, Aditya Toshniwal <
[email protected]> wrote:

> Hi Dave,
>
> I think we can do that, but on the main panel and not on object explorer
>>> and with some relevant icon.
>>> Any other suggestions/ideas?
>>>
>>
>> I'm surprised a man of your talents can't catch the right-click - any
>> particular reason it's giving you problems?
>>
> Thank you for your appreciation. The problem here is rc-dock doesn't
> provide any API to allow the onContextMenu event on the tab bar. I could
> hack and add using JS native querySelector and addListener, but that is
> error prone and not the right way to do it in React. I have used a custom
> component for tab title, so I was able to capture the event on the tabs.
>
>>
>> Assuming it really is that hard, can we do something like Chrome (similar
>> to Nikhil's suggestion)?
>>
>> [image: Screenshot 2023-08-11 at 09.33.53.png]
>>
> Chrome has only one type of tab, but pgAdmin has many. I am thinking of
> something similar to PyCharm.
> [image: image.png]
>

That works for me.


-- 
Dave Page
Blog: https://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: https://www.enterprisedb.com


Attachments:

  [image/png] Screenshot 2023-08-11 at 09.33.53.png (16.9K, 3-Screenshot%202023-08-11%20at%2009.33.53.png)
  download | view image

  [image/png] image.png (128.1K, 4-image.png)
  download | view image

view thread (7+ messages)

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Regarding removal for wcDocker and replace it with rc-dock #6479
  In-Reply-To: <CA+OCxow4AiwUDjYTTpjeYObLXjA1jYxN5mTLC3-PCiu=eQoARw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox