Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fYuC1-0003Ld-GU for pgadmin-hackers@arkaria.postgresql.org; Fri, 29 Jun 2018 14:16:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fYuBz-0006Pk-Ri for pgadmin-hackers@arkaria.postgresql.org; Fri, 29 Jun 2018 14:16:07 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fYuBz-0006Pd-Ja for pgadmin-hackers@lists.postgresql.org; Fri, 29 Jun 2018 14:16:07 +0000 Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fYuBu-0006Nf-7X for pgadmin-hackers@postgresql.org; Fri, 29 Jun 2018 14:16:06 +0000 Received: by mail-wm0-x243.google.com with SMTP id z137-v6so2265360wmc.0 for ; Fri, 29 Jun 2018 07:16:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Sq4lN0TQszJrM5yEfobahPe/pZsGRq1xuhr9K1LxndA=; b=0EBvWA8BmH8HzFq/AFoTfHgi976KD3AsLvA7TzueaGN3KypfbYtmKxnap5DwcmS8s8 +qe/tLLDAUUC78rkPUbXDaafYqrJdIlh3NPZZN94zofeZSlw4c1NMuGamGdXRSMAV8rk bN/snl56SBbvWJzB97ts5f/xeQqV3W7AnUhclhb+6UTyB/gKvand88Sq3JGqFL4u0+sh x4kRHb/ftEQmwEOJoPJPKm50sKhOK3vwAmQoVAap4wD2vSXyYEYQWBQf03qpDWTHs6G0 Ni3TIbKKyJuFVB/zuSd6Fj+0sepBQzXUWyNiYGE+f3NqXg51y4u8BIkfeKWxNZMlry/p NNyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Sq4lN0TQszJrM5yEfobahPe/pZsGRq1xuhr9K1LxndA=; b=XwZePkEVdth+Ztiw0F4cgNlhPUJFT9L9gZPwZH0e0rrEv+gTGSnn8DR/K9GmjNJ0MP CgGturiosLWDFeyWE06NCYxbiuUsb+ERU5tHH/3yyyici0gwX01nnAkVNYQa18ZcMUzi 4uChHvGP/LPDwpFJ60WldF1WLjLcaN0NZWcUgAwNPxEr3r8LprksxENijM56AMnU4s4o kT/jYsI5O+iO/njfLdy6vp8+jGSuQjBUpffThGoFy0h0dlnB/vvBS92gOlp20/qHNORE jab7XBL/HusZoyBUYGPaRh5gyGQoi8Ygxeb4UmjTMS0IYJBnk4pVaXRTCvxmbn5i3Fz5 Xemw== X-Gm-Message-State: APt69E1qIAuKPqOEw7hVSxlR3et2sseTANjWZkwWPX6EFhZOZPzCaSL7 FwTIoX4ggHq9PwkoA+bGPRYkplSd5+GvurGk5rKhPA== X-Google-Smtp-Source: AAOMgpeYZ7XuWXR5mu4Obj2LkEpj0wlqyPalzty8bGKe8ODYZRPTvPB73JNB1bDdJoYm7JCfS/PdGmoaT922vhc/N54= X-Received: by 2002:a1c:3ac6:: with SMTP id h189-v6mr2095117wma.64.1530281760186; Fri, 29 Jun 2018 07:16:00 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a1c:2907:0:0:0:0:0 with HTTP; Fri, 29 Jun 2018 07:15:59 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Fri, 29 Jun 2018 15:15:59 +0100 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM #3397 Add support for JIT stats in EXPLAIN output in PG11 To: Akshay Joshi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000b8f2b1056fc87c19" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000b8f2b1056fc87c19 Content-Type: text/plain; charset="UTF-8" On Fri, Jun 29, 2018 at 3:12 PM, Akshay Joshi wrote: > Hi Dave > > On Fri, Jun 29, 2018 at 6:56 PM, Dave Page wrote: > >> Hi >> >> On Fri, Jun 29, 2018 at 9:55 AM, Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch to fix the RM #3397 Add support for JIT stats in >>> EXPLAIN output in PG11. Please review it. >>> >> >> A couple of immediate thoughts: >> >> - When the canvas is first rendered, there's a vertical scrollbar now. As >> soon as I mouseover the new icon, it vanishes and the icon jumps to the >> right. >> > > Will look into it. Vertical scrollbar comes even if you remove my > patch and try to hover any image. > >> >> - The icon seems lighter than the other controls on the left. >> > > Same css has been applied, only difference is button is disabled. > >> >> - The icon isn't disabled when there is no info to show. >> > > Button is always disabled, I have just change the opacity. > >> >> Thanks. >> > Maybe - but I can still click it and it reacts as if it's active. It may be lighter to indicate that it's disabled, but its not behaving as such. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --000000000000b8f2b1056fc87c19 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Fri, Jun 29, 2018 at 3:12 PM, Akshay Joshi <akshay.josh= i@enterprisedb.com> wrote:
=
Hi Dave

On Fri, Jun 29, 2018 at 6:56 PM, Dave Page <dpage@= pgadmin.org> wrote:
Hi

On Fri, Jun 29, 2018 at 9:55 AM, Akshay Joshi <akshay.joshi@e= nterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to = fix the RM #3397=C2=A0Add support for JIT stats in EXPLAIN = output in PG11. Please review it.

A couple of immediate thoughts:

- When t= he canvas is first rendered, there's a vertical scrollbar now. As soon = as I mouseover the new icon, it vanishes and the icon jumps to the right.

=C2=A0 =C2=A0= =C2=A0Will look into it. Vertical scrollbar comes even if you remove my pa= tch and try to hover any image.=C2=A0

- The icon seems lighter than the other con= trols on the left.

=C2=A0 =C2=A0 =C2=A0Same css has been applied, only difference is bu= tton is disabled.=C2=A0

- The icon isn't disabled when there is no info to sh= ow.

=C2=A0 = =C2=A0 =C2=A0Button is always disabled, I have just change the opacity.=C2= =A0 =C2=A0=C2=A0

=
Thanks.=C2=A0
<= /div>

Maybe - but I can still click i= t and it reacts as if it's active. It may be lighter to indicate that i= t's disabled, but its not behaving as such.=C2=A0

<= /div>--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

Enterprise= DB UK: http://www= .enterprisedb.com
The Enterprise PostgreSQL Company
--000000000000b8f2b1056fc87c19--