Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fBHKE-0004Ig-C6 for pgadmin-hackers@arkaria.postgresql.org; Wed, 25 Apr 2018 10:06:58 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fBHKC-0006Uw-Pd for pgadmin-hackers@arkaria.postgresql.org; Wed, 25 Apr 2018 10:06:56 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fBHKC-0006Um-33 for pgadmin-hackers@lists.postgresql.org; Wed, 25 Apr 2018 10:06:56 +0000 Received: from mail-wm0-x231.google.com ([2a00:1450:400c:c09::231]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fBHK3-0007Wx-Hw for pgadmin-hackers@postgresql.org; Wed, 25 Apr 2018 10:06:54 +0000 Received: by mail-wm0-x231.google.com with SMTP id f6so6131350wmc.4 for ; Wed, 25 Apr 2018 03:06:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=8c1tjti6nogIdqHZPE7uoUVKSWqipumZacV6APqEJsw=; b=e2QGrADY2IvC8PN66Iy656eRP1W7m/qNa4TKHv0krNEksGP9KbqlKOB35jpqSs9OxB I/HRVgWlBiABnjW/tq6E8FCFR/VtBKaCDxmYJG1eZf5VBRExYjKS/5kWg+E4UVyTQ+Hy xujJ/Hm3F4XOK8h8qDLEcGm0TyIheIK0IxmaNSUB1i4Q2sfWen9ZvOGJOxTmURIWuR6m iXfEujcpXSK1p/ZyvfrwJ/jPtAb1U08A8PNoJKh4E5j9twxL14zkcfh2gqxAvSvSnIdX kmJx1YY9Py6bumwJ0GUCXNFRQjtx6h1dzTNTtiFjl756+CT90Rcxnmg2mlW5WZmUkQtT n7Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=8c1tjti6nogIdqHZPE7uoUVKSWqipumZacV6APqEJsw=; b=PCwnQyjSesSoQexssIZWmXAZMDrAeNLXYso6yexEo9qKcG3goxN4zR0ABTovrVbf/b p2QYAQIuLSIK+nyyK1uqWNSpUETztcffMx6YrsYiFllxA2gRFK7RaeDpAZ57i4l53FiN RJAWvDIqGfe0rohL/OgoiBtfc+odKt+zOg3Vl3nTBVeJ6ur/Y26LRKKcOVzi7TIjrFtd jJudfm1SpBqRifhtQD2ycGB2CsRMAJYHNc0cLc7b91g3xmuw7xs7vF1rRV01bm3LKyrT ngL6k34OFY7f3bG2jSdPCtBsefegDFSaAKtj4TkHEYz+Yk1w4fDlSMU7kwjMcEfCrXsB 0YIw== X-Gm-Message-State: ALQs6tDZDcYKU3JkAQZsX4XHhzjgHDF1WUwzamUMQvlZS+O8YAAsCFgN vAGOi7niSsq/vtTEi7YriRcbMlrxaUumbZ+6i5/8rA== X-Google-Smtp-Source: AB8JxZruCYaZ4MLcw31EIOkZYFDHSixE9TaFvMNJzWtRpnqUTYeDXiFzfXxLcAq6XEUzIg1p+/LesF9e21TckZyUhRQ= X-Received: by 10.28.142.149 with SMTP id q143mr775055wmd.161.1524650804173; Wed, 25 Apr 2018 03:06:44 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.69.220 with HTTP; Wed, 25 Apr 2018 03:06:43 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Wed, 25 Apr 2018 11:06:43 +0100 Message-ID: Subject: Re: [pgAdmin4][RM#3155] Allow user to lock the Layout To: Murtuza Zabuawala Cc: Akshay Joshi , Joao De Almeida Pereira , pgadmin-hackers Content-Type: multipart/alternative; boundary="001a114438a096e8c0056aa96d17" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a114438a096e8c0056aa96d17 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable All, We just had a brief discussion in our EDB sprint planning meeting about this. There is a non-zero chance that we're going to have to fork wcDocker in the near future, in order to update it to work with jQuery 3. If we do that, then it may be significantly easier to fix this issue in that fork (perhaps by adding a single lockLayout(bool) function, rather than trying to do so from pgAdmin. I think (unless Murtuza believes that won't help), that we're better off holding on this for now until we know if we've had to do that. On Wed, Apr 25, 2018 at 10:23 AM, Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Hi Akshay, > > > On Wed, Apr 25, 2018 at 2:37 PM, Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Hi Joao/Murtuza >> >> It break's the functionality, I am able to move "Data output", "Explain" >> etc.. panel of Query Tool, even if "Lock layout?" is set to True. >> > > =E2=80=8BIt's working properly in v5 patch, Something went wrong while > refactoring.=E2=80=8B > > =E2=80=8B > > Apart from above I have found more issue. Below are the steps to reproduc= e: >> >> - Set the "Lock layout?" flag to False. >> - Move out Dashboard panel. >> - Set the "Lock layout?" flag to True. >> - Close the Dashboard panel, as layout is locked and empty Dashboard >> panel is still visible. (Refer attached screenshot) >> >> =E2=80=8BThat's because we have set the Panel moveable property to False= , they > won't auto resize, As discussed earlier if user drag any panel out of pan= el > group it gets render in seprate wcFrame. I think that needs to be taken > care by user before they decide to lock the layout, We can not expilcitly > set panel's closeable property to False when layout is locked, If we do s= o > user will not be able to close any Query tool, Debugger panels.=E2=80=8B > =E2=80=8B > > > On Tue, Apr 24, 2018 at 9:11 PM, Joao De Almeida Pereira < >> jdealmeidapereira@pivotal.io> wrote: >> >>> haha, >>> Just joking, now we have a good version that passes tests and all. >>> >>> We found out that a test was failing in the patch version 5: >>> >>> HeadlessChrome 0.0.0 (Linux 0.0.0) Panel when we create a panel and use= r created panel without defining isMoveable then it should be moveable it s= hould call moveable method with true as argument FAILED >>> Expected false to be true. >>> at UserContext. (regression/javascript/browser/panel= _spec.js:12886:38) >>> >>> =E2=80=8B >>> To solve this problem we decided to change the Panel class to match wha= t >>> the test say. >>> >>> Thanks >>> Victoria & Joao >>> >>> >>> On Tue, Apr 24, 2018 at 11:08 AM Joao De Almeida Pereira < >>> jdealmeidapereira@pivotal.io> wrote: >>> >>>> Hi, >>>> Apparently the last version was not applying, here is the new version >>>> that should apply correctly >>>> >>>> Thanks >>>> Victoria & Joao >>>> >>>> On Tue, Apr 24, 2018 at 10:56 AM Joao De Almeida Pereira < >>>> jdealmeidapereira@pivotal.io> wrote: >>>> >>>>> Hi Murtuza, >>>>> >>>>> We tested the patch and everything looks fine. We also refactors som= e >>>>> parts to include things like strict equality and using let/const inst= ead of >>>>> var. The updated patch is attached. >>>>> In the future, it will be more valuable to have the translation to ES= 6 >>>>> and the feature work in separate commits so it is easier to understan= d what >>>>> changed. >>>>> >>>>> Sincerely, >>>>> >>>>> Joao and Victoria >>>>> >>>>> >>>>> >>>>> On Tue, Apr 24, 2018 at 4:58 AM Akshay Joshi < >>>>> akshay.joshi@enterprisedb.com> wrote: >>>>> >>>>>> On Tue, Apr 24, 2018 at 1:17 PM, Dave Page wrote= : >>>>>> >>>>>>> Akshay, could you review/commit this please? >>>>>>> >>>>>>> Please also update the release_notes_3_1.rst file when you commit >>>>>>> user-visible changes, to make it easier to build the release notes. >>>>>>> >>>>>> >>>>>> Sure >>>>>> >>>>>>> >>>>>>> Thanks. >>>>>>> >>>>>>> On Tue, Apr 24, 2018 at 8:45 AM, Murtuza Zabuawala < >>>>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>>>> >>>>>>>> Hi Dave, >>>>>>>> >>>>>>>> Please find the updated patch, Now we are able to lock wcFrame and >>>>>>>> wcPanel both. >>>>>>>> >>>>>>>> -- >>>>>>>> Regards, >>>>>>>> Murtuza Zabuawala >>>>>>>> EnterpriseDB: http://www.enterprisedb.com >>>>>>>> The Enterprise PostgreSQL Company >>>>>>>> >>>>>>>> >>>>>>>> On Thu, Apr 5, 2018 at 6:32 PM, Robert Eckhardt < >>>>>>>> reckhardt@pivotal.io> wrote: >>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> On Wed, Apr 4, 2018 at 11:31 PM, Khushboo Vashi < >>>>>>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On Wed, Apr 4, 2018 at 8:09 PM, Dave Page >>>>>>>>>> wrote: >>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> On Wed, Apr 4, 2018 at 12:54 PM, Murtuza Zabuawala < >>>>>>>>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>>>>>>>> >>>>>>>>>>>> On Wed, Apr 4, 2018 at 5:00 PM, Dave Page >>>>>>>>>>>> wrote: >>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> On Wed, Apr 4, 2018 at 10:45 AM, Murtuza Zabuawala < >>>>>>>>>>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>>> On Wed, Apr 4, 2018 at 2:47 PM, Dave Page >>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> On Wed, Apr 4, 2018 at 7:20 AM, Murtuza Zabuawala < >>>>>>>>>>>>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Hi Dave, >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> On Tue, Apr 3, 2018 at 9:03 PM, Dave Page < >>>>>>>>>>>>>>>> dpage@pgadmin.org> wrote: >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Hi >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> On Tue, Apr 3, 2018 at 12:56 PM, Murtuza Zabuawala < >>>>>>>>>>>>>>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> Hi, >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> Thanks Joao for reviewing. >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> PFA updated patch. >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> On Tue, Apr 3, 2018 at 1:11 AM, Joao De Almeida Pereira = < >>>>>>>>>>>>>>>>>> jdealmeidapereira@pivotal.io> wrote: >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> Hello, >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> On Mon, Apr 2, 2018 at 10:07 AM Murtuza Zabuawala < >>>>>>>>>>>>>>>>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> =E2=80=8BHello, >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> Please find updated patch, >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> Now layout will be locked after user updates its >>>>>>>>>>>>>>>>>>>> preferences, w >>>>>>>>>>>>>>>>>>>> e have used =E2=80=8B >>>>>>>>>>>>>>>>>>>> templated variable in the javascript file >>>>>>>>>>>>>>>>>>>> =E2=80=8B because we do not have preference module or >>>>>>>>>>>>>>>>>>>> preference cache available when the page loads and pan= els gets rendered, >>>>>>>>>>>>>>>>>>>> =E2=80=8BI >>>>>>>>>>>>>>>>>>>> =E2=80=8B also >>>>>>>>>>>>>>>>>>>> made changes in JS tests as per Joao's review comments= . >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> Looks like everything is working when we change the loc= k. >>>>>>>>>>>>>>>>>>> As a personal preferences I would prefer to see this in >>>>>>>>>>>>>>>>>>> at least 2 commits, one that is related to the preferen= ce issue and another >>>>>>>>>>>>>>>>>>> one that is related to this story. >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> All the tests are working, but he linter is failing: >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> /tmp/build/4a5630c2/pivotal-rm-3155/web /tmp/build/4a56= 30c2 >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> ./pgadmin/misc/__init__.py:78: [E303] too many blank li= nes (2) >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> 1 E303 too many blank lines (2) >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> 1 >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> =E2=80=8BFixed=E2=80=8B >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> @Dave/Pivotal team, >>>>>>>>>>>>>>>>>>>> The given patch is working fine for all the Tabs/Panel= s >>>>>>>>>>>>>>>>>>>> (all the panels from main window as well as from Query= tool and Debugger) >>>>>>>>>>>>>>>>>>>> but I'm facing an issue while handling the Browser tre= e section, It is a wcDocer >>>>>>>>>>>>>>>>>>>> frame >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> and not a wcDocker panel >>>>>>>>>>>>>>>>>>>> . = Like >>>>>>>>>>>>>>>>>>>> wcDocker panel, wcDocker frame do not provide any API = so that a developer >>>>>>>>>>>>>>>>>>>> can prevent drag-drop functionality on it. >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> It's not working fine for me. For example, if I put the >>>>>>>>>>>>>>>>> SQL Panel on it's own below the properties/stats panels (= so it looks like >>>>>>>>>>>>>>>>> pgAdmin 3 used to by default), and then lock the layout, = I can un-dock the >>>>>>>>>>>>>>>>> SQL panel into a dialogue, but then cannot re-dock it. I = can do weird >>>>>>>>>>>>>>>>> things with the browser tree as well, probably because it= 's a frame as you >>>>>>>>>>>>>>>>> say. >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> =E2=80=8BThat is expected behaviour =E2=80=8Bbecause once = you drag the >>>>>>>>>>>>>>>> panel out of the group of Panels then it becomes individua= l Frame, That is >>>>>>>>>>>>>>>> what the author of the wcDocker replied on my question, >>>>>>>>>>>>>>>> *"A panel must either be initialized as movable or >>>>>>>>>>>>>>>> non-movable from the beginning and never changed because i= t generates a >>>>>>>>>>>>>>>> different arrangement of elements depending. This feature = should only ever >>>>>>>>>>>>>>>> be used within the onCreate method of the panel. I should = probably have >>>>>>>>>>>>>>>> been more clear about this limitation in the documentation= ."* >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>> So does it become a panel again if a second panel is added >>>>>>>>>>>>>>> to the new tab group? >>>>>>>>>>>>>>> >>>>>>>>>>>>>> =E2=80=8BNo, it stays Frame.=E2=80=8B >>>>>>>>>>>>>> >>>>>>>>>>>>>> As far as I understand Panel needs a Frame to render itself >>>>>>>>>>>>>> if it is not attached to the main docker instance.=E2=80=8B >>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> There must be some way we can lock a tab that's not part of >>>>>>>>>>>>>>> a group. >>>>>>>>>>>>>>> >>>>>>>>>>>>>> At a moment there is no way of =E2=80=8B >>>>>>>>>>>>>> locking frames out of the box :( >>>>>>>>>>>>>> =E2=80=8B >>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> Hmm, so the question becomes: do we include the lock feature, >>>>>>>>>>>>> but rename it to "Lock Tabs" or something similar, or leave i= t out >>>>>>>>>>>>> altogether? It clearly doesn't do everything we want right no= w. >>>>>>>>>>>>> >>>>>>>>>>>> =E2=80=8BI would say lets include the feature by adding warnin= g note >>>>>>>>>>>> that this feature works with default layout only, And I don't = think most >>>>>>>>>>>> user will try to drag drop Browser panel =E2=80=8B >>>>>>>>>>>> anyway, meanwhile I'll check what changes are required in main >>>>>>>>>>>> source code to make the Frame lock. >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> Anyone else have any thoughts on this? Personally I don't like >>>>>>>>>>> including half-baked features. >>>>>>>>>>> >>>>>>>>>>> +1, but we need to find out the way as this feature is requeste= d >>>>>>>>>> by many users. >>>>>>>>>> >>>>>>>>> >>>>>>>>> 100% agree. I can convince my self that this feature request has >>>>>>>>> to do with locking panels into a certain layout. I can also convi= nce myself >>>>>>>>> that the same request is simple because users are frustrated with= the fact >>>>>>>>> that the tabs and panes move around and they find that behavior a= nnoying. >>>>>>>>> >>>>>>>>> -- Rob >>>>>>>>> >>>>>>>>> >>>>>>>>>> -- >>>>>>>>>>> Dave Page >>>>>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>>>>> Twitter: @pgsnake >>>>>>>>>>> >>>>>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>>>>>> The Enterprise PostgreSQL Company >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Dave Page >>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>> Twitter: @pgsnake >>>>>>> >>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>> The Enterprise PostgreSQL Company >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> *Akshay Joshi* >>>>>> >>>>>> *Sr. Software Architect * >>>>>> >>>>>> >>>>>> >>>>>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 >>>>>> 976-788-8246 <+91%2097678%2088246>* >>>>>> >>>>> >> >> >> -- >> *Akshay Joshi* >> >> *Sr. Software Architect * >> >> >> >> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >> > > --=20 Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a114438a096e8c0056aa96d17 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
All,

We just had a brief discussion in = our EDB sprint planning meeting about this. There is a non-zero chance that= we're going to have to fork wcDocker in the near future, in order to u= pdate it to work with jQuery 3. If we do that, then it may be significantly= easier to fix this issue in that fork (perhaps by adding a single lockLayo= ut(bool) function, rather than trying to do so from pgAdmin.

=
I think (unless Murtuza believes that won't help), that we&#= 39;re better off holding on this for now until we know if we've had to = do that.

On We= d, Apr 25, 2018 at 10:23 AM, Murtuza Zabuawala <murtuza.z= abuawala@enterprisedb.com> wrote:
Hi Akshay,


On Wed, Apr 25, 2018 at 2:3= 7 PM, Akshay Joshi <akshay.joshi@enterprisedb.com>= wrote:
Hi Joao/M= urtuza

It break's the functionality, I am able to mo= ve "Data output", "Explain" etc.. panel of Query Tool, = even if "Lock layout?" is set to True.
=C2=A0
=E2=80=8BIt's working properly in v5 p= atch, Something went wrong while refactoring.=E2=80=8B
=C2=A0
=E2=80=8B

Apart from above I have found more issue. Below are the steps= to reproduce:
  • Set the "Lock layout?" flag to F= alse.
  • Move out Dashboard panel.
  • Se= t the "Lock layout?" flag to True.
  • Close the Dashb= oard panel, as layout is locked and empty Dashboard panel is still visible.= (Refer attached screenshot)=C2=A0=C2=A0
=E2=80=8BThat's because we have set the Panel mov= eable property to False, they won't auto resize, As discussed earlier i= f user drag any panel out of panel group it gets render in seprate wcFrame.= I think that needs to be taken care by user before they decide to lock the= layout, We can not expilcitly set panel's closeable property to False = when layout is locked, If we do so user will not be able to close any Query= tool, Debugger panels.=E2=80=8B
=C2=A0=E2=80=8B


On Tue, Apr 24, 2018 at 9:1= 1 PM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io= > wrote:
haha,=
Just joking, now we have a good version that passes tests and all.

We found out that a test was failing in the patch ver= sion 5:
HeadlessChrome 0.0.0 (Linux 0.0.0)=
 Panel when we create a panel and user created panel without defining isMov=
eable then it should be moveable it should call moveable method with true a=
s argument FAILED
    Expected false to be true.
        at UserContext.<anonymous> (regression/javascript/browser/panel_spec.js:12886:38)
=E2=80=8B
To solve this problem we decided to change the Panel cl= ass to match what the test say.

Thanks
V= ictoria & Joao


On Tue, Apr 24, 2018 at 11:08 AM Joao De Almeida Pereira <jdealmeidapereira@pi= votal.io> wrote:
Hi,
Apparently the last version was not applying, here is the new= version that should apply correctly

Thanks
<= div>Victoria & Joao

On Tue, Apr 24, 2018 at 10:56 AM Joao De Almeida Pereira <jdealmeidapereira@piv= otal.io> wrote:
Hi Murtuza,

We tested the patch and everything look= s fine.=C2=A0 We also refactors some parts to include things like strict eq= uality and using let/const instead of var.=C2=A0 The updated patch is attac= hed.
In the future, it will be more valuable to have the translat= ion to ES6 and the feature work in separate commits so it is easier to unde= rstand what changed.

Sincerely,

Joao and Victoria


On Tue, Apr 24, 201= 8 at 4:58 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
=
On Tue, Apr 24, 2018 at 1:17 PM, Dave Page= <dpage@pgadmin.org> wrote:
Akshay, could you review/commit this please?

Please also update the release_notes_3_1.rst file when you commit u= ser-visible changes, to make it easier to build the release notes.

=C2=A0 =C2=A0Sure=C2=A0

=
Thanks.

On Tue, Apr 24, 2018 at 8:45 AM, = Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.co= m> wrote:
=
Hi Dave,
<= div style=3D"font-family:verdana,sans-serif;color:#444444">
Please find the updat= ed patch, Now we are able to lock wcFrame and wcPanel both.

<= div dir=3D"ltr">
--
Regards,
Murtuza Zabuaw= ala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The En= terprise PostgreSQL Company
=
<= div>

On Thu, Apr 5, 2018 at 6:32 PM, Robert Eckha= rdt <reckhardt@pivotal.io> wrote:


On Wed, Apr 4, 2018 at 11:31 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:

On Wed, Apr 4, 2018 at 8:09 PM, Da= ve Page <dpage@pgadmin.org> wrote:


On Wed, Apr 4, 2018 at 1= 2:54 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprised= b.com> wrote:
On Wed, Apr 4, 2018 at 5:00 PM, Dav= e Page <= dpage@pgadmin.org> wrote:


On Wed, Apr 4, 2018 at = 10:45 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprise= db.com> wrote:
On Wed, Apr 4, 2018 at 2:47 PM, Dave Page <dpage@pgad= min.org> wrote:
=


On Wed, Apr 4, 2018 at 7:20 AM, Murtuza Zab= uawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Dave,

On Tue, Apr 3, 2018 at 9:03 PM, Dave P= age <dpage@pgadmin.org> wrote:
Hi

On Tue, Apr 3, 2018 at 12= :56 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprised<= wbr>b.com> wrote:
Hi,

Thanks Joao for reviewing.

PFA updated patch.

On Tue, Apr 3, 2018 at 1:11 AM, Joao D= e Almeida Pereira <jdealmeidapereira@pivotal.io> = wrote:
Hello,

On Mon, Apr 2, = 2018 at 10:07 AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com= > wrote:
=

=
=E2=80=8BHello,

Please find updated patch,= =C2=A0

Now layout will be locked af= ter user updates its preferences, w
e have used =E2=80=8B
=
templated variable in the javascript file
=E2=80=8B = because we do not have preference module or preference cache available when= the page loads and panels gets rendered,=C2=A0
=E2=80=8BI
=E2=80= =8B also=C2=A0
made changes in JS tests as per Joao's review comme= nts.
Looks like everything is working when we change the loc= k.
As a personal preferences I would prefer to see this in at lea= st 2 commits, one that is related to the preference issue and another one t= hat is related to this story.


All t= he tests are working, but he linter is failing:
/tmp/bu=
ild/4a5630c2/pivotal-rm-3155/web /tmp/build/4a5630c2

./pgadmin/misc/__init__.=
py:78: [E303] too many blank lines (2)

1       E303 too many=
 blank lines (2)=C2=A0
1=C2=A0
= =E2=80=8BFixed=E2=80=8B
=C2=A0

=

@Dave/Pivotal= team,
The given patch is working fine for all the Tabs/Panels (all the panels = from main window as well as from Query tool and Debugger) but I'm facin= g an issue while handling the Browser tree section, It is a wcDocer f= rame and not a wcDocker panel.=C2=A0Like wcDocker panel, wcDo= cker frame do not provide any API so that a developer can prevent drag-drop= functionality on it.
=
=

It's not working fine for me. Fo= r example, if I put the SQL Panel on it's own below the properties/stat= s panels (so it looks like pgAdmin 3 used to by default), and then lock the= layout, I can un-dock the SQL panel into a dialogue, but then cannot re-do= ck it. I can do weird things with the browser tree as well, probably becaus= e it's a frame as you say.
=C2=A0
=E2=80=8BThat is expected behaviour =E2=80=8Bbecause once you d= rag the panel out of the group of Panels then it becomes individual Frame, = That is what the author of the wcDocker replied on my question,=C2=A0
=
"A panel must either be initialized= as movable or non-movable from the beginning and never changed because it = generates a different arrangement of elements depending. This feature shoul= d only ever be used within the onCreate method of the panel. I should proba= bly have been more clear about this limitation in the documentation."<= /i>


S= o does it become a panel again if a second panel is added to the new tab gr= oup?
=E2=80=8BNo= , it stays Frame.=E2=80=8B
=C2=A0
As far as I understa= nd Panel needs a Frame to render itself if it is not attached to the main d= ocker instance.=E2=80=8B
<= br>
There must be some way we can lock a tab that's not part = of a group.
At a mome= nt there is no way of =E2=80=8B
locking = frames out of the box :(
=E2=80=8B
=

Hmm, so the question becomes: do we includ= e the lock feature, but rename it to "Lock Tabs" or something sim= ilar, or leave it out altogether? It clearly doesn't do everything we w= ant right now.=C2=A0
<= div style=3D"font-family:verdana,sans-serif;color:rgb(68,68,68);display:inl= ine">=E2=80=8BI would say lets include the feature by adding warning note t= hat this feature works with default layout only, And I don't think most= user will try to drag drop Browser panel =E2=80=8B
anyway, mean= while I'll check what changes are required in main source code to make = the Frame lock.

Anyone else have any thoughts on this? Personally I don'= t like including half-baked features.=C2=A0

+1, but we need to find o= ut the way as this feature is requested by many users.=C2=A0

100% agree. I can convince my sel= f that this feature request has to do with locking panels into a certain la= yout. I can also convince myself that the same request is simple because us= ers are frustrated with the fact that the tabs and panes move around and th= ey find that behavior annoying.=C2=A0

-- Rob
=
=C2=A0
--
Dave Page
Blog: http://pgsnake.blogspot.com
T= witter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise P= ostgreSQL Company






--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitt= er: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Postg= reSQL Company



--
Akshay Joshi
Sr. Software Architect

<= font color=3D"#3333FF">
=



--
<= font color=3D"#3333FF">Akshay Joshi
Sr= . Software Architect

<= /span>

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246



--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--001a114438a096e8c0056aa96d17--