Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cwPeY-0004fg-U2 for pgadmin-hackers@arkaria.postgresql.org; Fri, 07 Apr 2017 08:53:59 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1cwPeY-00014J-GK for pgadmin-hackers@arkaria.postgresql.org; Fri, 07 Apr 2017 08:53:58 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cwPeK-0000fW-Cj for pgadmin-hackers@postgresql.org; Fri, 07 Apr 2017 08:53:44 +0000 Received: from mail-io0-x230.google.com ([2607:f8b0:4001:c06::230]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1cwPeH-0000Rk-9Y for pgadmin-hackers@postgresql.org; Fri, 07 Apr 2017 08:53:43 +0000 Received: by mail-io0-x230.google.com with SMTP id b140so45687596iof.1 for ; Fri, 07 Apr 2017 01:53:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=uKsmlpQzgRfhg2TIf6b6BtXqt4h4WVEYqDSLUT3H3JY=; b=xr7Cgamjvr341eoX94OGC3+8HxfEnmklos3ca+tF5TPavVfYRltIhMu5Ts0RCyFfz/ No7pVEaKuxvQYgEf8lKiWckdXNbT+7jfVcMHk+GW6/aGsnFpl9X7yL9do/vI9o+brKTc 1gKb9CBQsH/Q34AnWaF41VQkCVZ0ANWMRUKjn1ZtC0nYtnmwhoaCy3tLIGMmG8Xo3DXT ZgDw85yYW02zsz2sTMgZchc4qEKn699cxNEOyzDbF9IME386ApFoFLuZMeYCquScIqNY lb5+c8OVKDLer0B11X7SdvlwqXCc7V4ngb1urd2r5K5WKxcf+MH7lvKCstZXl4Sc9BkW PSug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=uKsmlpQzgRfhg2TIf6b6BtXqt4h4WVEYqDSLUT3H3JY=; b=LQah+lF5hZuXmw5O/weZZaEPLX8858JPMK3mxQ9jE6VAX7VOCqwwFHh/o8BRZzrWzn 23yZjs5mnAvby9YI0A9SeWEdtzf1/ZXYiXdeRxgU7pD7VnC8CvXWB8Qtth4/GygI8Xep EvvyqQmcTkusbve8koLHnt6sNPq9rYePowsmM93Qe8Kg0ga3OhPD3mXbG//oI+ezRhXl 6S9MkfS4/2+xzIhiozA5fu0Pg2Dl/24GtBuAihCVe/SEnrdGzLhk/qorFeK6CuaIhAU8 fJxveCH3bttqYNxYqTeh7hpJw3XBXLwSoST8ErldK4USEYWNdhGJGYMUWjGjRbvt4gzK QnbA== X-Gm-Message-State: AFeK/H0MjT25LEo2VFG+vHmUa4dW2Vk6h7LBw9vRInS8PUrFcAt5jjNabX3E4+vF8R//O1j31AsyU/H1D2+UQA== X-Received: by 10.107.40.7 with SMTP id o7mr39620407ioo.126.1491555219737; Fri, 07 Apr 2017 01:53:39 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.174.225 with HTTP; Fri, 7 Apr 2017 01:53:39 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Fri, 7 Apr 2017 09:53:39 +0100 Message-ID: Subject: Re: [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't use default values To: Matthew Kleiman Cc: Surinder Kumar , pgadmin-hackers , George Gelashvili Content-Type: text/plain; charset=UTF-8 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org On Tue, Apr 4, 2017 at 5:37 PM, Matthew Kleiman wrote: > Hi Surinder, > > We looked at your fix for default values in the query tool editor. > > We think the user experience could be further improved by seeing the actual > default value instead of the empty cell. Agreed. > As an intermediate step, there would be user value in seeing "[default]" > instead of the blank cell (or what used to be "[null]"). Also agreed. Surinder, please add the [default] label in your next update. We'll look at immediately returning values in the future, though that may not actually be possible without saving the row (defaults may not be constant, they could be expressions). -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers