Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1haKIo-0004c7-M9 for pgadmin-hackers@arkaria.postgresql.org; Mon, 10 Jun 2019 13:25:34 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1haKIn-0002LS-Gi for pgadmin-hackers@arkaria.postgresql.org; Mon, 10 Jun 2019 13:25:33 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1haKIn-0002LL-9n for pgadmin-hackers@lists.postgresql.org; Mon, 10 Jun 2019 13:25:33 +0000 Received: from mail-it1-x142.google.com ([2607:f8b0:4864:20::142]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1haKIk-0000Im-9O for pgadmin-hackers@postgresql.org; Mon, 10 Jun 2019 13:25:32 +0000 Received: by mail-it1-x142.google.com with SMTP id r135so13091737ith.1 for ; Mon, 10 Jun 2019 06:25:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0B+pc3/cS8m2tFaot+lo/kjrRD2kNhpbnK2uqkFkKrI=; b=qnmviyn+uvkxmPWXHBmeYFs2FhtGL56oQM8neLghXV8hZu6fExamrA5mHOGp4uCYOY By4PLiUWypgsbhAzQE3y+ZiaR4vTkfbe3mLjEMvfl6LnTC10OevH6sfSgW92O4Ri8OBK ysxzSep6vi8+UCCzFUXDgiY5UhnrEw9jcSFZalw48daRSNZAjf5Wfq8B6m2adF0sMr8T imI6zucZothO16N4oAnVHzIr+C0Y3h20GgKsvURH828W942IP/BlmC61jvcamqUXyI07 St2aeGIK95nJRn3ckCNFA7K1OXgpMl/bfgRmjqW11vE5yv0sZpVeolLEM0Bzo1DsIAYH joAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0B+pc3/cS8m2tFaot+lo/kjrRD2kNhpbnK2uqkFkKrI=; b=qarip0CzgP2a2BNjFOL6z0Dyro0hEYaD0sLvLT2dL6ZTYGbp4a+nYX42MiVvIud1a8 Z/xl34UaFcztviTr10ktP+L1l69MKs+cS09SQLw3dP4vzjjWoYS2ACGv89XjuF53ERqw IBf91JV22Mg0VKvJGPsKJ4YnJvTTPfGH89mBMd0t79NKPZSaW4MpCxK2TwmCIBRL6knd TYsg3P1s1zQxQHgvNLh4zLtq7iWIYfSYDsivBO72ijxqz+85BTLmQ+NDJ6PrDL1j5fuR IrMNPZAzL0ImyUGZKX86bmLB+mqkbbWLOnUQ/bAPK0+rBx04C7eeEWuNSIxg7MQBMiH7 /gYA== X-Gm-Message-State: APjAAAX4qLCxI5edvW9Rb8SkURXa6mYwL5QhXTl3nvYtE3vIm8Md9Ik/ xLPBZrq/FDP8ed7bk5+aDFc+pvXfb5bVSUD/B2yDGQ== X-Google-Smtp-Source: APXvYqw3nW6qiA9PTV11n75ynwkJ6oWYVUaH470dXMC13cw26HCOPJFYCxQz5R5KuenmPq1VycBv7OBOpJbS0q8OM5w= X-Received: by 2002:a02:950a:: with SMTP id y10mr47561705jah.26.1560173128635; Mon, 10 Jun 2019 06:25:28 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Mon, 10 Jun 2019 14:25:16 +0100 Message-ID: Subject: Re: [pgAdmin4][Patch]: Feature #4283 pgAdmin4 support for v12 To: Akshay Joshi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000001ef37e058af81da8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000001ef37e058af81da8 Content-Type: text/plain; charset="UTF-8" Thanks, applied. On Fri, Jun 7, 2019 at 11:39 AM Akshay Joshi wrote: > Hi Hackers, > > Today I have read the https://www.postgresql.org/docs/release/12.0/ release > note. I have created some new feature request and fixed one issue. > Following are the issues that I have fixed: > > - Fixed existing issue to drop/delete partitions of the partition > table. > - Allow foreign keys to reference partitioned tables. > > Created following issues, not sure we need to consider it: > > 1. #4333 Add support for > function selectivity. > 2. #4334 Add support for > generated columns. > 3. #4335 Add EXPLAIN > option SETTINGS and SUMMARY > > > Attached is the complete patch, ignore the previous patch. Please review > it. > > > On Thu, Jun 6, 2019 at 3:31 PM Akshay Joshi > wrote: > >> Hi Hackers, >> >> I have started adding support of PostgreSQL v12 in pgAdmin4. Attached is >> the patch to fix the following issues: >> >> - RM #4290: "string indices must be integers" displayed for all >> objects >> - RM #4288: View data issue. >> - PG v12 removes the ability to create table using WITH OIDS, so I >> have modified the code in GUI as well as on backend. >> - PG v12 removes obsolete pg_attrdef.adsrc and pg_constraint.consrc >> column, so fixed with appropriate functions calls. >> - For partitioned tables, since no storage is required for the table >> itself. PG v12 throws and error while specifying "TABLESPACE" in create >> table syntax for partitioned table, so fix that too. >> >> This is the initial patch to fix the issues that has been raised or I >> have found. Will continue to work on adding support for v12. Will check the >> release notes. >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --0000000000001ef37e058af81da8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, applied.

On Fri, Jun 7, 2019 at 11:39 AM Akshay Jos= hi <akshay.joshi@enterp= risedb.com> wrote:
Hi Hackers,

Today I have= read the=C2=A0https://www.postgresql.org/docs/release/12.0/=C2=A0rele= ase note. I have created some new feature request and fixed one issue. Foll= owing are the issues that I have fixed:
  • Fixed existing is= sue to drop/delete partitions of the partition table.
  • Allow foreign= keys to reference partitioned tables.
Created following issues, n= ot sure we need to consider it:
  1. #4333=C2=A0Add support = for function selectivity.
  2. #4334=C2=A0Add support for generated co= lumns.
  3. #4335=C2=A0Add EXPLAIN option SETTINGS and SUMMARY

Attached is the complete patch, ignore the prev= ious patch. Please review it.=C2=A0


On Thu, Jun 6, 2019= at 3:31 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
=
Hi Hacke= rs,

I have started adding support of PostgreSQL v12 in p= gAdmin4. Attached is the patch to fix the following issues:
    <= li>RM #4290:=C2=A0"string indices must be integers" displayed for= all objects
  • RM #4288:=C2=A0View data issue.
  • PG v12=C2=A0 r= emoves the ability to create table using WITH OIDS, so I have modified the = code in GUI as well as on backend.
  • PG v12 removes obsolete pg_attrd= ef.adsrc and pg_constraint.consrc column, so fixed with appropriate functio= ns calls.
  • For partitioned tables, since no storage is required for = the table itself. PG v12 throws and error while specifying "TABLESPACE= " in create table syntax for partitioned table, so fix that too.=C2=A0=
This is the initial patch to fix the issues that has been ra= ised or I have found. Will continue to work on adding support for v12. Will= check the release notes.=C2=A0

--
<= div dir=3D"ltr" class=3D"gmail-m_2533046114336094462gmail-m_596890020175328= 4473gmail_signature">
= Thanks & Regards
Akshay Joshi<= /b>
= Sr. Software Architect
= EnterpriseDB Software India Private Limited
Mobile: +91 9= 76-788-8246
<= /div>


--
<= div>Thanks & Rega= rds
Akshay Joshi
Sr. Software Architect
=
EnterpriseDB Software India Private Limited<= /b>
Mobile: +91 976-788-8246
=


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @p= gsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL = Company
--0000000000001ef37e058af81da8--