Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gfQjW-0004zR-8O for pgadmin-hackers@arkaria.postgresql.org; Fri, 04 Jan 2019 14:45:58 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gfQjU-00015a-Vw for pgadmin-hackers@arkaria.postgresql.org; Fri, 04 Jan 2019 14:45:56 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gfQjU-0000ys-Kv for pgadmin-hackers@lists.postgresql.org; Fri, 04 Jan 2019 14:45:56 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gfQjR-00079Y-Sk for pgadmin-hackers@postgresql.org; Fri, 04 Jan 2019 14:45:56 +0000 Received: by mail-wm1-x341.google.com with SMTP id p6so1417020wmc.1 for ; Fri, 04 Jan 2019 06:45:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=bKUezU7skbozG5BI8off9JUSHtc1dKoA89O0F/xDHVk=; b=IE0cVkC1mXPzb52crnYoukVUOpElJn9y1OyNGUNuxUyp/4Mx1Gk0CA0B/kgpCbVIiN bMuhttOH4ujplWHqqyweL7diRm2nfSaFd0PCgNsySksQjKZepT6GJwKakGsVhQm+QHk8 I/gGK1HtrdRJMegCTvlCHnPfUo++1OaygaDxdRAk2OU/7lYd7zszjkWafjlpOgJ9IShy /Fa7Rc/X6NLYYgUkZs+SVT8bqvlC5y2ZThmYGVBJ1xZqi+lXuGTBh0bFhykhuXsklX3b +zrbgtNGVfUvZtR3fBIQHk/qhOVoQd58UBuN3tgAZv1mWs7M3TUzSWdqV3XRFx0dIrZt 4b+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=bKUezU7skbozG5BI8off9JUSHtc1dKoA89O0F/xDHVk=; b=fcIH8xM9hmS2G5NpeZ4WWvbXBIUzkWMhljx/qzr3APoeR1OdON99IojHN0LOtGCkEQ VOBSjJyWRlH/wHpGrELQuV3qiMXvPbammHM+in+8wj5pSxalxdu+LyKMzVqd2eq+no29 rKL67RuJZlsOZiVbEdxfPyQbCN4eEpIlc68pTtpHvf0wsLUzr+sw3dYTMBqDw5TCJ6A/ edvPMqJoa4irCbqJF1SDk8n4vMC+KJNrVqeKZKj8zjvVUwrUWHwMKtIwp5+Y0QWiZ0iP 5WdbNow1JiPjVIl4jeiZ0dBf16zMlYIHxLxbqKjG1h42oS2a698kTvzgSJOMU2zuR/d7 vYeg== X-Gm-Message-State: AJcUukeixkFu2JGTXe3ULkKEgXzTiGNZsvBbw27yVFh9z14Shbcf1WPm 516gEFwUZA/6xLKG5fTCwcgwkoJfYkds2sDGXWG4TA== X-Google-Smtp-Source: ALg8bN5H9J4atgRsGKv4S6Fcw04sRzpMTM2oiS7AhsMJFp881HA+bp1zZCX/MusECuCZs0fHaRLS5qqUOatL+8xjD4s= X-Received: by 2002:a1c:a68f:: with SMTP id p137mr1448876wme.64.1546613152562; Fri, 04 Jan 2019 06:45:52 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Fri, 4 Jan 2019 14:45:40 +0000 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM 3702 - pgAdmin dashboard showing the oid for the user-defined tables and table names for the catalog tables in locks monitoring window To: Khushboo Vashi Cc: pgadmin-hackers Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Thanks, patch applied. On Fri, Jan 4, 2019 at 11:53 AM Khushboo Vashi wrote: > > Hi, > > Please find the attached patch to fix RM #3702 - pgAdmin dashboard showin= g the oid for the user-defined tables and table names for the catalog table= s in locks monitoring window. > > Dashboard > Server Activity > Locks - shows the table oid in the 'Target = relation' column instead of table name. > > The attached patch fixes this issue for the database level but not for th= e server level. The reason for this is, at the server level we fetch the d= ata from the pg_locks with the maintenance database, so it can not fetch th= e pg_class relation for the other database tables (relation::regclass). > > Please find the attached screen-shots for the issue and the fix and let m= e know if there is any other way to fix this. > > Thanks, > Khushboo > > --=20 Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company