MIME-Version: 1.0
In-Reply-To: 
 <CAFOhELc-ST96E35Wcih=uXuXYe5ahnb4Qp+WWAYFPDBP1XTr=g@mail.gmail.com>
References: 
 <CAFOhELc-ST96E35Wcih=uXuXYe5ahnb4Qp+WWAYFPDBP1XTr=g@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Mon, 26 Mar 2018 13:37:56 +0100
Message-ID: 
 <CA+OCxow84Sigyn=2QQj4RKEV8ManXNqrg4kSmvhxgvbiFn8cpw@mail.gmail.com>
Subject: Re: [pgAdmin4][Patch]: RM #1978 - Add an option to allow user to
 disable alertifyjs and acitree animations
To: Khushboo Vashi <khushboo.vashi@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="f403045c4e222674a20568500b56"
Precedence: bulk

--f403045c4e222674a20568500b56
Content-Type: text/plain; charset="UTF-8"

Hi

On Mon, Mar 26, 2018 at 7:23 AM, Khushboo Vashi <
khushboo.vashi@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached patch to fix RM #1978: Add an option to allow
> user to disable alertifyjs and acitree animations.
>

I think these really need to be per-user settings, not per-installation..
Whether or not animations are shown is really a matter of personal taste
and circumstance.

Thanks.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--f403045c4e222674a20568500b56
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi<br><div class=3D"gmail_extra"><br><div class=3D"gmail_q=
uote">On Mon, Mar 26, 2018 at 7:23 AM, Khushboo Vashi <span dir=3D"ltr">&lt=
;<a href=3D"mailto:khushboo.vashi@enterprisedb.com" target=3D"_blank">khush=
boo.vashi@enterprisedb.com</a>&gt;</span> wrote:<br><blockquote class=3D"gm=
ail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-le=
ft:1ex"><div dir=3D"ltr">Hi,<div><br></div><div>Please find the attached pa=
tch to fix RM #1978: Add an option to allow user to disable alertifyjs and =
acitree animations.</div></div></blockquote><div><br></div><div>I think the=
se really need to be per-user settings, not per-installation.. Whether or n=
ot animations are shown is really a matter of personal taste and circumstan=
ce.</div><div><br></div><div>Thanks.=C2=A0</div></div><div><br></div>-- <br=
><div class=3D"gmail_signature" data-smartmail=3D"gmail_signature">Dave Pag=
e<br>Blog: <a href=3D"http://pgsnake.blogspot.com" target=3D"_blank">http:/=
/pgsnake.blogspot.com</a><br>Twitter: @pgsnake<br><br>EnterpriseDB UK: <a h=
ref=3D"http://www.enterprisedb.com" target=3D"_blank">http://www.enterprise=
db.com</a><br>The Enterprise PostgreSQL Company<br></div>
</div></div>

--f403045c4e222674a20568500b56--