Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lg69a-0001Lt-Np for pgadmin-hackers@arkaria.postgresql.org; Mon, 10 May 2021 13:40:58 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lg69Y-0008EV-Lp for pgadmin-hackers@arkaria.postgresql.org; Mon, 10 May 2021 13:40:56 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lg69Y-0008EM-0K for pgadmin-hackers@lists.postgresql.org; Mon, 10 May 2021 13:40:56 +0000 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lg69T-00015M-VH for pgadmin-hackers@postgresql.org; Mon, 10 May 2021 13:40:54 +0000 Received: by mail-ej1-x633.google.com with SMTP id m12so24607916eja.2 for ; Mon, 10 May 2021 06:40:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=C8eUWhfbfiBW2fNAzc1nUI+RfPNJBunQ+hHidn2i0vw=; b=chtHPBcsa7bt3geo9Ge2Cx/jJzyZedO44t5jrdgrEIwH6Y86ITsQfbjsdyu12TXon8 oXseLRa6GrDg/uHHRI7Om8x4BrTZQ3/AhOo6I3hMwLTASMDtfR791ru8+j0JAxhwvrC/ hficFBp4uL9X6jnxXB+d44pOgApfZOZAvPoDeihZ/JAVy4npwuOXFqgLOOl46yjHHuFt 345ZOKeruLWhleSh9QWn9wcpXQmiuboGcUEv3XBtUNelYFEKDguv3yuWRt1GKYQxe9RP o5exlzb9hlM/mKwNSlcqskwa6+0Nkwg0HeKf6DdgWnXHjd6/1VcNYe8Cqn/JY+fH5sFy /nSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=C8eUWhfbfiBW2fNAzc1nUI+RfPNJBunQ+hHidn2i0vw=; b=aggSDIJGEKF8VAIs6tH3EAygqs+CDUm0R7klQBH/ax2/RDj9ZC1X9RJCOd0i10Gkaz /U7R46PoOpQELjwNabQASBKvCqyPQwVchOrGT5OHOnyVP0cEkPRrR6yvf83SOi7WUkV0 NT53nWAWf719HNNm8ogPS02CoHZr1jH4GILOqfqoASjOiuZfTR8+bYa1W/0wNtXb9tzg hKAxiTCaEEpfOelobgWHMsaqVKmEQfhtjQxsJ/xeAT6OzYFt9CNpyX7BLxE7Ny/dTM4N iChQkkTPwuv7Z+uZyKwXCvdKxfX3BgNcC8mgi7epHxrwS0iHPo7/ERQlM92SZy6WIH74 Ap8g== X-Gm-Message-State: AOAM532R8lZWuILShLee6RFcrGdOAYmm0zetF7OBklrZ18W/TzeVCgGV NPQw2hAtYqUXajjyyuaU2HY8KaaMMup5wz0DygEQoRPypNCh9w== X-Google-Smtp-Source: ABdhPJy50O+tuQ41Z1v9eYMd2NmOp5LinmlzdAzKocjqAP55+pxoJqGWKh5Li90LHnvLlIgGRCctlHR5PurEKp/rzjs= X-Received: by 2002:a17:906:1617:: with SMTP id m23mr26870588ejd.352.1620654050572; Mon, 10 May 2021 06:40:50 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Mon, 10 May 2021 14:40:39 +0100 Message-ID: Subject: Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL To: Nikhil Mohite Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000fd06d705c1f9ecd6" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000fd06d705c1f9ecd6 Content-Type: text/plain; charset="UTF-8" Hi On Mon, May 10, 2021 at 1:45 PM Nikhil Mohite < nikhil.mohite@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch for RM-2341 > : Add Menu option for > starting PSQL. > 1. Added new Option PSQL Tool in Tools menu. > 2. Added the same option for Server and Database nodes from the tree view. > Unfortunately there's a trailing comma in package.json that makes it invalid. If I fix that, then I get the error below, so I'm guessing the intention was to actually include another package there? ERROR in ./pgadmin/tools/psql/static/js/psql_module.js 23:50-82 Module not found: Error: Can't resolve 'local-echo-controller' in '/Users/dpage/git/pgadmin4/web/pgadmin/tools/psql/static/js' resolve 'local-echo-controller' in '/Users/dpage/git/pgadmin4/web/pgadmin/tools/psql/static/js' Parsed request is a module using description file: /Users/dpage/git/pgadmin4/web/package.json (relative path: ./pgadmin/tools/psql/static/js) aliased with mapping 'local-echo-controller': '/Users/dpage/git/pgadmin4/web/node_modules/local-echo' to '/Users/dpage/git/pgadmin4/web/node_modules/local-echo' using description file: /Users/dpage/git/pgadmin4/web/package.json (relative path: ./pgadmin/tools/psql/static/js) Field 'browser' doesn't contain a valid alias configuration root path /Users/dpage/git/pgadmin4/web using description file: /Users/dpage/git/pgadmin4/web/package.json (relative path: ./Users/dpage/git/pgadmin4/web/node_modules/local-echo) no extension Field 'browser' doesn't contain a valid alias configuration /Users/dpage/git/pgadmin4/web/Users/dpage/git/pgadmin4/web/node_modules/local-echo doesn't exist .js Field 'browser' doesn't contain a valid alias configuration /Users/dpage/git/pgadmin4/web/Users/dpage/git/pgadmin4/web/node_modules/local-echo.js doesn't exist .jsx Field 'browser' doesn't contain a valid alias configuration /Users/dpage/git/pgadmin4/web/Users/dpage/git/pgadmin4/web/node_modules/local-echo.jsx doesn't exist as directory /Users/dpage/git/pgadmin4/web/Users/dpage/git/pgadmin4/web/node_modules/local-echo doesn't exist using description file: /Users/dpage/git/pgadmin4/web/package.json (relative path: ./node_modules/local-echo) no extension Field 'browser' doesn't contain a valid alias configuration /Users/dpage/git/pgadmin4/web/node_modules/local-echo doesn't exist .js Field 'browser' doesn't contain a valid alias configuration /Users/dpage/git/pgadmin4/web/node_modules/local-echo.js doesn't exist .jsx Field 'browser' doesn't contain a valid alias configuration /Users/dpage/git/pgadmin4/web/node_modules/local-echo.jsx doesn't exist as directory /Users/dpage/git/pgadmin4/web/node_modules/local-echo doesn't exist @ ./pgadmin/tools/psql/static/js/index.js 17:19-43 2021-05-10 14:38:37: webpack 5.21.2 compiled with 1 error in 60041 ms -- Dave Page Blog: https://pgsnake.blogspot.com Twitter: @pgsnake EDB: https://www.enterprisedb.com --000000000000fd06d705c1f9ecd6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

On Mon, May 10, 2021= at 1:45 PM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:
Hi Hackers,

Please find the attached = patch for RM-2341:=C2=A0Add Menu option for starting PSQL.
1. A= dded new Option PSQL Tool in Tools menu.
2. Added the same option= for Server and Database nodes from the tree view.
=

Unfortunately=C2=A0there's a trailing comma in pack= age.json that makes it invalid. If I fix that, then I get the error below, = so I'm guessing the intention was to actually include another package t= here?

ERROR in ./pgadmin/tools/psql/static/js= /psql_module.js 23:50-82
Module not found: Error: Can't resol= ve 'local-echo-controller' in '/Users/dpage/git/pgadmin4/web/pg= admin/tools/psql/static/js'
resolve 'local-echo-controlle= r' in '/Users/dpage/git/pgadmin4/web/pgadmin/tools/psql/static/js&#= 39;
=C2=A0 Parsed request is a module
=C2=A0 using desc= ription file: /Users/dpage/git/pgadmin4/web/package.json (relative path: ./= pgadmin/tools/psql/static/js)
=C2=A0 =C2=A0 aliased with mapping = 'local-echo-controller': '/Users/dpage/git/pgadmin4/web/node_mo= dules/local-echo' to '/Users/dpage/git/pgadmin4/web/node_modules/lo= cal-echo'
=C2=A0 =C2=A0 =C2=A0 using description file: /Users= /dpage/git/pgadmin4/web/package.json (relative path: ./pgadmin/tools/psql/s= tatic/js)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 Field 'browser' doe= sn't contain a valid alias configuration
=C2=A0 =C2=A0 =C2=A0= =C2=A0 root path /Users/dpage/git/pgadmin4/web
=C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 using description file: /Users/dpage/git/pgadmin4/web/pac= kage.json (relative path: ./Users/dpage/git/pgadmin4/web/node_modules/local= -echo)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 no extension
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Field 'browser&= #39; doesn't contain a valid alias configuration
=C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 /Users/dpage/git/pgadmin4/web/Users/= dpage/git/pgadmin4/web/node_modules/local-echo doesn't exist
= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 .js
=C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Field 'browser' doesn't contain= a valid alias configuration
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 /Users/dpage/git/pgadmin4/web/Users/dpage/git/pgadmin4/web/no= de_modules/local-echo.js doesn't exist
=C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 .jsx
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 Field 'browser' doesn't contain a valid alias config= uration
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 /Users/d= page/git/pgadmin4/web/Users/dpage/git/pgadmin4/web/node_modules/local-echo.= jsx doesn't exist
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 a= s directory
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 /Use= rs/dpage/git/pgadmin4/web/Users/dpage/git/pgadmin4/web/node_modules/local-e= cho doesn't exist
=C2=A0 =C2=A0 =C2=A0 =C2=A0 using descripti= on file: /Users/dpage/git/pgadmin4/web/package.json (relative path: ./node_= modules/local-echo)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 no extensi= on
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Field 'browser&#= 39; doesn't contain a valid alias configuration
=C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 /Users/dpage/git/pgadmin4/web/node_modules/loc= al-echo doesn't exist
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 .js<= /div>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Field 'browser'= doesn't contain a valid alias configuration
=C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 /Users/dpage/git/pgadmin4/web/node_modules/loca= l-echo.js doesn't exist
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 .j= sx
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Field 'browser&#= 39; doesn't contain a valid alias configuration
=C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 /Users/dpage/git/pgadmin4/web/node_modules/loc= al-echo.jsx doesn't exist
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = as directory
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 /Users/dpa= ge/git/pgadmin4/web/node_modules/local-echo doesn't exist
=C2= =A0@ ./pgadmin/tools/psql/static/js/index.js 17:19-43

<= div>2021-05-10 14:38:37: webpack 5.21.2 compiled with 1 error in 60041 ms
=C2=A0
--
Dave Page
Blog: https://pgsnake.blogspot.com
Twitter: @p= gsnake

EDB: https://www.enterprisedb.com

--000000000000fd06d705c1f9ecd6--