Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gf4d3-0001yn-Ka for pgadmin-hackers@arkaria.postgresql.org; Thu, 03 Jan 2019 15:09:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gf4cz-00031X-HA for pgadmin-hackers@arkaria.postgresql.org; Thu, 03 Jan 2019 15:09:45 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gf4cz-0002xh-4T for pgadmin-hackers@lists.postgresql.org; Thu, 03 Jan 2019 15:09:45 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gf4cv-0003nd-C8 for pgadmin-hackers@lists.postgresql.org; Thu, 03 Jan 2019 15:09:43 +0000 Received: by mail-wr1-x442.google.com with SMTP id 96so33907626wrb.2 for ; Thu, 03 Jan 2019 07:09:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yYD9sFiljvL265a2z6DwboBiPDw5ynu4u2olfd48xs4=; b=WrBE8xFabQ/WUdgz89oaeeJpB4HFZSqKdgtoNIXldnHjakhCSJT5VsqMfgNh0fr5iU Zo3PSg3W4/aMyBXz3zPYPx5/+JteMUb2uheCZEgJxdda0NTN01jsw8ZWsELeBr1yehNU wrSGvhv41TMWJzxN1r9axOgHCJ+GOPd9xB3bo7a9hP9tZZLjg0tapXqzhnVJ9Kiwgo67 UvIMwdnKwnm065tcMlozQxWOYtug++VibEhiu3JgcXQQvEu2LHGqPlWtk+NyV2ihmnj3 DI+X11WuQ5kr4DGrgmrCB3GFz3zX9C/BTpbxDFcjVdb6Wr9ejLYytWK5FRxKpC/iFZ0M zLyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yYD9sFiljvL265a2z6DwboBiPDw5ynu4u2olfd48xs4=; b=OUWadibNKR/8fXuoCCGuPWs3rteV5Y4cvVWIfczWVL1mnLUiSj2JC7f0P1gAH1yhwF 4Zb6HoFa4TnuVVgP5pvpWmC4APW0ZeEqNQP++jsQ7NziLnJcgvd4cGVEwXK/era4OIHf LZHcrUpndVOXRPK8BrxK1ldPBB6M0YADy/T/s/qWTzn83QY4DutRQfddSdCYRXPOiCa7 CcaYLfXfnjKZBYd2SRzrBA3u/yXNUd29I6M2igJxE/kMmtIi4ASlbf4cFXx9ouFPlm/8 XSFmaonTDB9+kuBT6bZQ4XkUvAWPjy1AxRkrHHn9Lo/xQrLOd7xPOmublLXEFd0lY776 fNmw== X-Gm-Message-State: AJcUukcPwD4NXtEAQAxEa94gXSt4mUBS83hUZcQXEJilqgA1SG4A27oH ozhAHk9cgwCi9/7fkr6pWPoVFu6DT8A08xeKKWtkbA== X-Google-Smtp-Source: ALg8bN7H8LFVfYj8RfljA0OrnmaEdBnEKBp8oS0gQNgwwCd8YHkRRBCWzkOv4XYjxAQ1++7lsHpEu4o7yYbcdVeU074= X-Received: by 2002:adf:97d1:: with SMTP id t17mr41099483wrb.283.1546528179700; Thu, 03 Jan 2019 07:09:39 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Thu, 3 Jan 2019 15:09:27 +0000 Message-ID: Subject: Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica To: Aditya Toshniwal Cc: Akshay Joshi , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000c95db0057e8f2675" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000c95db0057e8f2675 Content-Type: text/plain; charset="UTF-8" Hi On Thu, Jan 3, 2019 at 10:20 AM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > Further improvement patch. With this patch, following are fixed: > - Fieldset control design changes > - File dialog - files list header should not scroll with the body and > stick to the top > - Debugger input args dialog cancel button should always be enabled > - Backup globals dialog controls aligmnent correction > - In View Data query tool, explain related buttons should be disabled > - Autocomplete design changes > > I have also fixed one issue which was created by the copyright changes in > the file - pgadmin/misc/file_manager/templates/file_manager/js/languages/en.js. > The en.js file contains json data and adding copyright comments to it > caused JSON parsing failure in file dialog. As an improvement, I have > renamed the file from en.js to en.json at all the places to avoid such > changes in future. > > Kindly review. > Thanks - applied. A few other things that I noticed (or have been bugging me): - The menu bar seems a little cramped. Taking pg-navbar from 32 to 40px and setting the font-weight to normal on the menu options (but not the product name) seems much better to me (and adjusting everything else as required of course). - In the file dialogue, the column headers don't line up with the columns in the rows. - In list mode of the file dialogue, can we use the same coloured icons as we do in icon mode? Obviously smaller... - "Show hidden files and folders ?" shouldn't have a space before the question mark. - The menu bar on the file dialogue doesn't match the styling of the menu bar on the query tool (in fact, even the left and right ends of it are styled differently from each other). - The line numbers in the gutter of CodeMirror are tiny. - I'm not convinced about the boldness of the tab titles - I think the are just a little too harsh - can you change the font-weight to normal for them please (both the wcDocker and Bootstrap tabs)? Also (for another day); we should move the file dialog messages out of the JSON file altogether and use our normal translation mechanisms. Thanks again :-) -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --000000000000c95db0057e8f2675 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

On Thu, Jan 3, 2019 at 10:20 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>= wrote:
Hi Hackers,

Further improvement = patch. With this patch, following are fixed:
- Fieldset control design changes
- File= dialog - files list header should not scroll with the body and stick to th= e top
- Debugger input args dialog cancel button should always be enabled=
- Backup gl= obals dialog controls aligmnent correction
- In View Data query tool, explain re= lated buttons should be disabled
- Autocomplete design changes
=
= I have also fixed one = issue which was created by the copyright changes in the file -=C2=A0pgadmin/misc/file_manager/templates/file_manager/= js/languages/en.js. The en.js file contains json data and adding copyright = comments to it caused JSON parsing failure in=C2=A0file dialog= .= As an improvement, I have renamed the file from en.js to en.json at all th= e places to avoid such changes in future.

Kindly review.

Thanks - applied.=C2=A0

A f= ew other things that I noticed (or have been bugging me):

- The menu bar seems a little cramped. Taking pg-navbar from 32 to = 40px and setting the font-weight to normal on the menu options (but not the= product name) seems much better to me (and adjusting everything else as re= quired of course).

- In the file dialogue, the col= umn headers don't line up with the columns in the rows.

<= /div>
- In list mode of the file dialogue, can we use the same coloured= icons as we do in icon mode? Obviously smaller...

- "Show hidden files and folders ?" shouldn't have a space b= efore the question mark.

- The menu bar on the fil= e dialogue doesn't match the styling of the menu bar on the query tool = (in fact, even the left and right ends of it are styled differently from ea= ch other).

- The line numbers in the gutter = of CodeMirror are tiny.

- I'm not convinced ab= out the boldness of the tab titles - I think the are just a little too hars= h - can you change the font-weight to normal for them please (both the wcDo= cker and Bootstrap tabs)?

Also (for another day); = we should move the file dialog messages out of the JSON file altogether and= use our normal translation mechanisms.

Thanks aga= in :-)

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseD= B UK: http://www.= enterprisedb.com
The Enterprise PostgreSQL Company
--000000000000c95db0057e8f2675--