Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cQApe-0007je-4l for pgadmin-hackers@arkaria.postgresql.org; Sun, 08 Jan 2017 10:36:10 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1cQApd-00047V-Hj for pgadmin-hackers@arkaria.postgresql.org; Sun, 08 Jan 2017 10:36:09 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cQApP-0003sq-QA for pgadmin-hackers@postgresql.org; Sun, 08 Jan 2017 10:35:55 +0000 Received: from mail-io0-x22a.google.com ([2607:f8b0:4001:c06::22a]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1cQApL-0006xg-NH for pgadmin-hackers@postgresql.org; Sun, 08 Jan 2017 10:35:55 +0000 Received: by mail-io0-x22a.google.com with SMTP id v96so62495688ioi.0 for ; Sun, 08 Jan 2017 02:35:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=b4wApBItG++xgEBS/SuquzcpUG7Lkq1IOeF63Dhl0NU=; b=OrGT1HrT21X7RVn3pfMTycdunTvKk5ZPMUMVu7GNuv5n2zDaZgBhgMsN8A8RpzT5j8 R54sZh4/c4TgjRxWEEZl4QMsl+zR7ATpx2OwpXYPI4SQd0UskepcrV6B6Pgw03p+386c mPspOBmXOSGPvSK0qmkMG0vo+dQ88m6mCozVENQAME+Ml7kqiwYkYBwYqBK2VjK5V6Zq JykbhEQrtEfMWdFB53ybUWb+ekIy6oNAQnRYRrFqnOCYYKU91YK+cWiPEQxUnzKZDCJz JW6l5Al6IFSclW1KPY9jCkceFVeVfjmzGElRvzPs8Xq9FMWwLpzFO/96fXx7nNGfqYx3 A8kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=b4wApBItG++xgEBS/SuquzcpUG7Lkq1IOeF63Dhl0NU=; b=j/yUIvM8jgQLMkqHGt1xN0+WKWAUUbLD0YcU3UyvJY6HBEabCqDpJin8h/kU3voJpG +OY4hXlUjvpMFOxJq6Cr9yk2p+qvwVmJ6MgW8pEYfKCEXU9uwWA6kuhuU91cisxutyss YZoWHIlsjRVQYfe168OgfQBueTkjlAUqiS5DmBtyHo1be1rmYncqKFm+kRK3H8vc5nqJ GTh9xIItGjHzWXre3LefcnROsTkmNq/KIcCoXN+oPuL3eGhT6N1GUQOYdiJiuOf+01/c s5koz0v8jCIzpDJUFf9ZJeZjOdzxIRKIiwc+XHZzcfJE6+LNBb5i+31l4yheoOqSDIWn 6ykw== X-Gm-Message-State: AIkVDXIJG6LM2xBQl7p/SFj09kUvMbI5fUlKEAhUCywdr/Iod2EMNW2Ssf1/mQzmp/4W0rO2BZkSWSl/SOy6Iw== X-Received: by 10.107.11.27 with SMTP id v27mr13800518ioi.145.1483871749600; Sun, 08 Jan 2017 02:35:49 -0800 (PST) MIME-Version: 1.0 Received: by 10.64.224.198 with HTTP; Sun, 8 Jan 2017 02:35:49 -0800 (PST) In-Reply-To: References: From: Dave Page Date: Sun, 8 Jan 2017 10:35:49 +0000 Message-ID: Subject: Re: PATCH: Dialogue control buttons should be consistent (pgAdmin4) To: Murtuza Zabuawala Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=001a113f8288870a6d054592d085 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a113f8288870a6d054592d085 Content-Type: text/plain; charset=UTF-8 Thanks, patch applied. On Friday, January 6, 2017, Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue where some dialogue control buttons were not > consistent with others dialogs. > RM#1364 > > Patch fixes, > 1) Preferences: Close, Maximise, Pin > - Removed Pin button > > 2) Wizards: Close > - Added Maximise button, which is can used with 'show_header_maximize_btn' > option. > > 3) Properties: Close > - N/A, As this is custom wcDocker panel not alertify dialog. > > 4) User manager: Maximise > - We can't have close button in User Manager as data validation was main > requirement, If user clicks on right top close button while having dirty > data in dialog then we can't stop alertify dialog from closing even with > confirm prompt hence we have removed the button. > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a113f8288870a6d054592d085 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Thanks, patch applied.

On Friday, January 6, 2017, Murtuza Zabuawala= <murtuza.zabuawal= a@enterprisedb.com> wrote:
Hi,

PFA patch to fix the issue where =C2=A0som= e dialogue control buttons were not consistent with others dialogs.
RM#1364

Patch fixes,
1) Prefere= nces: Close, Maximise, Pin=C2=A0
- Removed Pin = button

2) Wizards: Clo= se=C2=A0
- Added Maximise button, which is can used= with 'show_header_maximize_btn= 9; option.

3) P= roperties: Close
- N/A, As this is custom wcDocker panel = not alertify dialog.

4) User manager: Maximise=C2=A0
- We can&= #39;t have close button in User Manager as data validation was main require= ment, If user clicks on right top close button while having dirty data in d= ialog then we can't stop alertify dialog from closing even with confirm= prompt hence we have removed the button.


--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com<= br style=3D"color:rgb(136,136,136)">= The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @= pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL= Company

--001a113f8288870a6d054592d085--