Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZemY-0003at-F4 for pgadmin-hackers@arkaria.postgresql.org; Fri, 03 Feb 2017 14:24:10 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1cZemY-0007St-2H for pgadmin-hackers@arkaria.postgresql.org; Fri, 03 Feb 2017 14:24:10 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cZemJ-0007Dy-TQ for pgadmin-hackers@postgresql.org; Fri, 03 Feb 2017 14:23:56 +0000 Received: from mail-it0-x232.google.com ([2607:f8b0:4001:c0b::232]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1cZemC-0005Jc-Gf for pgadmin-hackers@postgresql.org; Fri, 03 Feb 2017 14:23:54 +0000 Received: by mail-it0-x232.google.com with SMTP id 203so12240567ith.0 for ; Fri, 03 Feb 2017 06:23:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=P700QVKa155cTmGpARxzO6o9SKM6exRCtLxjpn4zkWc=; b=T/MJbtYhZrtpFE7LX2hnK0DFf2fe7zp28p70pOSxsHIGlY6orSKUYsZxOjYKVCn7Nd KxNssqQZqn/2jZvdlJucFYpVw/qlxxwHwLB4sXSspdDxLeIkK4WbVvwB7pVVBr6kDNJ/ ytUro8WyHeMuC0B9/rqQZDqv6io54pMICyxtCNW1fwO7nsiwHJ7Ny07YZu+1bDxSAY1i pw07qthzRugtYQzHfIuckgSQWWPJptHqoxkpeJVgYgkZ9MLb0+cZ98pSKvwFHgGcirKp cWRzqbPfSkCKMtFSp+PB2Wu3A/KmeKT+U1Zq1ZJyVyA2if5O9+ryPoIxy9WNgpwj2Y5P pt2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=P700QVKa155cTmGpARxzO6o9SKM6exRCtLxjpn4zkWc=; b=hVGinQvB2A+MbigP9QCxxj5LB93iS2iAGd1mYSm/uE95Rw070yj3xBj00NngiI8nwx o/hTbP+uM2dQJGB+eF6ZSm1B58uoIjcdlzs8+gu2uoX3rHp14vUK8N++trU3aeTxOomE 8QCfkH6RmDxFAv6B/BhDyEFnV3qL33fwog+tLQMgK5kfaAfFz0AELepxm3HnqpdHYMhV awXJLJdnNY5x4KT5QCJLgnPP2Cf5p0ebd0Tk5VpBWLRhscGf1s0mflcFgmD4WWP1CrxP 7ex0d2Z92VpCv6Z6AobS32n4TOrDEgTtndJ4q7tjTNW8yg4XkxsbmwgwmwOYCDfIqA4d EXXw== X-Gm-Message-State: AIkVDXJmZHGykmn4pPUnmsTblen8huHJlW1D3DJFcN3fJnMeg84fZ7OxYHn6N1RW1AIHkkcj4cKV3Eu8+p3jgcKaufDo07wPqJaS3giQW3cEC/wE0V8ZrIdeISNl+V+bgyDSpDGrDMf499XY8WBL4rWT5sYx40mVkejCgCleF7uSufvJZoNJZCG6VzQyT5/6xVKq2GRkGA== X-Received: by 10.36.122.208 with SMTP id a199mr1256232itc.74.1486131827431; Fri, 03 Feb 2017 06:23:47 -0800 (PST) Received: from mail-io0-f172.google.com (mail-io0-f172.google.com. [209.85.223.172]) by smtp.gmail.com with ESMTPSA id h69sm989510ith.16.2017.02.03.06.23.46 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 03 Feb 2017 06:23:46 -0800 (PST) Received: by mail-io0-f172.google.com with SMTP id j18so18372757ioe.2 for ; Fri, 03 Feb 2017 06:23:46 -0800 (PST) X-Received: by 10.107.11.27 with SMTP id v27mr10747152ioi.145.1486131826099; Fri, 03 Feb 2017 06:23:46 -0800 (PST) MIME-Version: 1.0 Received: by 10.64.224.198 with HTTP; Fri, 3 Feb 2017 06:23:45 -0800 (PST) In-Reply-To: References: From: Dave Page Date: Fri, 3 Feb 2017 14:23:45 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [pgAdmin4][Patch]: RM 2089 - PARALLEL SAFE support for functions missing To: Khushboo Vashi Cc: Akshay Joshi , pgadmin-hackers Content-Type: multipart/alternative; boundary=001a113f8288959f4f0547a1074e X-Pg-Spam-Score: -2.1 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a113f8288959f4f0547a1074e Content-Type: text/plain; charset=UTF-8 On Fri, Feb 3, 2017 at 1:59 PM, Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > > > On Fri, Feb 3, 2017 at 7:02 PM, Dave Page > wrote: > >> I doubt the order matters, but feel free to change it if it bugs you :-) >> >> > I have tried to create the function with both SQL commands. > There is no bug, its just in pgAdmin4, if its not leakproof then we > mentioned 'NOT LEAKPROOF' in the SQL. > So, I am not sure, we should remove it or not. > Well we should be consistent - we either list the full set of all options, or just the non-default ones. The main thing is that we don't explicitly show options that are the default in some cases, but not in others. > > On Fri, Feb 3, 2017 at 12:54 PM, Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> Hi Dave >>> >>> I have reviewed the patch and after applying it output in pgAdmin4 >>> >>> CREATE OR REPLACE FUNCTION public.st_intersects(geom1 geometry, geom2 >>> geometry) >>> RETURNS boolean >>> LANGUAGE 'sql' >>> COST 100.0 >>> *IMMUTABLE NOT LEAKPROOF * >>> * PARALLEL SAFE* >>> AS $function$ >>> SELECT $1 OPERATOR(public.&&) $2 AND public._ST_Intersects($1,$2) >>> $function$; >>> >>> but as per psql it should be >>> >>> CREATE OR REPLACE FUNCTION public.st_intersects(geom1 geometry, geom2 >>> geometry) >>> >>> RETURNS boolean >>> >>> LANGUAGE sql >>> >>> *IMMUTABLE PARALLEL SAFE* >>> >>> AS $function$SELECT $1 OPERATOR(public.&&) $2 AND >>> public._ST_Intersects($1,$2)$function$ >>> >>> >>> is this behaviour correct?? >>> >>> >>> >>> On Fri, Feb 3, 2017 at 5:31 PM, Khushboo Vashi < >>> khushboo.vashi@enterprisedb.com> wrote: >>> >>>> Hi, >>>> >>>> Please find the attached patch to fix RM 2089 : PARALLEL SAFE support >>>> for functions missing. >>>> >>>> Fix: Incorporated the PARALLEL SAFE support for the functions and >>>> procedures for PostgreSQL 9.6. >>>> >>>> Thanks, >>>> Khushboo >>>> >>>> >>>> >>>> -- >>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>>> To make changes to your subscription: >>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>> >>>> >>> >>> >>> -- >>> *Akshay Joshi* >>> *Principal Software Engineer * >>> >>> >>> >>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 >>> 976-788-8246 <+91%2097678%2088246>* >>> >> >> >> >> -- >> Dave Page >> VP, Chief Architect, Tools & Installers >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> > > -- Dave Page VP, Chief Architect, Tools & Installers EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company Blog: http://pgsnake.blogspot.com Twitter: @pgsnake --001a113f8288959f4f0547a1074e Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On Fri, Feb 3, 2017 at 1:59 PM, Khushboo Vashi <khushboo= .vashi@enterprisedb.com> wrote:


On Fri, Feb 3, 2017 at 7:02 PM, Dave Page <dave.page@enterprisedb.com> wrote:
I doubt the order matters, but feel free to = change it if it bugs you :-)


=
I have tried to create the function with both SQL command= s.=C2=A0
There is no bug, its just in pgAdmin4, if its not leakpr= oof then we mentioned 'NOT LEAKPROOF' =C2=A0in the SQL.
S= o, I am not sure, we should remove it or not.

Well we should be consistent - we either list th= e full set of all options, or just the non-default ones. The main thing is = that we don't explicitly show options that are the default in some case= s, but not in others.
=C2=A0
=

On Fri, Feb 3, 2017 at 12:54 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Dave=C2=A0

I have = reviewed the patch and after applying it output in pgAdmin4 =C2=A0

CREATE OR REPLACE FUNCTION public.st_intersects(geom1= geometry, geom2 geometry)
=C2=A0 =C2=A0 RETURNS boolea= n
=C2=A0 =C2=A0 LANGUAGE 'sql'
=C2=A0 = =C2=A0 COST 100.0
=C2=A0 =C2=A0 IMMUTABLE NOT LEAKPR= OOF=C2=A0
=C2=A0 =C2=A0 PARALLEL SAFE
AS $function$
SELECT $1 OPERATOR(public.&&) $2 AND publi= c._ST_Intersects($1,$2)
$function$;

but as per psql it should be=C2=A0

<= div>

CREATE OR REPLACE FUNCTION public.st_intersects(geom1 geometry, geom2 = geometry)

=C2=A0RETURNS boolean

=C2=A0LANGUAGE sql

=C2=A0IMMUTABLE PARALLEL SAFE

AS $function$SELECT $1 OPERATOR(public.&&) $2 AND public._ST_Inter= sects($1,$2)$function$


is this behaviour correct??



On Fri, Feb 3, 2017 at 5:31 PM, Khushboo = Vashi <khushboo.vashi@enterprisedb.com> w= rote:
Hi,

Please find the attached patch to fix RM 2089 : PARALLEL SAFE suppo= rt for functions missing.

Fix: Incorporated the = =C2=A0PARALLEL SAFE support for the functions and procedures for PostgreSQL= 9.6.

Thanks,
Khushboo



--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-ha= ckers



<= div>
--
Principal Software Engineer=C2=A0

<= /b>
=




--
Dave Page
VP, Chief Architect, Tools & I= nstallers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Co= mpany

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake




--
Dave Page
VP, Ch= ief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
Th= e Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pg= snake
--001a113f8288959f4f0547a1074e--