Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b3pDM-0005se-3x for pgadmin-hackers@arkaria.postgresql.org; Fri, 20 May 2016 18:32:00 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1b3pDL-00010v-Ld for pgadmin-hackers@arkaria.postgresql.org; Fri, 20 May 2016 18:31:59 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1b3pDL-00010p-1d for pgadmin-hackers@postgresql.org; Fri, 20 May 2016 18:31:59 +0000 Received: from mail-ig0-x232.google.com ([2607:f8b0:4001:c05::232]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1b3pDG-00031h-Sh for pgadmin-hackers@postgresql.org; Fri, 20 May 2016 18:31:58 +0000 Received: by mail-ig0-x232.google.com with SMTP id bi2so142588643igb.0 for ; Fri, 20 May 2016 11:31:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=9dYKKvnrIvjg6hQh/kZMV46XgmX7CSawUaP/bjovOx8=; b=ermgUsHXL8Aim/aP088T3XPpmQofS5VTySMX4hd81+GU0klKWls3f60BlhgnukAiYA s7AWCTAm/Fa3J2Pg96coG79Mw5BSYhSUEhTxi1S4chCQ5ufmLUAOGFccyy/gVovqK5dD t1ai6eJv/7POogE7cNfLQkuJhWvAwTXv2cRiX2WMJjnT2HSqLiwqhsI7S+FDMGa9af0T qxtmmDNgiOUnUIWvC+Ptbhq2TLbv9B2/wuNNDIXjsixCL/HYDwwKQY3D0uC7VKH+4L/1 /4zn0bgEs4MoWkjPo/uPCvFbDRcE+fA7GGO2Fl4P39LoZQqsfTS5rHrSzAZODIyPoBOZ OISw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=9dYKKvnrIvjg6hQh/kZMV46XgmX7CSawUaP/bjovOx8=; b=ig0fzt35g5xYuRSHSZDEAUqZFK2sVHmxbMDINz2a+vLcm19Pv3mibA/Tezygji8QVK 0MJlaz7iubsLuXCE1ZgXU8T9OkgHjt+taGo8HRDFU+B/emZSzKgABMt47jDw2u+FD6SX Tof/HAAvl+M0vxU6e4Xmxm3W8eO6mMp2n4HzHibEwaVXHNI5TZR2KNhwNaMek6RGw4Vz iadVboVlkcePpAxIQ+tH/69Ku5yBaoui35lYBj3e4W/HCHY3KzPJqH8SYfixqVA76I+/ E5KyQYlHM7yj3rLxM2OXIUbT54Qc8VWMakSDJhb3EuCDER3q5WQ5vxHCZrjkTJBYSJuK KE7w== X-Gm-Message-State: AOPr4FXMnWyq0pVZVBqhvHf0POqVkI6l6ejq9zA9534TJ6v9NOflBOIydmpMkqyw+u4aDlBBCJqwZnacOrMNRA== MIME-Version: 1.0 X-Received: by 10.50.73.169 with SMTP id m9mr4320380igv.11.1463769112862; Fri, 20 May 2016 11:31:52 -0700 (PDT) Received: by 10.64.236.101 with HTTP; Fri, 20 May 2016 11:31:52 -0700 (PDT) In-Reply-To: References: Date: Fri, 20 May 2016 14:31:52 -0400 Message-ID: Subject: Re: [PATCH] Tables node (pgAdmin4) From: Dave Page To: Akshay Joshi Cc: Harshal Dhumal , pgadmin-hackers Content-Type: multipart/alternative; boundary=089e0115f64401a66a05334a4ec8 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --089e0115f64401a66a05334a4ec8 Content-Type: text/plain; charset=UTF-8 Hi I just started to take a look at the table dialogue and friends. Here are a few issues that we need to address - please take care of them: 1) Move columns to their own tab. Vertical scrolling is bad. 2) Similarly, move constraints to their own tab. 3) Ensure all labels only have a capital letter on the first word, except if following words are keywords or acronyms, e.g. With default values? Has OIDs? 4) s/System tabel?/System table? 5) Error messages on fields should not be shown unless the field loses focus and has an error (see Create Table) 6) The sections on the Properties view are not as they should be. As I've pointed out before, the "General" section should have a limited subset of information, e.g. name, oid, owner, tablespace, comment and "is system?" Other properties should be in other appropriate sections. 7) Variables grids should not be on the Security tab (as also mentioned previously). 8) Field labels that imply a question (e.g. usually those with a Yes/No switch for input) should end in a ? - e.g. "Deferrable?" 9) On the Trigger dialogue, "Fires" and following controls should move to a new tab. 10) On the MV dialogue, VACUUM settings should be on their own tab, as on the Table dialogue. 11) Privileges controls on the Properties lists should be in a "Security" group, not "General" I think there are a couple of basic principles to follow here: - Make properties lists and dialogues consistent with existing ones, from control grouping right down to spelling and case of labels. - Dialogs should never need vertical scrolling by default (e.g. for a new object with no columns/constraints/whatever yet defined). If you need to scroll, then things should be moved to a new tab, grouped as appropriate. Thanks. On Fri, May 20, 2016 at 7:57 AM, Akshay Joshi wrote: > Thanks - Committed with minor changes. > > On Thu, May 19, 2016 at 10:47 PM, Harshal Dhumal < > harshal.dhumal@enterprisedb.com> wrote: > >> Hi, >> >> PFA updated patch for table and all it's child nodes (Version 9). This >> patch does not depend on any of existing table node patch. >> >> Major change in this patch: Unlike pgAdmin3 now in table create mode any >> constraint(s) created (but not saved) will listen to table column changes >> and adapt themselves accordingly. >> >> For e.g. >> In table create mode user adds column definition with name "col1" then >> adds constraint which includes column "col1". Now user changes column name >> to "col2" then constraint will listen to this change and adapt the column >> name from "col1" to "col2" in constraint definition. Also if column "col2" >> is removed then constraint will also remove the column "col2" from it's >> definition. >> >> >> -- >> *Harshal Dhumal* >> *Software Engineer * >> >> >> >> EenterpriseDB >> >> >> >> -- >> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >> To make changes to your subscription: >> http://www.postgresql.org/mailpref/pgadmin-hackers >> >> > > > -- > *Akshay Joshi* > *Principal Software Engineer * > > > > *Phone: +91 20-3058-9517 <%2B91%2020-3058-9517>Mobile: +91 976-788-8246* > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --089e0115f64401a66a05334a4ec8 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi

I just started to take a look a= t the table dialogue and friends. Here are a few issues that we need to add= ress - please take care of them:

1) Move columns t= o their own tab. Vertical scrolling is bad.

2) Sim= ilarly, move constraints to their own tab.

3) Ensu= re all labels only have a capital letter on the first word, except if follo= wing words are keywords or acronyms, e.g.

=C2=A0 W= ith default values?
=C2=A0 Has OIDs?
=C2=A0=C2=A0
=
4) s/System tabel?/System table?

5) Error mes= sages on fields should not be shown unless the field loses focus and has an= error (see Create Table)

6) The sections on the P= roperties view are not as they should be. As I've pointed out before, t= he "General" section should have a limited subset of information,= e.g. name, oid, owner, tablespace, comment and "is system?" Othe= r properties should be in other appropriate sections.

<= div>7) Variables grids should not be on the Security tab (as also mentioned= previously).

8) Field labels that imply a questio= n (e.g. usually those with a Yes/No switch for input) should end in a ? - e= .g. "Deferrable?"

9) On the Trigger dial= ogue, "Fires" and following controls should move to a new tab.

10) On the MV dialogue, VACUUM settings should be on= their own tab, as on the Table dialogue.

11) Priv= ileges controls on the Properties lists should be in a "Security"= group, not "General"

I think ther= e are a couple of basic principles to follow here:

- Make properties lists and dialogues consistent with existing ones, from = control grouping right down to spelling and case of labels.

<= /div>
- Dialogs should never need vertical scrolling by default (e.g. f= or a new object with no columns/constraints/whatever yet defined). If you n= eed to scroll, then things should be moved to a new tab, grouped as appropr= iate.

Thanks.

On Fri, May 20, 2016 at 7:57 AM, Akshay Jo= shi <akshay.joshi@enterprisedb.com> wrote:
Thanks - Committed with minor= changes.

On Thu, May 19, 2016 at 10:47 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
=
Hi,

PFA updat= ed patch for table and all it's child nodes (Version 9). This patch doe= s not depend on any of existing table node patch.

Major change in this patch: Unlike pgAdmin3 now in ta= ble create mode any constraint(s) created (but not saved) will listen to ta= ble column changes and adapt themselves accordingly.

For e.g.
In table cr= eate mode user adds column definition with name "col1" then adds = constraint which includes column "col1". Now user changes column = name to "col2" then constraint will listen to this change and ada= pt the column name from "col1" to "col2" in constraint = definition. Also if column "col2" is removed then constraint will= also remove the column "col2" from it's definition.


--=C2=A0
Harshal Dhuma= l
Software Engineer=C2=A0


<= div>



--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=




--
Akshay Joshi=
Pri= ncipal Software Engineer=C2=A0


Phone: +91 20-3058-9517
Mobile: +91 97= 6-788-8246



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake=

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Compan= y
--089e0115f64401a66a05334a4ec8--