Re: Regarding feature "Option to skip Password-Dialog for identity file"

public inbox for [email protected]  
help / color / mirror / Atom feed

From: Dave Page <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: Aditya Toshniwal <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: Regarding feature "Option to skip Password-Dialog for identity file"
Date: Tue, 30 Sep 2025 09:10:33 +0100
Message-ID: <CA+OCxowBusxm5ivqYnPdRKonuAYfxDyN_0+LuQdLwh30_bhM1Q@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDfJCK34PWAz_Pu-zSPfXZHcRwvPFH+xBptTKPY8KPUEuA@mail.gmail.com>
References: <CANxoLDch_B=O+zYcOL9=WMabnif8TRe-bxEbCwtkiZ0XXhHF5g@mail.gmail.com>
	<CAM9w-_nQoD0WwEWwGaWCKkR1k6R+jpJdyFHSwp8RnvocMt9CBQ@mail.gmail.com>
	<CANxoLDcqZzUp1fG5Y_ovDv4wGPj_JrZAALQ0ArAWg4vL+yCEWg@mail.gmail.com>
	<CAM9w-_kQNzh7kBJuAftKsz9N=q8mgsuWCRWi6rEeZ8XaNpsudw@mail.gmail.com>
	<CANxoLDfbDmj9NcKeH0+bnvXSn3rxLkAZHE65r=Cx+72hfmbnUg@mail.gmail.com>
	<CAM9w-_=ChSv6-wqhsKeGk5PdzEJ-4=J-0m1kEq6U8ULU58hHKA@mail.gmail.com>
	<CANxoLDcfEe-UfSfwkSVuC3YLT3wTPac+Vat5SQKaY8MeOotonA@mail.gmail.com>
	<CAM9w-_=EkE2s=Pb7LSZnT4mC6QDOC7BLORhj_FiXq7Hh5ZMQnA@mail.gmail.com>
	<CANxoLDfJCK34PWAz_Pu-zSPfXZHcRwvPFH+xBptTKPY8KPUEuA@mail.gmail.com>

On Tue, 30 Sept 2025 at 08:37, Akshay Joshi <[email protected]>
wrote:

>
>
> On Tue, Sep 30, 2025 at 11:56 AM Aditya Toshniwal <
> [email protected]> wrote:
>
>> Hi Akshay,
>>
>> On Tue, Sep 30, 2025 at 11:50 AM Akshay Joshi <
>> [email protected]> wrote:
>>
>>>
>>>
>>> On Tue, Sep 30, 2025 at 11:41 AM Aditya Toshniwal <
>>> [email protected]> wrote:
>>>
>>>> Hi Akshay,
>>>>
>>>> On Tue, Sep 30, 2025 at 11:36 AM Akshay Joshi <
>>>> [email protected]> wrote:
>>>>
>>>>>
>>>>>
>>>>> On Tue, Sep 30, 2025 at 11:29 AM Aditya Toshniwal <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi Akshay,
>>>>>>
>>>>>> Even if you show the password dialog for the first time, the above
>>>>>> scenarios are applicable.
>>>>>> For the context of showing the password prompt first time or not -
>>>>>> I'm suggesting we try first and then show the password prompt.
>>>>>>
>>>>>
>>>>>    I tried that implementation, but what if the user doesn’t want a
>>>>> password prompt at all when the identity file has no password? Do you think
>>>>> the solution you provided fully meets the user’s requirements?
>>>>>
>>>> It will work the same as the existing flow. Users can proceed without
>>>> entering any password.
>>>>
>>>
>>>    That’s exactly what the user doesn’t want. The feature request has a
>>> clear subject line: *“Option to skip Password-Dialog for identity
>>> file.”* Similar requests have been raised by other users in the past,
>>> which we closed as duplicates.
>>>
>> The request is to skip the password initially when connecting if an
>> identity file is used. Subsequent prompts cannot be avoided if the
>> connection fails.
>> Later this can be improved further in future once sshtunnel provide more
>> details.
>>
> I’m not convinced by this solution. Could you explain what issues you see
> with the approach I proposed? To me, it seems simple: if a user has an
> identity file without a password, disable the prompt; if the identity file
> has a password, enable the prompt. Straightforward.
> I’ll wait for Dave or others to share their thoughts on this.
>

I'd prefer to try to handle this more as Aditya suggests, to avoid having
an additional config option. However, it certainly sounds like the ssh
library makes this impractical and potentially confusing, so I think the
cleanest and most usable solution is likely to add the "Prompt for
password" checkbox that Akshay suggests.

-- 
Dave Page
pgAdmin: https://www.pgadmin.org
PostgreSQL: https://www.postgresql.org
pgEdge: https://www.pgedge.com

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Regarding feature "Option to skip Password-Dialog for identity file"
  In-Reply-To: <CA+OCxowBusxm5ivqYnPdRKonuAYfxDyN_0+LuQdLwh30_bhM1Q@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox