MIME-Version: 1.0
In-Reply-To: 
 <CAE+jjakOhMJBMqsUaQuL9w4an0V4Q4nvY51K3GqWzm8jbj9cog@mail.gmail.com>
References: 
 <CAE+jjakOhMJBMqsUaQuL9w4an0V4Q4nvY51K3GqWzm8jbj9cog@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Fri, 9 Feb 2018 11:54:54 +0000
Message-ID: 
 <CA+OCxowBzhOaJf1_w1gPhOR4TH3bdtKBsdqETAqSwK0n2GWezg@mail.gmail.com>
Subject: Re: [pgadmin][patch] [GreenPlum] When user press Explain Plan and
 Explain analyze plan an error is displayed
To: Joao De Almeida Pereira <jdealmeidapereira@pivotal.io>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="f403045d5a6067bda50564c63244"
Precedence: bulk

--f403045d5a6067bda50564c63244
Content-Type: text/plain; charset="UTF-8"

Thanks, patches applied.

On Fri, Feb 2, 2018 at 10:50 PM, Joao De Almeida Pereira <
jdealmeidapereira@pivotal.io> wrote:

> Hi Hackers,
> This is quite a big patch in order to solve the problem with the Explain
> Plan.
>
> We sent 2 patches that have the following:
> *- update-javascript-packages.diff *
>     Add package:
>      is-docker to select a specific setting when running the Chrome tests
> in
>      Docker
>
>     Upgrade the version of:
>     - babel-loader
>     - extract-text-webpack-plugin
>     - jasmine-core
>     - jasmine-enzyme
>     - moment
> *- explain-plan-greenplum.diff*
>   Extract SQLEditor.execute and SQLEditor._poll into their own files and
> add test around them
>   Extract SQLEditor backend functions that start executing query to their
> own files and add tests around it
>   Move the Explain SQL from the front-end and now pass the Explain plan
> parameters as a JSON object in the start query call.
>   Extract the compile_template_name into a function that can be used by
> the different places that try to select the version of the template and the
> server type
>
>
> Thanks
> Joao
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--f403045d5a6067bda50564c63244
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Thanks, patches applied.</div><div class=3D"gmail_extra"><=
br><div class=3D"gmail_quote">On Fri, Feb 2, 2018 at 10:50 PM, Joao De Alme=
ida Pereira <span dir=3D"ltr">&lt;<a href=3D"mailto:jdealmeidapereira@pivot=
al.io" target=3D"_blank">jdealmeidapereira@pivotal.io</a>&gt;</span> wrote:=
<br><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-lef=
t:1px #ccc solid;padding-left:1ex"><div dir=3D"ltr">Hi Hackers,<div>This is=
 quite a big patch in order to solve the problem with the Explain Plan.</di=
v><div><br></div><div>We sent 2 patches that have the following:</div><div>=
<b>-=C2=A0update-javascript-packages.<wbr>diff=C2=A0</b></div><div><div>=C2=
=A0 =C2=A0 Add package:<br></div><div>=C2=A0 =C2=A0 =C2=A0is-docker to sele=
ct a specific setting when running the Chrome tests in</div><div>=C2=A0 =C2=
=A0 =C2=A0Docker</div><div><br></div><div>=C2=A0 =C2=A0 Upgrade the version=
 of:</div><div>=C2=A0 =C2=A0 - babel-loader</div><div>=C2=A0 =C2=A0 - extra=
ct-text-webpack-plugin</div><div>=C2=A0 =C2=A0 - jasmine-core</div><div>=C2=
=A0 =C2=A0 - jasmine-enzyme</div><div>=C2=A0 =C2=A0 - moment</div></div><di=
v><b>-=C2=A0explain-plan-greenplum.diff</b></div><div>=C2=A0 Extract SQLEdi=
tor.execute and SQLEditor._poll into their own files and add test around th=
em</div><div>=C2=A0 Extract SQLEditor backend functions that start executin=
g query to their own files and add tests around it</div><div>=C2=A0 Move th=
e Explain SQL from the front-end and now pass the Explain plan parameters a=
s a JSON object in the start query call.</div><div>=C2=A0 Extract the compi=
le_template_name into a function that can be used by the different places t=
hat try to select the version of the template and the server type</div><div=
><br></div><div><br></div><div>Thanks</div><span class=3D"HOEnZb"><font col=
or=3D"#888888"><div>Joao</div></font></span></div>
</blockquote></div><br><br clear=3D"all"><div><br></div>-- <br><div class=
=3D"gmail_signature" data-smartmail=3D"gmail_signature">Dave Page<br>Blog: =
<a href=3D"http://pgsnake.blogspot.com" target=3D"_blank">http://pgsnake.bl=
ogspot.com</a><br>Twitter: @pgsnake<br><br>EnterpriseDB UK: <a href=3D"http=
://www.enterprisedb.com" target=3D"_blank">http://www.enterprisedb.com</a><=
br>The Enterprise PostgreSQL Company<br></div>
</div>

--f403045d5a6067bda50564c63244--