MIME-Version: 1.0
In-Reply-To: 
 <CAG7mmozCem=oAs-fa8HJF=FTUb0aSUP9=OavRjSS_fz51MgW+w@mail.gmail.com>
References: 
 <CAG7mmozpAhowsCTTs1nCqxJ=VCGS42-v=py-Ev-pXoSCFzSOMg@mail.gmail.com>
 <CA+OCxozmX2ZVYG9ors8XVisMMvf1uf4FL8Rx=ATuCiJv9RyVFQ@mail.gmail.com>
 <CAG7mmow884db7H85tx8myz76Jr6HyZLfhJwNTSWmHEFzEcCPpg@mail.gmail.com>
 <CA+OCxox1dkmj2j3WZXZM7ktQnVpyH_M1cULoG+nL-z=JxqowNA@mail.gmail.com>
 <CAG7mmozCem=oAs-fa8HJF=FTUb0aSUP9=OavRjSS_fz51MgW+w@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Thu, 22 Sep 2016 15:57:49 +0100
Message-ID: 
 <CA+OCxowCbSc3GtRtnCjeweVTmDZAdzK6DX8g30iL=LcDq2ayOg@mail.gmail.com>
Subject: Re: PATCH: pgAgent support
To: Ashesh Vashi <ashesh.vashi@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: text/plain; charset=UTF-8
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

Thanks. From the pgAgent patch:

- The date/time format is different again. Should be locale or ISO
(consistent across the app)

- I think we need to add hints under the less obvious options - e.g.
Job class and host agent

- On the job step subnode control, lets move the Script to it's own
tab (called Code). We should alter the label based on the Kind option
- either "SQL query" or "Script"

- Why can't we use the Date/time picker for Exceptions? I assume we
just need to either disable Date or Time selection?

- The SQL tab doesn't use the available space. See screenshot.

- The SQL should have blank lines between sections, e.g. before --
Steps and -- Schedules


On Thu, Sep 22, 2016 at 3:49 PM, Ashesh Vashi
<ashesh.vashi@enterprisedb.com> wrote:
> Will look at them.
>
>
> On Sep 22, 2016 20:08, "Dave Page" <dpage@pgadmin.org> wrote:
>>
>> Hmm - that was clearly hiding from me. I'll take a look now.
>>
>> Did you see the rest of my comments?
>>
>> On Thu, Sep 22, 2016 at 3:37 PM, Ashesh Vashi
>> <ashesh.vashi@enterprisedb.com> wrote:
>> > I sent an updated patch immediately.
>> >
>> >
>> > On Sep 22, 2016 20:01, "Dave Page" <dpage@pgadmin.org> wrote:
>> >>
>> >> Hi
>> >>
>> >> On Thu, Sep 22, 2016 at 11:47 AM, Ashesh Vashi
>> >> <ashesh.vashi@enterprisedb.com> wrote:
>> >>>
>> >>> Hi Dave,
>> >>>
>> >>> Please find the patch for support for paAgent in pgAdmin 4.
>> >>
>> >>
>> >> Did you forget the binary switch?
>> >>
>> >> piranha:web dpage$ git apply --binary ~/Downloads/pgagent_v2.patch
>> >> error: cannot apply binary patch to
>> >>
>> >> 'web/pgadmin/browser/server_groups/servers/pgAgent/schedules/static/img/coll-pga_schedule.png'
>> >> without full index line
>> >> error:
>> >>
>> >> web/pgadmin/browser/server_groups/servers/pgAgent/schedules/static/img/coll-pga_schedule.png:
>> >> patch does not apply
>> >> error: cannot apply binary patch to
>> >>
>> >> 'web/pgadmin/browser/server_groups/servers/pgAgent/schedules/static/img/pga_schedule.png'
>> >> without full index line
>> >> error:
>> >>
>> >> web/pgadmin/browser/server_groups/servers/pgAgent/schedules/static/img/pga_schedule.png:
>> >> patch does not apply
>> >> error: cannot apply binary patch to
>> >>
>> >> 'web/pgadmin/browser/server_groups/servers/pgAgent/static/img/coll-pga_job.png'
>> >> without full index line
>> >> error:
>> >>
>> >> web/pgadmin/browser/server_groups/servers/pgAgent/static/img/coll-pga_job.png:
>> >> patch does not apply
>> >> error: cannot apply binary patch to
>> >>
>> >> 'web/pgadmin/browser/server_groups/servers/pgAgent/static/img/pga_job-disabled.png'
>> >> without full index line
>> >> error:
>> >>
>> >> web/pgadmin/browser/server_groups/servers/pgAgent/static/img/pga_job-disabled.png:
>> >> patch does not apply
>> >> error: cannot apply binary patch to
>> >>
>> >> 'web/pgadmin/browser/server_groups/servers/pgAgent/static/img/pga_job.png'
>> >> without full index line
>> >> error:
>> >>
>> >> web/pgadmin/browser/server_groups/servers/pgAgent/static/img/pga_job.png:
>> >> patch does not apply
>> >> error: cannot apply binary patch to
>> >>
>> >> 'web/pgadmin/browser/server_groups/servers/pgAgent/steps/static/img/coll-pga_jobstep.png'
>> >> without full index line
>> >> error:
>> >>
>> >> web/pgadmin/browser/server_groups/servers/pgAgent/steps/static/img/coll-pga_jobstep.png:
>> >> patch does not apply
>> >> error: cannot apply binary patch to
>> >>
>> >> 'web/pgadmin/browser/server_groups/servers/pgAgent/steps/static/img/pga_jobstep.png'
>> >> without full index line
>> >> error:
>> >>
>> >> web/pgadmin/browser/server_groups/servers/pgAgent/steps/static/img/pga_jobstep.png:
>> >> patch does not apply
>> >>>
>> >>>
>> >>> I have also attached another patch for miscellaneous fixes, and adding
>> >>> new controls.
>> >>> It includes:
>> >>> - Added DatetimepickerControl, MomentCell (using moment.js)
>> >>> - Used the 'DatetimepickerControl' in Role (Also - resolved an issue,
>> >>> when unset the datetime for 'Valid Until'.)
>> >>> - Added a 'Select All/Unselect All' adaptor for Select2 used by
>> >>> pgAgent
>> >>> nodes.
>> >>> - Fixed an issue with SubNodeCollectionControl, which was not starting
>> >>> the modification session of the child model, when created default
>> >>> value for
>> >>> collection is not null/undefined. And, hence - validation on the child
>> >>> model
>> >>> was not working.
>> >>> - Fixed a memory leak with SqlFieldControl, and SqlTabControl, which
>> >>> was
>> >>> not releasing the CodeMirror properly.
>> >>
>> >>
>> >> Urgh, that's big. Applied - but can you look at the following please?
>> >>
>> >> - Account expires has a hint of 'MMM D YYYY HH:mm:ss.SSS Z". Are
>> >> milliseconds really needed? I also get 00 as a fractional timezone
>> >> offset.
>> >> Perhaps we should hide that, when it's 00?
>> >>
>> >> - The date format differs from the ISO format displayed by the query
>> >> tool.
>> >> They should be consistent - and really should be either based on the
>> >> client's locale settings, or ISO format.
>> >>
>> >> Thanks.
>> >>
>> >> --
>> >> Dave Page
>> >> Blog: http://pgsnake.blogspot.com
>> >> Twitter: @pgsnake
>> >>
>> >> EnterpriseDB UK: http://www.enterprisedb.com
>> >> The Enterprise PostgreSQL Company
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers