Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fSOrF-0001ra-IT for pgadmin-hackers@arkaria.postgresql.org; Mon, 11 Jun 2018 15:35:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fSOrE-0007wV-CV for pgadmin-hackers@arkaria.postgresql.org; Mon, 11 Jun 2018 15:35:48 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fSOrD-0007wL-OA for pgadmin-hackers@lists.postgresql.org; Mon, 11 Jun 2018 15:35:48 +0000 Received: from mail-wm0-x22f.google.com ([2a00:1450:400c:c09::22f]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fSOr5-0004qF-2K for pgadmin-hackers@postgresql.org; Mon, 11 Jun 2018 15:35:45 +0000 Received: by mail-wm0-x22f.google.com with SMTP id p11-v6so17384710wmc.4 for ; Mon, 11 Jun 2018 08:35:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=rGgWdVHeW6FjV+l7HSRu4Y0lPjkXPeF/0eg4p3J05uE=; b=GVFqW06IYyFOBftniqAx2GgpY8I43lSzntD2QdO1t6B2fnYPC7KQWUKCudZZzjIRDq xy7D6CcceoOZUAEqhIhxeCwEEH5hPjOivcBxNPi/sJgyovVAyEjz8Fbe9sIaIPtd5ZYM r5OW7hqg0JYSncdmSSZDhRCuSkJQnEwqdS4UlTfP5d+F1XSHvIzgHo1FlUqDzH8WNcGj XuEkM6skd72Nm8/yPi98khQnJ/nHChKFfY6cNQB9D/y/NCCziiPwwAYmqLNiSKE4lwW6 U1PB4PPqCZobVkS+jE7Mnks3TnomOcZPrIhKekqmuSMxRvmb4REmSC5MPtFb9z+4Z689 vyEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=rGgWdVHeW6FjV+l7HSRu4Y0lPjkXPeF/0eg4p3J05uE=; b=FuO+WLmhmvRoaWJ8wKuOFsJKXNJkq/3c0DDIBkmAfe1AQzqp9Hp466CYWouxar8i9N wXLpnHM/3osGqadHVynDVvHMFJn7vWcEQ60ojUAF77GFKa8cJPHc1Tv++wJcO1u0aNsW bAJ58IBCy49aOjwRkYbh5r4h4y8pi1V4XCLptjhQFm5PCjPlOnMy29VLhOas8N/oUjnV GBq3aZZeJd0t7NufSwdWkZCJwaBdDwqeYQFymNmto1/Ez/F4HOVBLts51bxc/DfA5rWv qpXp6yDF+iSngpsD7niQiEPdYJtMcQLVywBlc1WpXGYGbBDcynarNQ+QjYKMZ66DDM4A 0HIA== X-Gm-Message-State: APt69E2jlEzdFpLXbgXuNoMbTUEqDneJlxkye+IhxWZWTQCpczPPm08v czCGn/CoeOm9DBVQ/N7uWFu5vuKgCf9jc+bpWEug6w== X-Google-Smtp-Source: ADUXVKJrrcqzOrnSRAsgdtNwTwNlKUJm8HwCTCe8+fGkg8knp+cyqLcK0Pqj+HpU3XoPBXFdYg/E6c9HEt23TCpZ1DQ= X-Received: by 2002:a1c:b7d4:: with SMTP id h203-v6mr8223803wmf.161.1528731337239; Mon, 11 Jun 2018 08:35:37 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a1c:2907:0:0:0:0:0 with HTTP; Mon, 11 Jun 2018 08:35:36 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Mon, 11 Jun 2018 16:35:36 +0100 Message-ID: Subject: Re: [pgadmin][patch] Electron version 4.X To: Victoria Henry Cc: Joao De Almeida Pereira , pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000050448f056e5f801a" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000050448f056e5f801a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi On Fri, Jun 8, 2018 at 3:49 PM, Victoria Henry wrote: > > > On Tue, Jun 5, 2018 at 12:28 PM Dave Page wrote: > >> Hi >> >> On Mon, Jun 4, 2018 at 10:27 PM, Joao De Almeida Pereira < >> jdealmeidapereira@pivotal.io> wrote: >> >>> Hi Hackers, >>> >>> Attached you can find the patch that introduces electron to our code >>> base. >>> >> Cool. FYI, I'd like to get this into rough shape and then push it to a >> dev branch for fine-tuning. I think it'll be easier to work that way. >> > Sure, you can create a dev branch and push this patch to it. > > Great. So here's my initial feedback: >> >> - The Mac build you provided doesn't work for me. It hangs on the loadin= g >> screen. >> > Could we get some more information about the machine? Using the python > from the venv directory, are you able to run the app directly? > > cd /Applications/pgAdmin.app/Contents/Resources/app/ > venv/bin/python web/pgAdmin4.py > > =E2=80=8B > Do you get and error? > We are setting PGADMIN_PORT, PGADMIN_KEY and SERVER_MODE environment > variables prior to starting it. > Yes, I get: piranha:app dpage$ venv/bin/python web/pgAdmin4.py Could not find platform independent libraries Could not find platform dependent libraries Consider setting $PYTHONHOME to [:] Fatal Python error: Py_Initialize: unable to load the file system codec ModuleNotFoundError: No module named 'encodings' Current thread 0x00007fffe86993c0 (most recent call first): Abort trap: 6 > > >> >> > - A number of the changes are related to the naming of requirejs. I'd be >> inclined to pull that out into a separate patch and get it committed to >> master ASAP. >> > This change only makes sense in the Electron context. Neverthless fell > free to add it to master if you think it is relevant. > > >> - I think the build instructions need to be more generic (particularly o= n >> macOS). For example, I do not use HomeBrew (largely due to some nasty >> security issues they had in the past). I was able to mostly port the >> instructions and build script over to work using MacPorts (without PyEnv= ) >> which actually turned out to be somewhat more simple than what's there n= ow. >> > Since we don't use MacPorts, we cannot provide installation instructions. > I wasn't asking you to provide MacPort instructions; I can do that. I was saying that the basic outline of the instructions should be agnostic to the package tools the user might choose; e.g. - Install python - Create a virtual environment using the --copies option called venv - Move the virtual environment to ... We can then include examples of how to do that with brew, macports etc. > > >> - I'm not sure what this is intended to do: "git checkout electron". >> Clearly that isn't correct. >> > That was the name of our development branch. It can be removed. > OK. > > >> >> - All new builds should be using Python 3.6. We need to deprecate 2.7 as >> there are some Unicode related issues that cannot be fixed in it. >> > For Windows, we are using 2.7 because of external library compilation > issues. Let us know if you are able to get around this or how to make > this work. > There are a couple of tricks if you're using Python 3.6. First, to compile Pycrypto you need to do something like: - set VCINSTALLDIR=3DC:\Program Files (x86)\Microsoft Visual Studio 14.0= \VC - set CL=3D-FI"%VCINSTALLDIR%\INCLUDE\stdint.h" - (https://stackoverflow.com/questions/41843266/ microsoft-windows-python-3-6-pycrypto-installation-error ) Beforehand. Then, edit Lib\site-packages\Crypto\Random\OSRNG\nt.py" and modify " *import winrandom*" to "*from . import winrandom*". As a sidenote, I use the VC++ 2015 Build Tools compiler from Microsoft, without installing any SDKs or Visual Studio. > > >> - I would like to see the new build code adapted to follow the existing >> conventions as much as reasonable, to avoid having to change build syste= ms >> or other processes/procedures that folks use. For example, build scripts >> should be under pkg/, completed packages left in dist/, build staging do= ne >> in xxx-build directories rather than elsewhere. >> > That sounds reasonable. > > >> - It may be a result of my use of MacPorts, but I'm getting the followin= g >> failure building: >> > >> yarn run v1.3.2 >> $ electron-forge make --platfrom=3Ddarwin --arch=3Dx64 --targets=3Ddmg >> =E2=9C=94 Checking your system >> =E2=9C=94 Resolving Forge Config >> We need to package your application before we can make it >> =E2=9C=94 Preparing to Package Application for arch: x64 >> =E2=A0=BC Compiling ApplicationFailed to compile file: >> /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron- >> packager/darwin-x64/pgAdmin-darwin-x64/Electron.app/ >> Contents/Resources/app/venv/lib/python3.6/site-packages/setuptools/comma= nd/launcher >> manifest.xml >> Compiling /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron- >> packager/darwin-x64/pgAdmin-darwin-x64/Electron.app/ >> Contents/Resources/app/venv/lib/python3.6/site-packages/setuptools/comma= nd/launcher >> manifest.xml resulted in a MIME type of application/xml, which we don't >> know how to handle >> =E2=A0=8B Compiling ApplicationFailed to compile file: >> /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron- >> packager/darwin-x64/pgAdmin-darwin-x64/Electron.app/ >> Contents/Resources/app/web/pgadmin/browser/server_groups/ >> servers/templates/servers/supported_servers.js >> /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron- >> packager/darwin-x64/pgAdmin-darwin-x64/Electron.app/ >> Contents/Resources/app/web/pgadmin/browser/server_groups/ >> servers/templates/servers/supported_servers.js: Unexpected token (6:7) >> =E2=A0=A6 Compiling ApplicationFailed to compile file: >> /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron- >> packager/darwin-x64/pgAdmin-darwin-x64/Electron.app/ >> Contents/Resources/app/web/pgadmin/browser/templates/ >> browser/js/endpoints.js >> /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron- >> packager/darwin-x64/pgAdmin-darwin-x64/Electron.app/ >> Contents/Resources/app/web/pgadmin/browser/templates/browser/js/endpoint= s.js: >> Unexpected token (5:6) >> Failed to compile file: /var/folders/c6/pwf0k2d509s2xx >> 6vh0h633vm0000gn/T/electron-packager/darwin-x64/pgAdmin- >> darwin-x64/Electron.app/Contents/Resources/app/web/ >> pgadmin/browser/templates/browser/js/messages.js >> /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron- >> packager/darwin-x64/pgAdmin-darwin-x64/Electron.app/ >> Contents/Resources/app/web/pgadmin/browser/templates/browser/js/messages= .js: >> Unexpected token (37:1) >> Failed to compile file: /var/folders/c6/pwf0k2d509s2xx >> 6vh0h633vm0000gn/T/electron-packager/darwin-x64/pgAdmin- >> darwin-x64/Electron.app/Contents/Resources/app/web/ >> pgadmin/browser/templates/browser/js/utils.js >> /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron- >> packager/darwin-x64/pgAdmin-darwin-x64/Electron.app/ >> Contents/Resources/app/web/pgadmin/browser/templates/browser/js/utils.js= : >> Unexpected token (28:23) >> =E2=A0=8B Compiling ApplicationFailed to compile file: >> /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron- >> packager/darwin-x64/pgAdmin-darwin-x64/Electron.app/ >> Contents/Resources/app/web/pgadmin/misc/file_manager/ >> templates/file_manager/js/languages/en.js >> /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron- >> packager/darwin-x64/pgAdmin-darwin-x64/Electron.app/ >> Contents/Resources/app/web/pgadmin/misc/file_manager/ >> templates/file_manager/js/languages/en.js: Unexpected token, expected ; >> (2:29) >> =E2=A0=8B Compiling ApplicationFailed to compile file: >> /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron- >> packager/darwin-x64/pgAdmin-darwin-x64/Electron.app/ >> Contents/Resources/app/web/pgadmin/static/scss/_alert.scss >> Error: Undefined variable: "$color-green-3". >> on line 29 of /stdin >> >> background: $color-green-3; >> >> --------------^ >> >> =E2=A0=99 Compiling ApplicationFailed to compile file: >> /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron- >> packager/darwin-x64/pgAdmin-darwin-x64/Electron.app/ >> Contents/Resources/app/web/pgadmin/static/scss/_alertify.overrides.scss >> Error: ".ajs-message.ajs-error.ajs-visible" failed to @extend >> ".bg-red-1". >> The selector ".bg-red-1" was not found. >> Use "@extend .bg-red-1 !optional" if the extend should be able to >> fail. >> on line 164 of /stdin >> >> @extend .bg-red-1; >> >> ----------^ >> >> =E2=A0=B4 Compiling ApplicationFailed to compile file: >> /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron- >> packager/darwin-x64/pgAdmin-darwin-x64/Electron.app/ >> Contents/Resources/app/web/pgadmin/static/scss/sqleditor/_history.scss >> Error: Undefined variable: "$color-gray-3". >> on line 4 of /stdin >> >> border-bottom: 1px solid $color-gray-3; >> >> -----------------------------^ >> > We were also seeing these errors but they don't have any impact on the > compilation and should be addressed in the future (not in this patch) > > >> >> =E2=A0=87 Compiling ApplicationFailed to compile file: >> /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron- >> packager/darwin-x64/pgAdmin-darwin-x64/Electron.app/ >> Contents/Resources/app/web/pgadmin/templates/base.html >> /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron- >> packager/darwin-x64/pgAdmin-darwin-x64/Electron.app/ >> Contents/Resources/app/web/pgadmin/templates/base.html:inline_1.js: >> Unexpected token (2:13) >> =E2=A0=B4 Compiling ApplicationFailed to compile file: >> /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron- >> packager/darwin-x64/pgAdmin-darwin-x64/Electron.app/ >> Contents/Resources/app/web/pgadmin/tools/templates/js/translations.js >> /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron- >> packager/darwin-x64/pgAdmin-darwin-x64/Electron.app/ >> Contents/Resources/app/web/pgadmin/tools/templates/js/translations.js: >> Unexpected token (2:10) >> =E2=A0=A6 Compiling ApplicationFailed to compile file: >> /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron- >> packager/darwin-x64/pgAdmin-darwin-x64/Electron.app/ >> Contents/Resources/app/web/pgadmin/tools/user_management/ >> templates/user_management/js/current_user.js >> /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron- >> packager/darwin-x64/pgAdmin-darwin-x64/Electron.app/ >> Contents/Resources/app/web/pgadmin/tools/user_management/ >> templates/user_management/js/current_user.js: Unexpected token (3:15) >> =E2=9C=94 Compiling Application >> =E2=9C=94 Preparing native dependencies >> =E2=9C=94 Packaging Application >> Making for the following targets: >> =E2=A0=8B Making for target: dmg - On platform: darwin - For arch: x64 >> An unhandled exception has occurred inside Forge: >> Cannot find module 'macos-alias' >> Error: Cannot find module 'macos-alias' >> > This may be related to using MacPorts or the way you installed the > dependencies. There was a bug with Electron and Node 10 so we had to use > to Node 8 with Yarn. > I'm using Node 8 as well. Let's figure out your build first and ensure we can get that working everywhere, then I'll try to figure out how to reproduce it. --=20 Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --00000000000050448f056e5f801a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

On Fri, Jun 8, 2018 at 3:49 PM, Victoria Henry <= vhenry@pivotal.io> wrote:

=
Hi

On Mon, Jun 4, 2018 at 10:27 PM, Joao De Almeida Pe= reira <jdealmeidapereira@pivotal.io> wrote:
Hi Hackers,

Attached you can find the patch that intr= oduces electron to our code base.

Cool. FY= I, I'd like to get this into rough shape and then push it to a dev bran= ch for fine-tuning. I think it'll be easier to work that way.
Sure, you can create a dev branch an= d push this patch to it.

Great. So here's my initial feedback:
<= div>
- The Mac build you provided doesn't work for me. It= hangs on the loading screen.
Could we get some more information about the machine?=C2=A0 Using the py= thon from the venv directory, are you able to run the app directly?=C2=A0
<=
code style=3D"font-size:0.85em;font-family:Consolas,Inconsolata,Courier,mon=
ospace;margin:0px 0.15em;padding:0px 0.3em;white-space:pre-wrap;border:1px =
solid rgb(234,234,234);background-color:rgb(248,248,248);border-radius:3px;=
display:inline;white-space:pre-wrap;overflow:auto;border-radius:3px;border:=
1px solid rgb(204,204,204);padding:0.5em 0.7em;display:block!important">cd =
/Applications/pgAdmin.app/Contents/Resources/app/=20
venv/bin/python web/pgAdmin4.py
=E2=80= =8B
Do you get and error?
We are setti= ng PGADMIN_PORT, PGADMIN_KEY and SERVER_MODE environment variables prior to= starting it.

Yes, I get:=

piranha:app dpage$ venv/bin= /python web/pgAdmin4.py

Could not find platform ind= ependent libraries <prefix>

Could not find platform dep= endent libraries <exec_prefix>

Consider setting $PYTHONHOM= E to <prefix>[:<exec_prefix>]

Fatal Python error: Py_Init= ialize: unable to load the file system codec

ModuleNotFoundError: No mod= ule named 'encodings'


=

Current thread 0x00007fffe8= 6993c0 (most recent call first):

Abort trap: 6



=C2=A0
=C2=A0
=C2=A0
- A = number of the changes are related to the naming of requirejs. I'd be in= clined to pull that out into a separate patch and get it committed to maste= r ASAP.
This change only ma= kes sense in the Electron context. Neverthless fell free to add it to maste= r if you think it is relevant.


- I think the build instru= ctions need to be more generic (particularly on macOS). For example, I do n= ot use HomeBrew (largely due to some nasty security issues they had in the = past). I was able to mostly port the instructions and build script over to = work using MacPorts (without PyEnv) which actually turned out to be somewha= t more simple than what's there now.
Since we don't use MacPorts, we cannot provide instal= lation instructions.

I wa= sn't asking you to provide MacPort instructions; I can do that. I was s= aying that the basic outline of the instructions should be agnostic to the = package tools the user might choose; e.g.

- Instal= l python
- Create a virtual environment using the --copies option= called venv
- Move the virtual environment to ...

=
We can then include examples of how to do that with brew, macpor= ts etc.
=C2=A0


- I'm not sure wha= t this is intended to do: "git checkout electron". Clearly that i= sn't correct.
That was = the name of our development branch.=C2=A0 It can be removed.

OK.
=C2=A0
= =C2=A0

- All new builds should be using Python 3.6. We need to deprecate 2.7 as= there are some Unicode related issues that cannot be fixed in it.
For Windows, we are using 2.7 becau= se of external library compilation issues.=C2=A0 =C2=A0Let us know if you a= re able to get around this or how to make this work.

There are a couple of tricks if you're usin= g Python 3.6. First, to compile Pycrypto you need to do something like:


=C2=A0
- I would like to see the new build code adapted to follow t= he existing conventions as much as reasonable, to avoid having to change bu= ild systems or other processes/procedures that folks use. For example, buil= d scripts should be under pkg/, completed packages left in dist/, build sta= ging done in xxx-build directories rather than elsewhere.
=
That sounds reasonable.
=C2=A0
- It = may be a result of my use of MacPorts, but I'm getting the following fa= ilure building:=C2=A0

yarn run v1.3.2
$ electron-forge make --plat= from=3Ddarwin --arch=3Dx64 --targets=3Ddmg
=E2=9C=94 Checking you= r system
=E2=9C=94 Resolving Forge Config
We need to pa= ckage your application before we can make it
=E2=9C=94 Preparing = to Package Application for arch: x64
=E2=A0=BC Compiling Applicat= ionFailed to compile file: /var/folders/c6/pwf0k2d509s2xx6vh0h633vm000= 0gn/T/electron-packager/darwin-x64/pgAdmin-darwin-x64/Electron.ap= p/Contents/Resources/app/venv/lib/python3.6/site-packages/se= tuptools/command/launcher manifest.xml
Compiling /var/folders/c6/= pwf0k2d509s2xx6vh0h633vm0000gn/T/electron-packager/darwin-x64/pgA= dmin-darwin-x64/Electron.app/Contents/Resources/app/venv/lib= /python3.6/site-packages/setuptools/command/launcher manifest.xml resu= lted in a MIME type of application/xml, which we don't know how to hand= le
=E2=A0=8B Compiling ApplicationFailed to compile file: /var/fo= lders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron-packager/darwi= n-x64/pgAdmin-darwin-x64/Electron.app/Contents/Resources/app/web/= pgadmin/browser/server_groups/servers/templates/servers/supp= orted_servers.js
/var/folders/c6/pwf0k2d509s2xx6vh0h633vm000= 0gn/T/electron-packager/darwin-x64/pgAdmin-darwin-x64/Electron.ap= p/Contents/Resources/app/web/pgadmin/browser/server_groups/s= ervers/templates/servers/supported_servers.js: Unexpected token (6:7)<= /div>
=E2=A0=A6 Compiling ApplicationFailed to compile file: /var/folde= rs/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron-packager/darwin-x= 64/pgAdmin-darwin-x64/Electron.app/Contents/Resources/app/web/pgadmin/browser/templates/browser/js/endpoints.js
/var/fol= ders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron-packager/darwin= -x64/pgAdmin-darwin-x64/Electron.app/Contents/Resources/app/web/<= wbr>pgadmin/browser/templates/browser/js/endpoints.js: Unexpected toke= n (5:6)
Failed to compile file: /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron-packager/darwin-x64/pgAdmin-darwin-= x64/Electron.app/Contents/Resources/app/web/pgadmin/browser/templ= ates/browser/js/messages.js
/var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron-packager/darwin-x64/pgAdmin-darwin= -x64/Electron.app/Contents/Resources/app/web/pgadmin/browser/temp= lates/browser/js/messages.js: Unexpected token (37:1)
Failed= to compile file: /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/ele= ctron-packager/darwin-x64/pgAdmin-darwin-x64/Electron.app/Co= ntents/Resources/app/web/pgadmin/browser/templates/browser/js/uti= ls.js
/var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/elect= ron-packager/darwin-x64/pgAdmin-darwin-x64/Electron.app/Cont= ents/Resources/app/web/pgadmin/browser/templates/browser/js/utils= .js: Unexpected token (28:23)
=E2=A0=8B Compiling ApplicationFail= ed to compile file: /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/e= lectron-packager/darwin-x64/pgAdmin-darwin-x64/Electron.app/= Contents/Resources/app/web/pgadmin/misc/file_manager/templates/fi= le_manager/js/languages/en.js
/var/folders/c6/pwf0k2d509s2xx= 6vh0h633vm0000gn/T/electron-packager/darwin-x64/pgAdmin-darw= in-x64/Electron.app/Contents/Resources/app/web/pgadmin/misc/file_= manager/templates/file_manager/js/languages/en.js: Unexpected tok= en, expected ; (2:29)
=E2=A0=8B Compiling ApplicationFailed to co= mpile file: /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron-= packager/darwin-x64/pgAdmin-darwin-x64/Electron.app/Contents= /Resources/app/web/pgadmin/static/scss/_alert.scss
Erro= r: Undefined variable: "$color-green-3".
=C2=A0 =C2=A0 = =C2=A0 =C2=A0 on line 29 of /stdin
>>=C2=A0 =C2=A0backgroun= d: $color-green-3;

=C2=A0 =C2=A0--------------^

=E2=A0=99 Compiling ApplicationFailed to compile fil= e: /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron-pack= ager/darwin-x64/pgAdmin-darwin-x64/Electron.app/Contents/Resource= s/app/web/pgadmin/static/scss/_alertify.overrides.scss
= Error: ".ajs-message.ajs-error.ajs-visible" failed to @exten= d ".bg-red-1".
=C2=A0 =C2=A0 =C2=A0 =C2=A0The selector = ".bg-red-1" was not found.
=C2=A0 =C2=A0 =C2=A0 =C2=A0U= se "@extend .bg-red-1 !optional" if the extend should be able to = fail.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 on line 164 of /stdin
>>=C2=A0 =C2=A0@extend .bg-red-1;

=C2=A0 = =C2=A0----------^

=E2=A0=B4 Compiling ApplicationF= ailed to compile file: /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/= T/electron-packager/darwin-x64/pgAdmin-darwin-x64/Electron.app/Contents/Resources/app/web/pgadmin/static/scss/sqleditor/_hist= ory.scss
Error: Undefined variable: "$color-gray-3".
=C2=A0 =C2=A0 =C2=A0 =C2=A0 on line 4 of /stdin
>>= =C2=A0 =C2=A0 =C2=A0border-bottom: 1px solid $color-gray-3;

<= /div>
=C2=A0 =C2=A0-----------------------------^
We were also seeing these errors but t= hey don't have any impact on the compilation and should be addressed in= the future (not in this patch)
=C2=A0

=E2=A0=87 Compiling ApplicationFailed to compi= le file: /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron-packager/darwin-x64/pgAdmin-darwin-x64/Electron.app/Contents/Re= sources/app/web/pgadmin/templates/base.html
/var/folders/c6/= pwf0k2d509s2xx6vh0h633vm0000gn/T/electron-packager/darwin-x64/pgA= dmin-darwin-x64/Electron.app/Contents/Resources/app/web/pgad= min/templates/base.html:inline_1.js: Unexpected token (2:13)
=E2=A0=B4 Compiling ApplicationFailed to compile file: /var/folders/c6/pwf= 0k2d509s2xx6vh0h633vm0000gn/T/electron-packager/darwin-x64/pgAdmi= n-darwin-x64/Electron.app/Contents/Resources/app/web/pgadmin= /tools/templates/js/translations.js
/var/folders/c6/pwf0k2d5= 09s2xx6vh0h633vm0000gn/T/electron-packager/darwin-x64/pgAdmin-darwin-x64/Electron.app/Contents/Resources/app/web/pgadmin/tool= s/templates/js/translations.js: Unexpected token (2:10)
=E2= =A0=A6 Compiling ApplicationFailed to compile file: /var/folders/c6/pwf0k2d= 509s2xx6vh0h633vm0000gn/T/electron-packager/darwin-x64/pgAdmin-darwin-x64/Electron.app/Contents/Resources/app/web/pgadmin/too= ls/user_management/templates/user_management/js/current_user.js
/var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron-packager/darwin-x64/pgAdmin-darwin-x64/Electron.app/Contents/Re= sources/app/web/pgadmin/tools/user_management/templates/user_mana= gement/js/current_user.js: Unexpected token (3:15)
=E2=9C=94= Compiling Application
=E2=9C=94 Preparing native dependencies
=E2=9C=94 Packaging Application
Making for the following = targets:
=E2=A0=8B Making for target: dmg - On platform: darwin -= For arch: x64
An unhandled exception has occurred inside Forge:<= /div>
Cannot find module 'macos-alias'
Error: Cannot = find module 'macos-alias'
This may be related to using MacPorts or the way you installed the d= ependencies.=C2=A0 There was a bug with Electron and Node 10 so we had to u= se to Node 8 with Yarn.


--
D= ave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB U= K: http://www.ent= erprisedb.com
The Enterprise PostgreSQL Company
--00000000000050448f056e5f801a--