public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Surinder Kumar <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][Patch] - Disable PrivilegeControl for nodes visible under catalog
Date: Thu, 7 Apr 2016 11:23:28 +0100
Message-ID: <CA+OCxowE1CAm-ReDu4d2h1uXUNvqopMDB_=pKqkRDYH=YgfqJQ@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxozu55OFo13kr_3K4DbCbGMCQ-NapvuX+zuFWNx08j0E=g@mail.gmail.com>
References: <CAM5-9D98_=ZS2K42VGqH69GiZ+ozv0Yu8vkQK3rzeZ-0LFGpNw@mail.gmail.com>
<CA+OCxozu55OFo13kr_3K4DbCbGMCQ-NapvuX+zuFWNx08j0E=g@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
This time, with the screenshot...
On Thu, Apr 7, 2016 at 11:14 AM, Dave Page <[email protected]> wrote:
> Hi
>
> On Thu, Apr 7, 2016 at 8:45 AM, Surinder Kumar
> <[email protected]> wrote:
>> Hi,
>>
>> PFA minor patch for PrivilegeRoleModel
>>
>> Change: Add check to disable PrivilegeRoleModel fields for nodes visible
>> under catalog.
>>
>> Please review the patch.
>
> I'm unclear what this is supposed to do:
>
> - Those fields already seem to be disabled under catalog nodes (though
> - the Add button on subnode grids is still active, but doesn't do
> anything)
>
> - Shouldn't we just hide privilege info on those nodes directly? Why
> break modularity for this?
>
> - I'm seeing weird effects after applying this patch - see the
> attached screenshot. However, that issue remains even after I remove
> it again (and restart the server, and hard-reload). It does seem to
> fix itself eventually, but I'm not sure what causes that. If I try to
> refresh the Functions node, I get:
>
> jquery.contextMenu.js:309 No items specified to show in
> contextMenuhandle.contextmenu @
> jquery.contextMenu.js:309jQuery.event.dispatch @
> jquery-1.11.2.js:4665elemData.handle @ jquery-1.11.2.js:4333
> jquery.contextMenu.js:312 Uncaught Error: No Items
> specifiedhandle.contextmenu @
> jquery.contextMenu.js:312jQuery.event.dispatch @
> jquery-1.11.2.js:4665elemData.handle @ jquery-1.11.2.js:4333
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Attachments:
[image/png] Screen Shot 2016-04-07 at 11.08.04.png (59.4K, 2-Screen%20Shot%202016-04-07%20at%2011.08.04.png)
download | view image
view thread (5+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgAdmin4][Patch] - Disable PrivilegeControl for nodes visible under catalog
In-Reply-To: <CA+OCxowE1CAm-ReDu4d2h1uXUNvqopMDB_=pKqkRDYH=YgfqJQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox