Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hppjr-0006d9-NL for pgadmin-hackers@arkaria.postgresql.org; Tue, 23 Jul 2019 08:01:36 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hppjp-00044E-4X for pgadmin-hackers@arkaria.postgresql.org; Tue, 23 Jul 2019 08:01:33 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hppjo-000447-Tj for pgadmin-hackers@lists.postgresql.org; Tue, 23 Jul 2019 08:01:32 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hppji-0001sA-0q for pgadmin-hackers@postgresql.org; Tue, 23 Jul 2019 08:01:32 +0000 Received: by mail-wm1-x342.google.com with SMTP id v15so37549681wml.0 for ; Tue, 23 Jul 2019 01:01:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EfW8ENE0/OsufxhbzqJiUSgxYkBD8/ucj9B3OCw5szE=; b=n5LBAo00jCKzkZbQ2ZcoNduDdaJEIhgixwYFr9avNbQErR8xa7u65jr1ZfABNhp67W 752QQQyk0/tqt/r6Mmitj/zZMPCeSoOcLpX6Dt+NDfsFHszdCPKGQHU22xJHSctKzxUc 8rYTDTQK6jJhQOI8R8xJ0J3r1tlTy++OA9YAmxZioHTKDXiNlwxM2RLs70a/gOFmTvYo 5u7gdpptvCRBDxVt6oWzHEYZksfeLjxR5ypRX1khib9k1/Y2DxCv80HKzu0HNtxSeOQY gyi5fZQNz1qxKnB1KwEnsxzFilD5Fw1l3vQ7xNcUP2xqs3/VbNqZhlyzR74unvVeLOI9 1KHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EfW8ENE0/OsufxhbzqJiUSgxYkBD8/ucj9B3OCw5szE=; b=pLqP0upe8JpulNrgQaA1XvS963bd4qkvcjowPLigXhfhzbXnyUUkHqTYlz8wxnrUh/ A6FDRkiIq0UD8hJ/rv3OrBmuyqTCEMLCCH5Xqg2kKKRUNm9LWqcgWzPtozi3vcWsjcF4 zPswqj0LO5zlG22D781aOcnVLCmAkOAWA990q67G5qcBgMvpbMLwHkr3+L0m6ggSXcVj vLtFmUYvDkEW4Vl2xa86NYTG37xdF2Pbvqxvm8KwzeXWiCp4FMFXxkC9lcy4+ywceyE4 Nn6W9Kiq6gppsvuOyO7YHTd1v9yVdKhWA8mG9dDj6/fIiOfQIyNdZvruOn2TZbHKoN8W T/ag== X-Gm-Message-State: APjAAAX3gFjwSqO4/wr4B1f7Nc9yIdQ4aVbEqyrtwNAkRbY0kkWhr6Qv WRTdvJ6wZRAZNgQj+acJUotZWAmG4lnUx9HeVNh4mA== X-Google-Smtp-Source: APXvYqygmEIiBJsaAR0risgXOjnrIso5lE27I0OKq7ElE+vPmZoMDj9E5ygCeDRr/fncCKVDSssXRJZHlmrhKcKMyBs= X-Received: by 2002:a1c:f018:: with SMTP id a24mr65769260wmb.66.1563868885261; Tue, 23 Jul 2019 01:01:25 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Tue, 23 Jul 2019 09:01:13 +0100 Message-ID: Subject: Re: Bug in Database Nodes in the Tree To: Khushboo Vashi Cc: Yosry Muhammad , pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000061bd6c058e54991d" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000061bd6c058e54991d Content-Type: text/plain; charset="UTF-8" On Tue, Jul 23, 2019 at 4:15 AM Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > > > On Tue, Jul 23, 2019 at 2:17 AM Yosry Muhammad wrote: > >> Hi, >> >> I tried just removing the lines responsible for connecting to the >> database on selecting a database node and it seem to work fine. >> Specifically the lines 254-257 in database.js (callbacks.selected function). >> >> Are there any specific scenarios I need to test to make sure everything >> is okay? Anywhere else in the code where I need to make changes? >> >> I think all the right side panels (i.e. Properties, SQL, etc...) will be > affected. > They're populated on select. It may mean that we have to show a "Please connect to the server" message in them, if a database or server is selected but not connected. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --00000000000061bd6c058e54991d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Tue, Jul 23, 2019 at 4:15 AM Khush= boo Vashi <khushboo.v= ashi@enterprisedb.com> wrote:


On Tue, Jul 23, = 2019 at 2:17 AM Yosry Muhammad <yosrym93@gmail.com> wrote:
Hi,

<= /div>
I tried just removing the lines responsible for connecting to the= database on selecting a database node and it seem to work fine. Specifical= ly the lines 254-257 in database.js (callbacks.selected function).

Are there any specific scenarios I need to test to make su= re everything is okay? Anywhere else in the code where I need to make chang= es?

I think all the right side panels = (i.e. Properties, SQL, etc...) will be affected.=C2=A0

They're populated on select. It may mean = that we have to show a "Please connect to the server" message in = them, if a database or server is selected but not connected.
=C2= =A0
--
Dave Page<= br>Blog: http://p= gsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb= .com
The Enterprise PostgreSQL Company
--00000000000061bd6c058e54991d--