MIME-Version: 1.0
In-Reply-To: 
 <CAB_Kkxyekd22aG-Y38EDMWL1woO3v4aiiZ3T432=fjGOB89gtQ@mail.gmail.com>
References: 
 <CAB_Kkxw66uKr8B7yaurTpR_aOt-i+o+cEtvNHD4pBHtWANKsNQ@mail.gmail.com>
 <CA+OCxozUV33WchaAZX3miWG2446bQzNJQxtgc6SmmAieNBfQTA@mail.gmail.com>
 <CAB_KkxxEoQOR9qA5gfC9U27hA1J06tywfkDEcaiWmaCZSLHMQA@mail.gmail.com>
 <CA+OCxox+2hFzb-n3X8ozE-53iR80W2HYWMKTmU=xEbuLBvLrFQ@mail.gmail.com>
 <CAB_KkxytgS+rv17wgLxS5wePLL8YXXj9LqBCE4VgghfU5gQkFA@mail.gmail.com>
 <CA+OCxozb_ZPzw68zZmWNbGsNazhnQss+48n1MVkjS-xaELTXEg@mail.gmail.com>
 <CAB_Kkxyekd22aG-Y38EDMWL1woO3v4aiiZ3T432=fjGOB89gtQ@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Mon, 19 Mar 2018 11:19:59 +0000
Message-ID: 
 <CA+OCxowFXD9t=KX-2fTweGdUmZ8Q4sDKmo+Zp6N24s2Gv7MpTQ@mail.gmail.com>
Subject: Re: Proposal for changes in official Docker image
To: =?UTF-8?B?0JzQsNC60YHQuNC8INCa0L7Qu9GM0YbQvtCy?= <kolmax94@gmail.com>
Cc: pgadmin-hackers@lists.postgresql.org
Content-Type: multipart/alternative; boundary="001a1141101275b05c0567c22360"
Precedence: bulk

--001a1141101275b05c0567c22360
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi

On Fri, Mar 16, 2018 at 8:52 PM, =D0=9C=D0=B0=D0=BA=D1=81=D0=B8=D0=BC =D0=
=9A=D0=BE=D0=BB=D1=8C=D1=86=D0=BE=D0=B2 <kolmax94@gmail.com> wrote:
>
>
> I've switched to Gunicorn, adding SSL support. It has the same
> interface as the original container: PGADMIN_ENABLE_TLS,
> /certs/server.key and /certs/server.cert.
> I also incorporated building of sphinx manual in Dockerfile, so now
> the image should be complete.
>

Nice!


>
> I noticed that I can't use gunicorn forking worker with pgadmin4, this
> is probably caused by session implementation, but I'm not sure. You
> can investigate this by using e.g. `-w 4` in entrypoint.sh, otherwise
> it's working fine with single-process threaded worker.
>

This is expected, and the reason why is explained here:
https://www.pgadmin.org/docs/pgadmin4/2.x/server_deployment.html#requiremen=
ts


>
> I will make my work into a patch and send it to the mail list soon.
> Meanwhile, it'd be great if you tested the updated image at
> https://hub.docker.com/r/maksbotan/pgadmin4/


I'll try to take a look later in the week (busy prepping for a release at
the moment).

--=20
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--001a1141101275b05c0567c22360
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi<br><div class=3D"gmail_extra"><br><div class=3D"gmail_q=
uote">On Fri, Mar 16, 2018 at 8:52 PM, =D0=9C=D0=B0=D0=BA=D1=81=D0=B8=D0=BC=
 =D0=9A=D0=BE=D0=BB=D1=8C=D1=86=D0=BE=D0=B2 <span dir=3D"ltr">&lt;<a href=
=3D"mailto:kolmax94@gmail.com" target=3D"_blank">kolmax94@gmail.com</a>&gt;=
</span> wrote:<blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px=
 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class=
=3D"gmail-HOEnZb"><div class=3D"gmail-h5">
<br>
</div></div>I&#39;ve switched to Gunicorn, adding SSL support. It has the s=
ame<br>
interface as the original container: PGADMIN_ENABLE_TLS,<br>
/certs/server.key and /certs/server.cert.<br>
I also incorporated building of sphinx manual in Dockerfile, so now<br>
the image should be complete.<br></blockquote><div><br></div><div>Nice!</di=
v><div>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0p=
x 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
I noticed that I can&#39;t use gunicorn forking worker with pgadmin4, this<=
br>
is probably caused by session implementation, but I&#39;m not sure. You<br>
can investigate this by using e.g. `-w 4` in entrypoint.sh, otherwise<br>
it&#39;s working fine with single-process threaded worker.<br></blockquote>=
<div><br></div><div>This is expected, and the reason why is explained here:=
=C2=A0<a href=3D"https://www.pgadmin.org/docs/pgadmin4/2.x/server_deploymen=
t.html#requirements">https://www.pgadmin.org/docs/pgadmin4/2.x/server_deplo=
yment.html#requirements</a></div><div>=C2=A0</div><blockquote class=3D"gmai=
l_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,20=
4,204);padding-left:1ex">
<br>
I will make my work into a patch and send it to the mail list soon.<br>
Meanwhile, it&#39;d be great if you tested the updated image at<br>
<a href=3D"https://hub.docker.com/r/maksbotan/pgadmin4/" rel=3D"noreferrer"=
 target=3D"_blank">https://hub.docker.com/r/<wbr>maksbotan/pgadmin4/</a></b=
lockquote><div><br></div><div>I&#39;ll try to take a look later in the week=
 (busy prepping for a release at the moment).=C2=A0</div></div><div><br></d=
iv>-- <br><div class=3D"gmail_signature">Dave Page<br>Blog: <a href=3D"http=
://pgsnake.blogspot.com" target=3D"_blank">http://pgsnake.blogspot.com</a><=
br>Twitter: @pgsnake<br><br>EnterpriseDB UK: <a href=3D"http://www.enterpri=
sedb.com" target=3D"_blank">http://www.enterprisedb.com</a><br>The Enterpri=
se PostgreSQL Company<br></div>
</div></div>

--001a1141101275b05c0567c22360--