Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bxXh3-0006Lt-68 for pgadmin-hackers@arkaria.postgresql.org; Fri, 21 Oct 2016 11:08:57 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bxXh2-0002Pl-BL for pgadmin-hackers@arkaria.postgresql.org; Fri, 21 Oct 2016 11:08:56 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bxXh1-0002OS-LA for pgadmin-hackers@postgresql.org; Fri, 21 Oct 2016 11:08:55 +0000 Received: from mail-it0-x22e.google.com ([2607:f8b0:4001:c0b::22e]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bxXgy-0005WD-Bi for pgadmin-hackers@postgresql.org; Fri, 21 Oct 2016 11:08:55 +0000 Received: by mail-it0-x22e.google.com with SMTP id 66so152232952itl.1 for ; Fri, 21 Oct 2016 04:08:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=l09ef5nkO7d5aorQLkDQAAquDt/ajfWgVl8+M19hBBA=; b=jW8yc5TU9SguNa9qSZkQXo/NhvTYRPJZv6S7tQR3UcER9Fwu0hGDVPU7a2dIkbeSy5 1swyO77FZrn4jPlI2trJuboAmOLiz6KUtH/KbQcNjj7MVfpTvT6Z8b1B6WJJ0tRuapN/ EQv1bbjBua58snstF3XBgleVB1teSGkiXpjcHNsVhntMLfFo+fBSB2DewEeLCDICrkPm WTVqM+QpxfUKAsjChHa5sOo4nrqL4JPt1IcnOg6ErNvG0ww7q/nCUHUzpGJm759cfZbk mVZlP7JXjR62h1Wuiw8pnqtRiWxVTpmXbiQ+pGXlqVxT+ANr3aE5eyKgvkZBQsvTCNW3 9Y0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=l09ef5nkO7d5aorQLkDQAAquDt/ajfWgVl8+M19hBBA=; b=al42H85in2/urBC1MKAjMk7bwJmiUKpksWVPrVJ6PGp5TPMeJG05jJbNHlpP9PFGjD bdCIfVTyZ6fYHwWa1AK61auVduMPRqV9OHsoNleLjZEg09cf9PhseeRi+Duv+T2hp4A/ xRCKm8/Gp7q+7ijIPiquSYwuS8N6qMgNH8f7QXEqdU+TcrIFA0p237GX4sFtged61/NQ pEWMg8gb9nPGY99rcrEJw0O5qcE0K6Wem5LTG4AMuVrGIv3rZDSsIIhW9g5RJI7ZLUaC f0YBugQ32bQMZ9coBCFMVQdIWtTVFILnFyndsBufIof8LjLkz+HkRUmPwmEtHMCggU11 yF3g== X-Gm-Message-State: ABUngvfAZdUJPhDckR1FZYchkOMHybuDGgfuzdemwDJ3hYf8fID6Nuhq1t6Pb3k5Px3FO2yafLPr+3k9cnbQYg== X-Received: by 10.107.12.206 with SMTP id 75mr283554iom.208.1477048130754; Fri, 21 Oct 2016 04:08:50 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.82.130 with HTTP; Fri, 21 Oct 2016 04:08:50 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Fri, 21 Oct 2016 12:08:50 +0100 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM1840 - cannot create gist index due to enforced ASC, DESC options in generated SQL To: Surinder Kumar Cc: pgadmin-hackers Content-Type: text/plain; charset=UTF-8 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org Thanks, applied. On Thu, Oct 20, 2016 at 7:47 AM, Surinder Kumar wrote: > Hi, > > The options like "sort" and "nulls" must be conditional. i.e. include only > when access method type is other than "gist" or "gin". > > Please find attached patch and review. > > Thanks, > Surinder Kumar > > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers