public inbox for [email protected]  
help / color / mirror / Atom feed
From: Dave Page <[email protected]>
To: Ashesh Vashi <[email protected]>
Cc: Andrei Antonov <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: security bug (with patch-fix) -- need more HTML-escaping for working with tree-nodes
Date: Wed, 10 May 2017 09:06:30 +0100
Message-ID: <CA+OCxowGKGo+cVpKV6q8HzNdz0cZYEo+HQhwDrG6D2owbitqeQ@mail.gmail.com> (raw)
In-Reply-To: <CAG7mmoz8HSMBZcA+mpY_dzkJP6MZbWf44EHh3OBGutRzQDCDXQ@mail.gmail.com>
References: <[email protected]>
	<CAG7mmoygGeXaeV9WT3cBtLKf_4qsdFBvivUZyp1pbkxmh3mUkw@mail.gmail.com>
	<CA+OCxoxHMMzgFCQ8hmMx9AtoYcRpVO2KJqLKJNWMf9=KYEJ7qw@mail.gmail.com>
	<CAG7mmoz8HSMBZcA+mpY_dzkJP6MZbWf44EHh3OBGutRzQDCDXQ@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

On Wed, May 10, 2017 at 9:00 AM, Ashesh Vashi <[email protected]
> wrote:

> On Wed, May 10, 2017 at 1:29 PM, Dave Page <[email protected]> wrote:
>
>>
>>
>> On Wed, May 10, 2017 at 8:56 AM, Ashesh Vashi <
>> [email protected]> wrote:
>>
>>> Thanks.
>>> Committed!
>>>
>>
>> I agree with the change from a preventative/safety perspective, though
>> I'm struggling to classify it as a security issue, given that collections
>> are always named by the code and not from user input.
>>
>> Am I missing something?
>>
> True - but not the case with the server-group.
> It is a collection node, still has it's own label.
>

Ahh, yes.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


view thread (7+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: security bug (with patch-fix) -- need more HTML-escaping for working with tree-nodes
  In-Reply-To: <CA+OCxowGKGo+cVpKV6q8HzNdz0cZYEo+HQhwDrG6D2owbitqeQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox