MIME-Version: 1.0
In-Reply-To: 
 <CAFOhELdQLJHccik87AkTPY5nop0P3mF1xy2wEBNkoSSssmumMQ@mail.gmail.com>
References: 
 <CAFOhELdzaBaPE1ev9t61+e3fbTDYNsMod1wMLRmG3YAWP5jpug@mail.gmail.com>
 <CAFOhELdQLJHccik87AkTPY5nop0P3mF1xy2wEBNkoSSssmumMQ@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Fri, 8 Jun 2018 09:51:34 +0100
Message-ID: 
 <CA+OCxowGMOcrHAv4Q4PSu58PjQV3DfYtRuvba6wg-G_27uMjhA@mail.gmail.com>
Subject: Re: [pgAdmin4][Patch]: RM 3362 - Fix the functions for PG v11, and
 add support procedure for PG v11
To: Khushboo Vashi <khushboo.vashi@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000da14a5056e1d817a"
Precedence: bulk

--000000000000da14a5056e1d817a
Content-Type: text/plain; charset="UTF-8"

Hi

On Thu, Jun 7, 2018 at 11:27 AM, Khushboo Vashi <
khushboo.vashi@enterprisedb.com> wrote:

> Hi,
>
> Please ignore my previous patch, find the attached updated one.
>

I found a couple of issues with this:

- Clicking the + button on the Parameters tab does nothing in either Create
or Edit modes

- The debugger fails to start (though, perhaps that's because the plugin
doesn't have Ashesh's latest patches in it).

FYI, I was trying to test the debugger with:

-- PROCEDURE: public.dummy_proc(integer)

-- DROP PROCEDURE public.dummy_proc(integer);

CREATE OR REPLACE  PROCEDURE public.dummy_proc(
id integer)
LANGUAGE 'plpgsql'

AS $BODY$BEGIN
  raise notice 'id is %', id;
END;$BODY$;

Thanks!

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--000000000000da14a5056e1d817a
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi<br><div class=3D"gmail_extra"><br><div class=3D"gmail_q=
uote">On Thu, Jun 7, 2018 at 11:27 AM, Khushboo Vashi <span dir=3D"ltr">&lt=
;<a href=3D"mailto:khushboo.vashi@enterprisedb.com" target=3D"_blank">khush=
boo.vashi@enterprisedb.com</a>&gt;</span> wrote:<br><blockquote class=3D"gm=
ail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,=
204,204);padding-left:1ex"><div dir=3D"ltr">Hi,<div><br></div><div>Please i=
gnore my previous patch, find the attached updated one.</div></div></blockq=
uote><div><br></div><div>I found a couple of issues with this:</div><div><b=
r></div><div>- Clicking the + button on the Parameters tab does nothing in =
either Create or Edit modes</div><div><br></div><div>- The debugger fails t=
o start (though, perhaps that&#39;s because the plugin doesn&#39;t have Ash=
esh&#39;s latest patches in it).</div><div><br></div><div>FYI, I was trying=
 to test the debugger with:</div><div><br></div><div><div>-- PROCEDURE: pub=
lic.dummy_proc(integer)</div><div><br></div><div>-- DROP PROCEDURE public.d=
ummy_proc(integer);</div><div><br></div><div>CREATE OR REPLACE=C2=A0 PROCED=
URE public.dummy_proc(</div><div><span style=3D"white-space:pre">	</span>id=
 integer)</div><div>LANGUAGE &#39;plpgsql&#39;</div><div><br></div><div>AS =
$BODY$BEGIN</div><div>=C2=A0 raise notice &#39;id is %&#39;, id;</div><div>=
END;$BODY$;</div></div><div><br></div><div>Thanks!</div></div><div><br></di=
v>-- <br><div class=3D"gmail_signature">Dave Page<br>Blog: <a href=3D"http:=
//pgsnake.blogspot.com" target=3D"_blank">http://pgsnake.blogspot.com</a><b=
r>Twitter: @pgsnake<br><br>EnterpriseDB UK: <a href=3D"http://www.enterpris=
edb.com" target=3D"_blank">http://www.enterprisedb.com</a><br>The Enterpris=
e PostgreSQL Company<br></div>
</div></div>

--000000000000da14a5056e1d817a--