MIME-Version: 1.0
In-Reply-To: 
 <CAE+jjan6rjyLAtq03-CCvzgbatHk2yWDec-ZvdjZuwHPum54-Q@mail.gmail.com>
References: 
 <CA+OCxoyjbMa6EK=Wu+d56S7teJ7YRVP2sY73BbYFwiRZAwUetA@mail.gmail.com>
 <CAKKotZTWLWDHxKf5ct0hUzVbMzjXTg9sxu-0wgTWgthQ2H2FaQ@mail.gmail.com>
 <CAE+jjakNKHxb4vpz6-aHu0_U9c0A1jvjQ8Nn=JMcLtM9jjnqbQ@mail.gmail.com>
 <CABUevEw27=-7oRiX5XYQ=o-ThdmSUcYpzcSsXEcr0wOROYH-Zg@mail.gmail.com>
 <CA+OCxowzxOTwduJhVQwo6cxj=11uvmTNFSrkxdxG1hbkyfeQGg@mail.gmail.com>
 <CA+OCxoyCVWvRAM-ePx-CN-uDbVP26CAQgySZbgS_Scub2JKn9g@mail.gmail.com>
 <CAE+jjan6rjyLAtq03-CCvzgbatHk2yWDec-ZvdjZuwHPum54-Q@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Fri, 23 Mar 2018 11:27:21 +0000
Message-ID: 
 <CA+OCxowGYnNsgMMEhebYSbBW_hZn7spFtCRtsAkJxxcJQOXWNQ@mail.gmail.com>
Subject: Re: Showstopper desktop runtime issue
To: Joao De Almeida Pereira <jdealmeidapereira@pivotal.io>
Cc: Magnus Hagander <magnus@hagander.net>,
	Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>,
	pgadmin-hackers <pgadmin-hackers@postgresql.org>,
	Akshay Joshi <akshay.joshi@enterprisedb.com>,
 Neel Patel <neel.patel@enterprisedb.com>,
	Ashesh Vashi <ashesh.vashi@enterprisedb.com>,
 Robert Eckhardt <reckhardt@pivotal.io>
Content-Type: multipart/alternative; boundary="001a114110122ea58e056812b57f"
Precedence: bulk

--001a114110122ea58e056812b57f
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi

On Thu, Mar 22, 2018 at 6:27 PM, Joao De Almeida Pereira <
jdealmeidapereira@pivotal.io> wrote:

> Hello Hackers
>
> In the PoC we did with Electron last month this was the point where we
> stopped
>
> What did we accomplish:
>  - Use Electron as a runtime and packaging solution for the application
>  - Support opening new windows when the preferences ask for them
>  - Make the application generally work
>  - Use Chrome as a default browser for the application
>  - Building scripts for all platforms using `yarn`, please review Readme
>  - The packaged Python version is 3.6 to Mac and Linux, and 3.4 to Window=
s
>  - In our point of view it is a simpler way to generate the installers
>
> Work in progress:
>  - No random port for the server, so you can only start 1 instance per
> machine
>  - Tab support, there is no native support for tabs in Electron. It is
> possible to do that, and eventually you will see a option in the menu to
> create a new tab, but for this PoC we decided to disable the creation of
> tabs. Tabs need to be implemented using HTML and cannot be ripped of from
> the current window, like in Chrome
>  - Did not test in CentOS, but tested in Ubuntu and it is working (We
> tried but the electron required GLIBC 2.25 that was not on the version of
> CentOS that we had)
>  - In Linux despite the fact that we close the window, the application is
> still running and need to be killed by hand
>  - We didn't test Debugger opening in new window
>  - Loading screen has no reference to pgAdmin
>  - No logging file for the runtime
>  - Windows we are using python 3.4 and using prior version of psycopg2
> 2.5.6 and pycrypto 2.6.1 (The version of psycopg2 is not the correct one,
> this is because we couldn't find a precompile version of psycopg2)
>  - This is just a spike and the code looks pretty messy. This need to be
> changed in order to make it more readable and have some tests around it
>  - Murtuza and Fahar were not able to run the application in Windows
>  - Khushboo was not able to run Ubuntu version
>
> Given this was the status at the time, we need to pick and choose what we
> really want to implement right out of the box and what could be postponed=
.
> In order to generate Windows build and ensure that the Linux build is
> working we need so help. If we could have access to the machines that you
> use to build pgAdmin or access to the venv folder that is generated in
> these machines we could try to create a build from that.
>
> The changes we produced still applies cleanly on master and can be found
> in: https://github.com/greenplum-db/pgadmin4/tree/electron-over-master
>
>
I just tried building the PoC again, and got much further than before - in
fact I did get a working app bundle out at the end, however the dist build
did spew out the errors below:

piranha:electron dpage$ yarn dist
yarn run v1.3.2
$ ./node_modules/.bin/electron-builder
  =E2=80=A2 electron-builder version=3D20.0.7
  =E2=80=A2 loaded configuration file=3Dpackage.json ("build" field)
  =E2=80=A2 writing effective config file=3Ddist/electron-builder.yaml
  =E2=80=A2 no native production dependencies
  =E2=80=A2 asar using is disabled =E2=80=94 it is strongly not recommended=
 solution=3Denable
asar and use asarUnpack to unpack files that must be externally available
  =E2=80=A2 packaging       platform=3Ddarwin arch=3Dx64 electron=3D1.8.2
appOutDir=3Ddist/mac
  =E2=80=A2 signing         file=3Ddist/mac/pgAdmin 4.app identityName=3DDe=
veloper ID
Application: <redacted> identityHash=3D<redacted>
Error: Command failed: codesign --verify --deep --strict --verbose=3D2
/Users/dpage/git/pgadmin4-electron/electron/dist/mac/pgAdmin 4.app
--prepared:/Users/dpage/git/pgadmin4-electron/electron/dist/mac/pgAdmin
4.app/Contents/Frameworks/pgAdmin 4 Helper NP.app
--validated:/Users/dpage/git/pgadmin4-electron/electron/dist/mac/pgAdmin
4.app/Contents/Frameworks/pgAdmin 4 Helper NP.app
--prepared:/Users/dpage/git/pgadmin4-electron/electron/dist/mac/pgAdmin
4.app/Contents/Frameworks/pgAdmin 4 Helper EH.app
--prepared:/Users/dpage/git/pgadmin4-electron/electron/dist/mac/pgAdmin
4.app/Contents/Frameworks/pgAdmin 4 Helper.app
--validated:/Users/dpage/git/pgadmin4-electron/electron/dist/mac/pgAdmin
4.app/Contents/Frameworks/pgAdmin 4 Helper.app
--validated:/Users/dpage/git/pgadmin4-electron/electron/dist/mac/pgAdmin
4.app/Contents/Frameworks/pgAdmin 4 Helper EH.app
--prepared:/Users/dpage/git/pgadmin4-electron/electron/dist/mac/pgAdmin
4.app/Contents/Frameworks/Mantle.framework/Versions/Current/.
--validated:/Users/dpage/git/pgadmin4-electron/electron/dist/mac/pgAdmin
4.app/Contents/Frameworks/Mantle.framework/Versions/Current/.
--prepared:/Users/dpage/git/pgadmin4-electron/electron/dist/mac/pgAdmin
4.app/Contents/Frameworks/Squirrel.framework/Versions/Current/.
--validated:/Users/dpage/git/pgadmin4-electron/electron/dist/mac/pgAdmin
4.app/Contents/Frameworks/Squirrel.framework/Versions/Current/.
--prepared:/Users/dpage/git/pgadmin4-electron/electron/dist/mac/pgAdmin
4.app/Contents/Frameworks/ReactiveCocoa.framework/Versions/Current/.
--validated:/Users/dpage/git/pgadmin4-electron/electron/dist/mac/pgAdmin
4.app/Contents/Frameworks/ReactiveCocoa.framework/Versions/Current/.
--prepared:/Users/dpage/git/pgadmin4-electron/electron/dist/mac/pgAdmin
4.app/Contents/Frameworks/Electron Framework.framework/Versions/Current/.
--validated:/Users/dpage/git/pgadmin4-electron/electron/dist/mac/pgAdmin
4.app/Contents/Frameworks/Electron Framework.framework/Versions/Current/.
/Users/dpage/git/pgadmin4-electron/electron/dist/mac/pgAdmin 4.app: No such
file or directory

    at ChildProcess.exithandler (child_process.js:275:12)
    at emitTwo (events.js:126:13)
    at ChildProcess.emit (events.js:214:7)
    at maybeClose (internal/child_process.js:925:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:209:5=
)