MIME-Version: 1.0
In-Reply-To: 
 <CAFiP3vyTB+ceHGxwXn_w8RBmDQn9SVC3i+1kXhv=CD8UWr3=Xg@mail.gmail.com>
References: 
 <CAFiP3vxoqJ8Rd2fiXev2di1Se_WuyAZdMtUHcHG3HuHwk-vj0g@mail.gmail.com>
 <CA+OCxozZz4q4Cac8sS2wZ0OprfjOKQRqmSXQjHdd=-sBoVfsbA@mail.gmail.com>
 <CAFiP3vxfQ4=+zjLW9HR_dtYkbgfZLvKLnLZi-A3m4rbFH_A5xA@mail.gmail.com>
 <CAFiP3vznYPXdvmGj2J7i4S7e-BPUVWWUC5KFAK=Q7n6Nee5ThA@mail.gmail.com>
 <CA+OCxoza3djrtauF1VqSvqU1pXBr8gAzHD9xF1T37HbkbgEztA@mail.gmail.com>
 <CAFiP3vyTB+ceHGxwXn_w8RBmDQn9SVC3i+1kXhv=CD8UWr3=Xg@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Thu, 16 Jun 2016 12:40:10 +0100
Message-ID: 
 <CA+OCxowGax9fd5YmTG3u82Ums0rwkETiXFQPuBokKBx_Br8BOA@mail.gmail.com>
Subject: Re: Fix for issue RM1336 [pgadmin4]
To: Harshal Dhumal <harshal.dhumal@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: text/plain; charset=UTF-8
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

On Thu, Jun 16, 2016 at 12:14 PM, Harshal Dhumal
<harshal.dhumal@enterprisedb.com> wrote:
> Hi,
>
> As per my offline discussion with Ashesh; He is suggesting not to use
> Function keys as shortcuts.

Why? That is primarily what they are on the keyboard for.

> And regarding configurable key options, I suspect It is going to be time
> consuming task, please let me know if you want me to start working it. Or
> can we keep current shortcuts from my last patch?

Surely we can come up with some simple ones that will be intuitive and work?

>
> On Thu, Jun 16, 2016 at 4:19 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> Hi
>>
>> Hmm, I guess that's system dependent. What about Ctrl+F5? Or we bite
>> the bullet and make it configurable.
>>
>> On Thu, Jun 16, 2016 at 11:47 AM, Harshal Dhumal
>> <harshal.dhumal@enterprisedb.com> wrote:
>> > Hi Dave,
>> >
>> > Function keys won't work properly with browser as they already have
>> > predefined bindings.
>> >
>> > e.g.
>> >
>> > F5 for refresh (standard)
>> > F7 for Caret Browsing in firefox
>> >
>> >
>> > --
>> > Harshal Dhumal
>> > Software Engineer
>> >
>> > EnterpriseDB India: http://www.enterprisedb.com
>> > The Enterprise PostgreSQL Company
>> >
>> > On Thu, Jun 16, 2016 at 4:10 PM, Harshal Dhumal
>> > <harshal.dhumal@enterprisedb.com> wrote:
>> >>
>> >> Hi Dave,
>> >>
>> >> Ok, I'll change shortcut keys
>> >>
>> >> New shortcuts would be:
>> >>
>> >> Execute  -->   F5
>> >> Explain  -->    F7
>> >> Explain analyze  --> Shift+F7
>> >>
>> >>
>> >>
>> >> --
>> >> Harshal Dhumal
>> >> Software Engineer
>> >>
>> >> EnterpriseDB India: http://www.enterprisedb.com
>> >> The Enterprise PostgreSQL Company
>> >>
>> >> On Thu, Jun 16, 2016 at 4:03 PM, Dave Page <dpage@pgadmin.org> wrote:
>> >>>
>> >>> Hi,
>> >>>
>> >>> Can we not make them compatible with pgAdmin 3? Ctrl + Shift + E is
>> >>> significantly less convenient than F5.
>> >>>
>> >>> On Thu, Jun 16, 2016 at 11:28 AM, Harshal Dhumal
>> >>> <harshal.dhumal@enterprisedb.com> wrote:
>> >>> > Hi,
>> >>> >
>> >>> > PAF patch for issue RM1336
>> >>> >
>> >>> > Changes: Added keyboard shortcuts (static/non configurable) to some
>> >>> > query
>> >>> > tool operations.
>> >>> >
>> >>> > Execute  -->   Ctrl + Shift + E
>> >>> > Explain  -->    Ctrl + Shift + X
>> >>> > Explain analyze  -->   Ctrl + Shift + A
>> >>> >
>> >>> > Note: Keyboard shortcuts do not work if focus is set on any disabled
>> >>> > button
>> >>> > inside query tool or out side the query tool.
>> >>> >
>> >>> >
>> >>> > --
>> >>> > Harshal Dhumal
>> >>> > Software Engineer
>> >>> >
>> >>> > EnterpriseDB India: http://www.enterprisedb.com
>> >>> > The Enterprise PostgreSQL Company
>> >>> >
>> >>> >
>> >>> > --
>> >>> > Sent via pgadmin-hackers mailing list
>> >>> > (pgadmin-hackers@postgresql.org)
>> >>> > To make changes to your subscription:
>> >>> > http://www.postgresql.org/mailpref/pgadmin-hackers
>> >>> >
>> >>>
>> >>>
>> >>>
>> >>> --
>> >>> Dave Page
>> >>> Blog: http://pgsnake.blogspot.com
>> >>> Twitter: @pgsnake
>> >>>
>> >>> EnterpriseDB UK: http://www.enterprisedb.com
>> >>> The Enterprise PostgreSQL Company
>> >>
>> >>
>> >
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers