MIME-Version: 1.0
References: 
 <CANxoLDfBh-SmU=44vLEMz1_jxGDTWWS_OQOfRpagDEHwxDD8qw@mail.gmail.com>
In-Reply-To: 
 <CANxoLDfBh-SmU=44vLEMz1_jxGDTWWS_OQOfRpagDEHwxDD8qw@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Thu, 10 Jan 2019 12:26:38 +0530
Message-ID: 
 <CA+OCxowGj-P2PkZdw443WdGmCP4yH6GKiCUuQ2LSr+GR2NEJfg@mail.gmail.com>
Subject: Re: [pgAdmin4][Patch] - RM 3836 VACUUM FULL FREEZE ANALYZE VERBOSE
 syntax error on PostgreSQL 11
To: Akshay Joshi <akshay.joshi@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000248bed057f1515a9"
Precedence: bulk

--000000000000248bed057f1515a9
Content-Type: text/plain; charset="UTF-8"

Hi

On Wed, Jan 9, 2019 at 6:46 PM Akshay Joshi <akshay.joshi@enterprisedb.com>
wrote:

> Hi Hackers,
>
> Attached is the patch to fix RM #3836 VACUUM FULL FREEZE ANALYZE VERBOSE
> syntax error on PostgreSQL 11. Order of commands has been changed in
> PostgreSQL 11 "https://github.com/postgres/postgres
> /commit/921059bd66c7fb1230c705d3b1a65940800c4cbb"
>
> Please review it.
>

I tried to test this, and got what looks like the same issue that we looked
at the other day with Import/Export. Can you look at it please?

2019-01-10 12:25:02,044: INFO werkzeug: 127.0.0.1 - - [10/Jan/2019
12:25:02] "POST /maintenance/job/2/12669 HTTP/1.1" 500 -
2019-01-10 12:25:02,051: ERROR werkzeug: Error on request:
Traceback (most recent call last):
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/werkzeug/serving.py",
line 270, in run_wsgi
    execute(self.server.app)
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/werkzeug/serving.py",
line 258, in execute
    application_iter = app(environ, start_response)
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/flask/app.py",
line 1997, in __call__
    return self.wsgi_app(environ, start_response)
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/flask/app.py",
line 1985, in wsgi_app
    response = self.handle_exception(e)
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/flask/app.py",
line 1540, in handle_exception
    reraise(exc_type, exc_value, tb)
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/flask/_compat.py",
line 33, in reraise
    raise value
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/flask/app.py",
line 1982, in wsgi_app
    response = self.full_dispatch_request()
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/flask/app.py",
line 1614, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/flask/app.py",
line 1517, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/flask/_compat.py",
line 33, in reraise
    raise value
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/flask/app.py",
line 1612, in full_dispatch_request
    rv = self.dispatch_request()
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/flask/app.py",
line 1598, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/flask_login.py",
line 792, in decorated_view
    return func(*args, **kwargs)
  File
"/Users/dpage/git/pgadmin4/web/pgadmin/tools/maintenance/__init__.py", line
179, in create_maintenance_job
    data = json.loads(data['data'][0], encoding='utf-8')
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/simplejson/__init__.py",
line 535, in loads
    return cls(encoding=encoding, **kw).decode(s)
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/simplejson/decoder.py",
line 370, in decode
    obj, end = self.raw_decode(s)
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/simplejson/decoder.py",
line 400, in raw_decode
    return self.scan_once(s, idx=_w(s, idx).end())
simplejson.errors.JSONDecodeError: Expecting property name enclosed in
double quotes or '}': line 1 column 2 (char 1)


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--000000000000248bed057f1515a9
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr">Hi</div><br><div class=
=3D"gmail_quote"><div dir=3D"ltr">On Wed, Jan 9, 2019 at 6:46 PM Akshay Jos=
hi &lt;<a href=3D"mailto:akshay.joshi@enterprisedb.com">akshay.joshi@enterp=
risedb.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=
=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding=
-left:1ex"><div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr">Hi Hackers,</=
div><div dir=3D"ltr"><br></div><div dir=3D"ltr"><div>Attached is the patch =
to fix RM #3836=C2=A0VACUUM FULL FREEZE ANALYZE VERBOSE syntax error on <sp=
an id=3D"gmail-m_-5308148597812950768:2sg.7">PostgreSQL</span> 11. Order of=
 commands has been changed in <span id=3D"gmail-m_-5308148597812950768:2sg.=
8">PostgreSQL</span> 11 &quot;https://<span id=3D"gmail-m_-5308148597812950=
768:2sg.9">github</span>.com/<span id=3D"gmail-m_-5308148597812950768:2sg.1=
0">postgres</span>/<span id=3D"gmail-m_-5308148597812950768:2sg.11">postgre=
s</span>/commit/921059bd66c7fb1230c705d3b1a65940800c4cbb&quot;</div><div><b=
r></div><div>Please review it.</div></div></div></div></blockquote><div><br=
></div><div>I tried to test this, and got what looks like the same issue th=
at we looked at the other day with Import/Export. Can you look at it please=
?</div><div><br></div><div>2019-01-10 12:25:02,044: INFO<span style=3D"whit=
e-space:pre">	</span>werkzeug:<span style=3D"white-space:pre">	</span>127.0=
.0.1 - - [10/Jan/2019 12:25:02] &quot;POST /maintenance/job/2/12669 HTTP/1.=
1&quot; 500 -</div><div>2019-01-10 12:25:02,051: ERROR<span style=3D"white-=
space:pre">	</span>werkzeug:<span style=3D"white-space:pre">	</span>Error o=
n request:</div><div>Traceback (most recent call last):</div><div>=C2=A0 Fi=
le &quot;/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/wer=
kzeug/serving.py&quot;, line 270, in run_wsgi</div><div>=C2=A0 =C2=A0 execu=
te(self.server.app)</div><div>=C2=A0 File &quot;/Users/dpage/.virtualenvs/p=
gadmin4/lib/python3.6/site-packages/werkzeug/serving.py&quot;, line 258, in=
 execute</div><div>=C2=A0 =C2=A0 application_iter =3D app(environ, start_re=
sponse)</div><div>=C2=A0 File &quot;/Users/dpage/.virtualenvs/pgadmin4/lib/=
python3.6/site-packages/flask/app.py&quot;, line 1997, in __call__</div><di=
v>=C2=A0 =C2=A0 return self.wsgi_app(environ, start_response)</div><div>=C2=
=A0 File &quot;/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packag=
es/flask/app.py&quot;, line 1985, in wsgi_app</div><div>=C2=A0 =C2=A0 respo=
nse =3D self.handle_exception(e)</div><div>=C2=A0 File &quot;/Users/dpage/.=
virtualenvs/pgadmin4/lib/python3.6/site-packages/flask/app.py&quot;, line 1=
540, in handle_exception</div><div>=C2=A0 =C2=A0 reraise(exc_type, exc_valu=
e, tb)</div><div>=C2=A0 File &quot;/Users/dpage/.virtualenvs/pgadmin4/lib/p=
ython3.6/site-packages/flask/_compat.py&quot;, line 33, in reraise</div><di=
v>=C2=A0 =C2=A0 raise value</div><div>=C2=A0 File &quot;/Users/dpage/.virtu=
alenvs/pgadmin4/lib/python3.6/site-packages/flask/app.py&quot;, line 1982, =
in wsgi_app</div><div>=C2=A0 =C2=A0 response =3D self.full_dispatch_request=
()</div><div>=C2=A0 File &quot;/Users/dpage/.virtualenvs/pgadmin4/lib/pytho=
n3.6/site-packages/flask/app.py&quot;, line 1614, in full_dispatch_request<=
/div><div>=C2=A0 =C2=A0 rv =3D self.handle_user_exception(e)</div><div>=C2=
=A0 File &quot;/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packag=
es/flask/app.py&quot;, line 1517, in handle_user_exception</div><div>=C2=A0=
 =C2=A0 reraise(exc_type, exc_value, tb)</div><div>=C2=A0 File &quot;/Users=
/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/flask/_compat.py&q=
uot;, line 33, in reraise</div><div>=C2=A0 =C2=A0 raise value</div><div>=C2=
=A0 File &quot;/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packag=
es/flask/app.py&quot;, line 1612, in full_dispatch_request</div><div>=C2=A0=
 =C2=A0 rv =3D self.dispatch_request()</div><div>=C2=A0 File &quot;/Users/d=
page/.virtualenvs/pgadmin4/lib/python3.6/site-packages/flask/app.py&quot;, =
line 1598, in dispatch_request</div><div>=C2=A0 =C2=A0 return self.view_fun=
ctions[rule.endpoint](**req.view_args)</div><div>=C2=A0 File &quot;/Users/d=
page/.virtualenvs/pgadmin4/lib/python3.6/site-packages/flask_login.py&quot;=
, line 792, in decorated_view</div><div>=C2=A0 =C2=A0 return func(*args, **=
kwargs)</div><div>=C2=A0 File &quot;/Users/dpage/git/pgadmin4/web/pgadmin/t=
ools/maintenance/__init__.py&quot;, line 179, in create_maintenance_job</di=
v><div>=C2=A0 =C2=A0 data =3D json.loads(data[&#39;data&#39;][0], encoding=
=3D&#39;utf-8&#39;)</div><div>=C2=A0 File &quot;/Users/dpage/.virtualenvs/p=
gadmin4/lib/python3.6/site-packages/simplejson/__init__.py&quot;, line 535,=
 in loads</div><div>=C2=A0 =C2=A0 return cls(encoding=3Dencoding, **kw).dec=
ode(s)</div><div>=C2=A0 File &quot;/Users/dpage/.virtualenvs/pgadmin4/lib/p=
ython3.6/site-packages/simplejson/decoder.py&quot;, line 370, in decode</di=
v><div>=C2=A0 =C2=A0 obj, end =3D self.raw_decode(s)</div><div>=C2=A0 File =
&quot;/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/simple=
json/decoder.py&quot;, line 400, in raw_decode</div><div>=C2=A0 =C2=A0 retu=
rn self.scan_once(s, idx=3D_w(s, idx).end())</div><div>simplejson.errors.JS=
ONDecodeError: Expecting property name enclosed in double quotes or &#39;}&=
#39;: line 1 column 2 (char 1)</div><div>=C2=A0</div></div><div><br></div>-=
- <br><div dir=3D"ltr" class=3D"gmail_signature">Dave Page<br>Blog: <a href=
=3D"http://pgsnake.blogspot.com" target=3D"_blank">http://pgsnake.blogspot.=
com</a><br>Twitter: @pgsnake<br><br>EnterpriseDB UK: <a href=3D"http://www.=
enterprisedb.com" target=3D"_blank">http://www.enterprisedb.com</a><br>The =
Enterprise PostgreSQL Company<br></div></div></div>

--000000000000248bed057f1515a9--