MIME-Version: 1.0
In-Reply-To: 
 <CA+OCxoyr9+e4=EehNR_wRZWB4hRNS-NS8bRyFfaMhCjUb4i-Zw@mail.gmail.com>
References: 
 <CANFyU95gNg6AznegkT1=zXZNcFmaahPtO5_e-RpfuyLEu0c7dA@mail.gmail.com>
	<CA+OCxowni+YFdwSgf7d4OPN1c-8waJvfu4QCV2pLdw+YO433iA@mail.gmail.com>
	<CANFyU96f4a9Zn2czw3Ch_k0w1cyiwiY4KDdyScQgWnW9vQsM-A@mail.gmail.com>
	<CA+OCxox=MSTfMNB8WR5CEAjbSheVNTx_7jmUdpyzjOW5f4RDUQ@mail.gmail.com>
	<CANFyU95BNuQkGTBoLY-LYHS1mRMWQF3zERQuv0bnHhR395SQxA@mail.gmail.com>
	<CA+OCxozgWgaa_HsbYRRRNoQOGr0tC48GW8f2PB1Q0d17zKBiZQ@mail.gmail.com>
	<CANFyU97jAp2xYyYBo9nfpMVcVa=Dv05uBXWX5L8kLiTVmicghA@mail.gmail.com>
	<CA+OCxozZBvL4v8dRdOWhfm2DqwSg7L_MiuJj-L4mbsr8Hg4CyQ@mail.gmail.com>
	<CANFyU95gbc7etZebjvnYGhjs2=kz8=0Gd6s0qzm280ZNR2Fbrg@mail.gmail.com>
	<CA+OCxowbiq_04h3ain47nkBNY=5brPtrW4=9yft042Ju9GtReQ@mail.gmail.com>
	<CANFyU94GTupD+a_CzdTvJ7-fjrinD-PvhRRmo2soLavLBvpveA@mail.gmail.com>
	<CA+OCxoxFap1FVqsrcHG4QU2zDUu6v_5WkyYO3xYyS2yufbq5AA@mail.gmail.com>
	<CANFyU970rjd+thJ0+DThkurNCE5Xg-Zv3y0sp96od7yihQrsgg@mail.gmail.com>
	<CA+OCxowVMN3btVYwBiOq2BtNdRKaFoN950F_ZTm5hmekLZtPdA@mail.gmail.com>
	<CANFyU94k1AbRnMLMtze9GMpxMmtG4D_aitiemzvbTHmC9dzG_Q@mail.gmail.com>
	<CANFyU97a-top6G2S=8-PqqDmHKaSCKM6PK4RJPgUM9aGgBmqOw@mail.gmail.com>
	<CANFyU96iUVCo5ySGiimmi9NV9rS72nvzuT9BJcHjFcJwyADooQ@mail.gmail.com>
	<CA+OCxowGK1-Q_XQ-ZimQTDnusSXjS+6aYAVEV9OjALW0Kt7S4g@mail.gmail.com>
	<CANFyU95OCXvqouhUZUzdQajXV8kymKNce1yFmv27eE=dF3e-kQ@mail.gmail.com>
	<CA+OCxoyr9+e4=EehNR_wRZWB4hRNS-NS8bRyFfaMhCjUb4i-Zw@mail.gmail.com>
Date: Fri, 27 May 2016 16:58:50 +0100
Message-ID: 
 <CA+OCxowH3VuE4vbLvjw58JpMzJSoZQ5mT-hQcK6at4XR9V+TyA@mail.gmail.com>
Subject: Re: Patch for pgAdmin4 package on Mac OS X
From: Dave Page <dpage@pgadmin.org>
To: Sandeep Thakkar <sandeep.thakkar@enterprisedb.com>,
	pgadmin-hackers <pgadmin-hackers@postgresql.org>,
	Hamid Quddus <hamid.quddus@enterprisedb.com>
Content-Type: text/plain; charset=UTF-8
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

On Fri, May 27, 2016 at 4:48 PM, Dave Page <dpage@pgadmin.org> wrote:
>
>
> On Fri, May 27, 2016 at 1:11 PM, Sandeep Thakkar
> <sandeep.thakkar@enterprisedb.com> wrote:
>>
>> Sure. Thanks.
>>
>> There is a typo in pkg/mac/build.sh. i.e
>>
>> s/HTML_HELP/HELP_PATH/
>>
>>
>> On Fri, May 27, 2016 at 5:26 PM, Dave Page <dpage@pgadmin.org> wrote:
>>>
>>> Not entirely - we definitely need to improve it. I'll review the code as
>>> it is now though.
>
>
> OK, review time :-)
>
> - The appbundle name should be created from APP_NAME.app in config.py, e.g.
> 'pgAdmin 4.app'
>
> - The DMG name should be created from
> to_lower(remove_spaces(APP_NAME-APP_VERSION)) in config.py, e.g.
> pgadmin4-1.0-dev.dmg
>
> - Use #ifdef Q_OS_MAC in the QT code for Mac-specific code. There's no need
> to define another macro.
>
> - Please add "MINIFY_HTML = False" to config_local.py (and have Paresh do
> the same on his packages). This works around a code issue with the docs that
> I'll log a bug for.
>
> - In testing, I found that running the app from within the DMG doesn't seem
> to work the first time - it prompts for the path, then exits. Once I save
> the path it offers, it's fine on subsequent runs.
>
> - Once copied to my laptop, I saw the same issue as above.
>
> Once these issues are resolved, I think we're good to commit.

Oh, a couple more things:

- There should not be a copy of the app bundle in dist/ following the
build. Only the dmg should be there.

- I think mac-build/ should be removed following a successful build,
rather than waiting for make clean (please talk to Paresh - his code
should do the same).

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers