Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1evUKp-0001Im-Ds for pgadmin-hackers@arkaria.postgresql.org; Mon, 12 Mar 2018 20:46:19 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1evUKo-0003in-Ax for pgadmin-hackers@arkaria.postgresql.org; Mon, 12 Mar 2018 20:46:18 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1evUKn-0003iT-Tw for pgadmin-hackers@lists.postgresql.org; Mon, 12 Mar 2018 20:46:18 +0000 Received: from mail-wm0-x230.google.com ([2a00:1450:400c:c09::230]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1evUKk-0004mC-AX for pgadmin-hackers@postgresql.org; Mon, 12 Mar 2018 20:46:16 +0000 Received: by mail-wm0-x230.google.com with SMTP id h21so19283420wmd.1 for ; Mon, 12 Mar 2018 13:46:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=qDBpSuELDBojbbMx7xJ4m9h0bmkI9wMO+1WOHCj17EM=; b=ZU1TknYi9jnvMs5ZXctLy1gWQqBCNqMQW9ryIXG4Zf0BqL+ZnpWK8QAjbkWnvzQv5i M3KbW6wPapVXK8mZVi4azLFZdPZL9l6yuXcxgBJLlOyFhfzCQ2Qn/jopShcS/yL82MX0 M9eNn9aDvMSWoE1ttFmlU6MKhKHuPx/20oeI/FXHe+1FQzzzAS+NsV5OT4OAGsvR3qXI Hoc3O+YDPV1a0YKv3yTvq/6MI1KWtR4bkeAqMDVzV6W/JeK4KB4yfFYreb3pMiBmTZCx spPlOxYFHvtcquC67vE4oIgBUmoEzdcmkKbKljWF6+33cD4fJljGOgd3irn9q3ydMTSD 6oog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=qDBpSuELDBojbbMx7xJ4m9h0bmkI9wMO+1WOHCj17EM=; b=EjmGy0r+U92f/NsgTh/Wz9f93cguo3VIQWQZn628+Gt1+UbtAkGZNHFPL2tsryNN0j fxjIdywbEIBochId5PII7MrFJbaRMmRhjWG7EACXFVPlhGmXzY6j0Bu1j7w3KKHZ4MMd hY6RUeNSIVUbU6mif/RCHCrlLn7akASRPnfwVTZWvMFxCPTSXlMWzsKdZvTzfp8LK5k8 qR0ky24d+MX9G/ggxrSFH8iSDmSDK6kDb/QwuMqTziauZG26BwM/p3KBEhshkAms5H7Z DxviXh0dRugUBKJszPs/c0JT9b03vPAbGdOiCTiNCLM4AGitne7WQrIjDaJSbZks5Btg nnKA== X-Gm-Message-State: AElRT7Fcgv2gg78OSe83jjJ+F5qMoMJ0ydeeU93q0dpe7X9bLQWcxjeR 0MphOpobHqUAS5Ws8QEcn8POjJNG2Ste67p0uMn+Vg== X-Google-Smtp-Source: AG47ELvPJebz/cyM1mqaE8x/Yagu0lgU3QszLkJipJJOLrjKJLr6eNPX1teCHK1O4orz/zWk7/ScJHE7oyZNXLqQKBo= X-Received: by 10.28.5.75 with SMTP id 72mr7084449wmf.154.1520887571703; Mon, 12 Mar 2018 13:46:11 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.109.7 with HTTP; Mon, 12 Mar 2018 13:46:11 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Mon, 12 Mar 2018 16:46:11 -0400 Message-ID: Subject: Re: [pgAdmin4][RM#3140] Add service parameter To: Murtuza Zabuawala Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="001a114429c87481e405673d3b3f" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a114429c87481e405673d3b3f Content-Type: text/plain; charset="UTF-8" Thanks, patch applied! On Mon, Mar 12, 2018 at 3:31 AM, Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Hi Dave, > > PFA updated patch. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > On Fri, Mar 9, 2018 at 9:29 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi Dave, >> >> I'll change the name and send you updated patch. >> >> >> On Fri, Mar 9, 2018 at 9:25 PM, Dave Page wrote: >> >>> HI >>> >>> On Fri, Mar 9, 2018 at 11:47 AM, Murtuza Zabuawala < >>> murtuza.zabuawala@enterprisedb.com> wrote: >>> >>>> Hi, >>>> >>>> PFA patch to add service parameter in server dialog. >>>> - Docs updated >>>> - Test case added for Service ID parameter >>>> >>>> Please note, >>>> I have extracted Connection class and Server manager class from our own >>>> custom Psycopg2 driver module. >>>> >>>> Patch also covers RM#3120 >>>> >>> >>> This patch seems a little confused. The "Service" and "Service ID" >>> fields from pgAdmin 3 are very different things. The Redmine ticket seems >>> to be asking for the Service field (the pg_service.conf service name), >>> *not* Service ID (the operating system's service ID, used to start/stop the >>> database server service). >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a114429c87481e405673d3b3f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied!
On Mon, Mar 12, 2018 at 3:31 AM, Murtuza Zabuaw= ala <murtuza.zabuawala@enterprisedb.com> wr= ote:
Hi Dave,

PFA updated patch.

--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Company<= /font>


On Fri, Mar 9, 2018 at 9:29 PM, Murtuza Zabu= awala <murtuza.zabuawala@enterprisedb.com> wrote:
H= i Dave,

I'll change the name and send = you updated patch.


On Fri, Mar 9, 2018 at 9:25 PM, Dave Page <= dpage@pgadmin.org> wrote:
<= div dir=3D"ltr">HI

On Fri, Mar 9, 2018 at 11:47 AM, Murtuza Zabuawala &= lt;= murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to add=C2=A0service parameter in se= rver dialog.
- Docs updated
- Test case added for Service ID parameter

Please note,
I have= extracted Connection class and Server manager class from our own custom Ps= ycopg2 driver module.

Patch also covers RM#3120
<= br>
=C2=A0This patch seems a little confused. The "Service&q= uot; and "Service ID" fields from pgAdmin 3 are very different th= ings. The Redmine ticket seems to be asking for the Service field (the pg_s= ervice.conf service name), *not* Service ID (the operating system's ser= vice ID, used to start/stop the database server service).

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

Enterp= riseDB UK: http:/= /www.enterprisedb.com
The Enterprise PostgreSQL Company





--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--001a114429c87481e405673d3b3f--