Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fYvoq-0000gu-3A for pgadmin-hackers@arkaria.postgresql.org; Fri, 29 Jun 2018 16:00:20 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fYvom-00065O-Gv for pgadmin-hackers@arkaria.postgresql.org; Fri, 29 Jun 2018 16:00:16 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fYvol-00064T-W4 for pgadmin-hackers@lists.postgresql.org; Fri, 29 Jun 2018 16:00:16 +0000 Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fYvoc-0000H1-Lp for pgadmin-hackers@postgresql.org; Fri, 29 Jun 2018 16:00:14 +0000 Received: by mail-wm0-x244.google.com with SMTP id v25-v6so1729490wmc.0 for ; Fri, 29 Jun 2018 09:00:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=qKJfevM9jwWiedilQJsQMTAGuk1r7KSCbcy8adOWyPM=; b=VKsqvNfNjhiH1UJe/+nxoVkOuSKql8ve/tk+cl/aJBHtZEQX7xpOK8DiEr/QCu5Ibn QcmWPYzLSE5v54KbwwWhv+1gvnggLLCBCCnojvLJviEggiXsT2AsasMWDMcxjrYpiNqA YnahXOfvhyb6h6NhVeZsEyuIbM1V8SjmpVIrmGU6ZMUIALOxsau/0sub0S6emc7pnOSx V39Rg/Jv8yIAZaZGCR7OcOfAjx7q3F7pQ8OdvR5sFYv/4xPh226LFZUYZeVI15UvcR5O 5UvYNx1n2nElf7xlBWN0jk8RlCVWR2L+obRZBb0RxF4WleKuD3agGSGy6lZmlTNee/EJ t5AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=qKJfevM9jwWiedilQJsQMTAGuk1r7KSCbcy8adOWyPM=; b=Gonmp4S+09QgHZmV3byoBCJ4zxf8hXmSXqHhEDjTupTe6z6JhTsbDhlq9Y+pzcErC/ ZNO2fSJgKZAWvIfzdjf74fjmAH9KMbTtyVxmCJb2/R5lOpUCfcIg/FlWv1/9GS55xUSm GGWUKjuCd1izWTgOFyWC2bSpsvEtQxka6Uvz/9kV6b4Je561MIie7m1ucrtxzK1GGAwO oXKySDaI79xB0NSksXs6yPzidvYG5N2sUlrp5J4LqTB5gUC7UUuRfn2x5gH33Vpdh+zr nnOdkGvGoFBlSDo7r3SZ+YkryW6tpWgC+asqqT4hOlUh435fENfCVG6rUc59F4ubgiBA +rkg== X-Gm-Message-State: APt69E1R+/Y40zllh1tSsttf9xOY2pXeaizFBiT8yG+Zge/WwfGdtKmC lcSjb+sp1SfMbFgffbdbqcRNCzcuA+Ev1f0il/YOXA== X-Google-Smtp-Source: AAOMgpdu4C8H/g2Ikq/1oOefCUHTtidzxTqYeWx9uiSJcGEQb+8UiPPaPvTzBl0B+jXbUcRbHVYrU129Ttv2bSEoqRo= X-Received: by 2002:a1c:7fc1:: with SMTP id a184-v6mr2168894wmd.161.1530288004808; Fri, 29 Jun 2018 09:00:04 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a1c:2907:0:0:0:0:0 with HTTP; Fri, 29 Jun 2018 09:00:04 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Fri, 29 Jun 2018 17:00:04 +0100 Message-ID: Subject: Re: [pgAdmin4][RM3294] User need to reset the layout to see the changed preferences parameters To: Aditya Toshniwal Cc: Akshay Joshi , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000ee5fd3056fc9f05f" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000ee5fd3056fc9f05f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi On Fri, Jun 29, 2018 at 3:14 PM, Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the updated patch. > This seems to work for the most part, however I saw what seemed like odd behaviour. If I have 2 query tool windows open; - Changing a preference from the Preferences dialogue updates both query tools. - Changing a preference from a Query Tool updates the Preferences dialogue. - Changing a preference from a Query Tool does *not* update the other Query Tool. The last point seems odd to me, though it also kinda makes sense to not have one query tool affect the other. The problem with that is that it could get quite confusing when they get out of sync. I think it would be better for a change in one Query Tool to update the other(s). What do you think? Was this behaviour intentional? (FYI, in case this was a one-off bug, I was testing using "Auto Commit?") > > On Fri, Jun 29, 2018 at 4:46 PM, Aditya Toshniwal enterprisedb.com> wrote: > >> Hi Akshay, >> >> On Fri, Jun 29, 2018 at 3:42 PM, Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> Hi Aditya >>> >>> I have applied your patch and run pgAdmin4. I have found following two >>> issue in the browser: >>> >>> - Found error while open Preferences dialog. Refer >>> Open_Preferences_Dialog.png >>> >>> =E2=80=8BThis error occurs even with the latest pull without changes.= =E2=80=8B >> >> >>> >>> - Set the preferences setting "Open in new browser tab" to True and >>> open the query tool. Refer "Open_In_New_Broswer.png". >>> >>> =E2=80=8BWill look into this.=E2=80=8B >> >> >>> I haven't review the code. >>> >>> On Thu, Jun 28, 2018 at 8:04 PM, Aditya Toshniwal < >>> aditya.toshniwal@enterprisedb.com> wrote: >>> >>>> Hi Hackers, >>>> >>>> Attached is the patch for making preferences realtime and applying >>>> without reseting the layout. Please note, the patch is only for one mo= dule >>>> - SQL Editor and is the first part for the RM. There are lot of change= s to >>>> be done to cover all and hence sending in parts. This will not affect/= break >>>> existing code. Further patches will cover other modules. >>>> >>>> Highlights of this patch include: >>>> - Changes will affect SQL Editors in Create dialog boxes, SQL tab of >>>> the main screen, Query tool, History entries in the query tool, Query = tool >>>> opened in New Tab/Window >>>> - All the components of SQL editor will refer to single source of >>>> preferences which is cached in the Browser object. All other redundant= ajax >>>> get preference calls are removed. >>>> - SQL editor will not refer template JS variables anymore, once all >>>> the references are removed the template variables will also be removed= . >>>> - Code refactoring wherever possible. >>>> - Covered JS test cases wherever possible. >>>> >>>> Request you to kindly review. >>>> >>>> -- >>>> Thanks and Regards, >>>> Aditya Toshniwal >>>> Software Engineer | EnterpriseDB Software Solutions | Pune >>>> "Don't Complain about Heat, Plant a tree" >>>> >>> >>> >>> >>> -- >>> *Akshay Joshi* >>> >>> *Sr. Software Architect * >>> >>> >>> >>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >>> >> >> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Software Engineer | EnterpriseDB Software Solutions | Pune >> "Don't Complain about Heat, Plant a tree" >> > > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" > --=20 Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --000000000000ee5fd3056fc9f05f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

On Fri, Jun 29, 2018 at 3:14 PM, Aditya Toshniwal &= lt;a= ditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,=C2=A0

=
Attached is the updated= patch.

This seems to work for = the most part, however I saw what seemed like odd behaviour. If I have 2 qu= ery tool windows open;

- Changing a preference fro= m the Preferences dialogue updates both query tools.

- Changing a preference from a Query Tool updates the Preferences dialog= ue.

- Changing a preference from a Query Tool does= *not* update the other Query Tool.

The last point= seems odd to me, though it also kinda makes sense to not have one query to= ol affect the other. The problem with that is that it could get quite confu= sing when they get out of sync. I think it would be better for a change in = one Query Tool to update the other(s).=C2=A0

What = do you think? Was this behaviour intentional?

(FYI= , in case this was a one-off bug, I was testing using "Auto Commit?&qu= ot;)
=C2=A0

On Fri, Jun 29, 2018 at 4:46 PM, Aditya Toshniwal &= lt;a= ditya.toshniwal@enterprisedb.com> wrote:
Hi Akshay,

On Fri, Jun 29, 2018 at 3:42 PM, Akshay Joshi <aks= hay.joshi@enterprisedb.com> wrote:
Hi Aditya=C2=A0

I have ap= plied your patch and run pgAdmin4. I have found following two issue in the = browser:
  • Found error while open Preferences dialog. Refer= Open_Preferences_Dialog.png
=
=E2=80=8BThis = error occurs even with the latest pull without changes.=E2=80=8B
=C2= =A0
    Set the preferences setting "Open in new browser tab" to True an= d open the query tool. Refer "Open_In_New_Broswer.png".
=
=E2=80=8BWill look into this.=E2=80=8B
=C2=A0
I haven't review the code.

On Thu, Jun 28, 2018 at 8:04 PM,= Aditya Toshniwal <aditya.toshniwal@enterprisedb.com<= /a>> wrote:
Hi Hackers,

Attached is the patch for making preferences realtime and appl= ying without reseting the layout. Please note, the patch is only for one mo= dule - SQL Editor and is the first part for the RM. There are lot of change= s to be done to cover all and hence sending in parts. This will not affect/= break existing code. Further patches will cover other modules.

Highlights of this patch include:
- Changes will affect SQL Editors in Create d= ialog boxes, SQL tab of the main screen, Query tool, History entries in the= query tool, Query tool opened in New Tab/Window
- All the components of SQL editor will refer to s= ingle source of preferences which is cached in the Browser object. All othe= r redundant ajax get preference calls are removed.
-=C2=A0SQL editor will not refer template JS v= ariables anymore, once all the references are removed the template variable= s will also be removed.
- Code refactoring wherever possible.
- Covered JS test cases wherever possible.

Request you to kindly review.

--
Thanks = and Regards,
<= font size=3D"2" color=3D"#000000" face=3D"verdana, sans-serif">Aditya Toshn= iwal
S= oftware Engineer |=C2=A0EnterpriseDB Software Solutions |=C2=A0Pune
=
"Don't Complain about Heat, Plant a tree"



--
Akshay Joshi
Sr. Software Architect

=
Phone: +91 20-30= 58-9517
Mobile: +91 976-788-8246



--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0Ente= rpriseDB Software Solutions |=C2=A0Pune=
"Don't Complain a= bout Heat, Plant a tree"



--
=
Dave Page=
Blog: http://= pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprised= b.com
The Enterprise PostgreSQL Company
--000000000000ee5fd3056fc9f05f--