MIME-Version: 1.0
In-Reply-To: 
 <CACCA4P27pHA9pq2Zo8zfEGMTTrrNLYTm3oz84uiN5dyUU1PLmw@mail.gmail.com>
References: 
 <CACCA4P27pHA9pq2Zo8zfEGMTTrrNLYTm3oz84uiN5dyUU1PLmw@mail.gmail.com>
Date: Mon, 18 Jan 2016 14:37:05 +0000
Message-ID: 
 <CA+OCxowKZ4a1N=9VDWHYz3pD7L9OUxfiyGH+PM9AbTOfPq8r=Q@mail.gmail.com>
Subject: Re: [pgadmin-support] [pgAdmin4] - Desktop runtime patch
From: Dave Page <dpage@pgadmin.org>
To: Neel Patel <neel.patel@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>,
 pgAdmin Support <pgadmin-support@postgresql.org>
Content-Type: text/plain; charset=UTF-8
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

Thanks Neel. I've committed this with various minor tweaks, mostly
around the tab button text and sizing.

Please test on Windows and Linux to ensure I didn't inadvertently
break anything. Mac seems fine here.

On Fri, Jan 15, 2016 at 2:06 PM, Neel Patel <neel.patel@enterprisedb.com> wrote:
> Hi,
>
> Please find the attached patch file for the below fix when pgAdmin 4 run in
> desktop mode.
>
> Added functionality to open different website link and load the website data
> to different tab. To achieve this, new customized QTabWidget and QWebView
> are added to render the data to WebView widget. All the widgets (New Tab,
> WebViewWinodw, and QToolButton) are added dynamically. QToolButton is used
> to traverse back and forward to web document opened in WebViewWindow.
>
> Introduced the New class called WebViewWindow which is derived from
> QWebView. Each tab of the QTabWidget contains the instance of WebViewWindow
> class. WebViewWindow class is useful to display the web document.
>
> Introduced New class called TabWindow which is derived from QTabWidget. This
> class is useful to achieve following functionality.
>   - Customize the close button of tabbar so that it can only be visible
> other then main pgAdmin 4 window.
>   - Enable/Disable the toolbutton added left side of tabbar  depending on
> the web history traversed by the user in WebViewWindow.
>   - Set the tooltip text of the tabbar depending on the title change event
> of WebViewWindow class.
>
> Modified the Qt project file to support the both the version of python 2 and
> python 3.
>
> Qt5 is recommended to test pgAdmin4 in dektop mode.
>
> Attached patch is applied and tested on Linux, do let us know for any
> comments/issues.
>
> Thanks,
> Neel Patel
>
>
> --
> Sent via pgadmin-support mailing list (pgadmin-support@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-support
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers