Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f3LEh-0007D0-10 for pgadmin-hackers@arkaria.postgresql.org; Tue, 03 Apr 2018 12:40:27 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1f3LEf-0008BY-Mb for pgadmin-hackers@arkaria.postgresql.org; Tue, 03 Apr 2018 12:40:25 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f3LEf-0008BO-8U for pgadmin-hackers@lists.postgresql.org; Tue, 03 Apr 2018 12:40:25 +0000 Received: from mail-wr0-x230.google.com ([2a00:1450:400c:c0c::230]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1f3LEb-0006rb-18 for pgadmin-hackers@postgresql.org; Tue, 03 Apr 2018 12:40:23 +0000 Received: by mail-wr0-x230.google.com with SMTP id l49so18600787wrl.4 for ; Tue, 03 Apr 2018 05:40:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=zFlXVo9baToId0qDSv201G6hyGTxu6t9u7uAgxfsm2I=; b=2P2j0/zWNXKlvHBhCuQ/XQWIDkyAD9IjB90PKHINc0JuVMohgK+lrIZD8Ij0GNbCR9 t5ZLUQlp+gcZySlL7RIhiszxzaBvPtm5tSZ6CwTjVt3CSQK0qLWpsk7jbfDwsTRWDjzv QKKklv47tuc66OoO+xL3e3tXMyMXkugGpsCtZe1E3b0QJt+kvMmWTM1JAhf/DHM/CV2M b51BUXZAL41QSUlX0Uq2lapVl5dTSD9dSz8DTj2AK/MOfr+dMDAxtEW+evSuQimMq2Km dzwNOJbC6NJIQMrqlaaGAaBnOSimhmDIlCgfGnQgQDQgOOoU92BwD+zKUL7zg0eyzV1Z oGoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=zFlXVo9baToId0qDSv201G6hyGTxu6t9u7uAgxfsm2I=; b=Jj1janmdTzOX0tbstNbLQXuRMK8RKkRJ0NUl1pSC07KALBSOLK/i94/S+KmPO8YN5E FF9trx3+A/kX0n1jMY3lS0azXFfunA9ntTdW9wDWWw7KSXoIRc10MGyDGt3Jk7YaAIM9 71ln70bTad/sM3fJ9Ex0T5Rc3WkLzJJMIxuRuLaUkCupftA5M60g/IA6QZ7s3vBvxntW CY9HSyUSoRdJaZluH2IqklJBW+RIaDAQo69P6Fm5lM3UclrxpSinPpI2sLa/0OCDautJ mpxHHh95JXeXWRzNyXRno+fsx9bKUP1TVb9bMzYUouc/RERtEmIv/oOgIyVmfxrYJip3 iF8Q== X-Gm-Message-State: AElRT7EBQlLOpe9ogc/APudQm+7MCC0fsDF4ub7K4koXsv3Kb7rVh23K t5Do3D934gdVGfqKQQ0bW2eMgu12mqbXA2I1EuC1AA== X-Google-Smtp-Source: AIpwx4/t2enLfwzPcmEkuJ0ve6Ky5S1XMNN4KaZD7ia+g2PQkGrVne9anVVeZ025NVpXO8NU6n2rFrF7gfikIAENx2E= X-Received: by 10.223.196.74 with SMTP id a10mr8946449wrg.190.1522759219442; Tue, 03 Apr 2018 05:40:19 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.69.220 with HTTP; Tue, 3 Apr 2018 05:40:18 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Tue, 3 Apr 2018 13:40:18 +0100 Message-ID: Subject: Re: Bug #3083 fix To: Joao De Almeida Pereira Cc: Akshay Joshi , Neethu Mariya Joy , pgadmin-hackers Content-Type: multipart/alternative; boundary="089e082813045a8c3e0568f1021a" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --089e082813045a8c3e0568f1021a Content-Type: text/plain; charset="UTF-8" Argh, managed to send before I finished typing... On Tue, Apr 3, 2018 at 1:38 PM, Dave Page wrote: > Hi > > On Thu, Mar 29, 2018 at 4:29 PM, Joao De Almeida Pereira < > jdealmeidapereira@pivotal.io> wrote: > >> Hi Dave, >> That looks like in the surrounding area of the change. We run our >> pipeline and everything was green. >> Can you provide more details, which python version are you using? OS? >> > > That was on my travel laptop, which is macOS Sierra with the Apple > supplied Python 2.7. > > Interestingly, I'm on my dev laptop today (same OS and Python) and it's > working just fine. The difference is that the travel machine is a 12" > Macbook, whilst the dev machine is > a 15" MacBook Pro with 2 24" external monitors. That makes me wonder if the small screen size is causing a problem with this test, something we have seen before. > > >> >> Thanks >> Joao >> >> On Thu, Mar 29, 2018 at 9:03 AM Dave Page wrote: >> >>> Hi >>> >>> On Wed, Mar 28, 2018 at 7:06 PM, Joao De Almeida Pereira < >>> jdealmeidapereira@pivotal.io> wrote: >>> >>>> Hey Akshay and Neethu >>>> >>>> We refactored the patch to add tests for the resize feature. We were >>>> able to write test cases for the drag event by using spies and setting the >>>> rect dimensions. In cases like this, we can just test some components in >>>> order to have enough confidence in the code. So we isolated the function >>>> that implements the behavior of this feature and tested that it was >>>> performing as expected. >>>> >>>> We ran the patch through the pipelines and all of the tests passed. >>>> >>> >>> I'm consistently seeing the feature test failure below with this patch >>> applied: >>> >>> ====================================================================== >>> FAIL: runTest (pgadmin.feature_tests.view_da >>> ta_dml_queries.CheckForViewDataTest) >>> Validate Insert, Update operations in View/Edit data with given test data >>> ---------------------------------------------------------------------- >>> Traceback (most recent call last): >>> File "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py", >>> line 125, in runTest >>> self._verify_row_data(True) >>> File "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py", >>> line 325, in _verify_row_data >>> self.assertEquals(cells[idx], config_data[str(idx)][1]) >>> AssertionError: u'[null]' != u'1' >>> - [null] >>> + 1 >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --089e082813045a8c3e0568f1021a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Argh, managed to send before I finished typing...

On Tue, Apr 3, 2018 at= 1:38 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

=
On Thu, Mar 29, 2018 at 4:29 PM= , Joao De Almeida Pereira <jdealmeidapereira@pivotal.io>= wrote:
Hi Dave,<= div>That looks like in the surrounding area of the change. We run our pipel= ine and everything was green.
Can you provide more details, which= python version are you using? OS?

<= /span>
That was on my travel laptop, which is macOS Sierra with the App= le supplied Python 2.7.

Interestingly, I'm on = my dev laptop today (same OS and Python) and it's working just fine. Th= e difference is that the travel machine is a 12" Macbook, whilst the d= ev machine is=C2=A0

a 15" MacBook Pro with 2 24" external monitors. That makes me wo= nder if the small screen size is causing a problem with this test, somethin= g we have seen before.
=C2=A0
=C2=A0

Thanks
Joao

On Thu, Mar 29, 2018 a= t 9:03 AM Dave Page <dpage@pgadmin.org> wrote:
Hi

On Wed, Mar 28, 2018 at 7:06 PM, Joao De Almeida Pere= ira <jdealmeidapereira@pivotal.io> wrote:
Hey Akshay a= nd Neethu

We refactored the patch to add tests for the r= esize feature.=C2=A0 We were able to write test cases for the drag event by= using spies and setting the rect dimensions.=C2=A0 In cases like this, we = can just test some components in order to have enough confidence in the cod= e.=C2=A0 So we isolated the function that implements the behavior of this f= eature and tested that it was performing as expected.

<= div>We ran the patch through the pipelines and all of the tests passed.

I'm consistently= seeing the feature test failure below with this patch applied:
<= br>
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D
FAIL: runTest (pgadmin.feature_tests.view_data_dml_queries.CheckForViewDataTest)
Validate Insert, Upd= ate operations in View/Edit data with given test data
-----------= -----------------------------------------------------------
=
Traceback (most recent call last):
=C2=A0 File "/Users/= dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_querie= s.py", line 125, in runTest
=C2=A0 =C2=A0 self._verify_row_d= ata(True)
=C2=A0 File "/Users/dpage/git/pgadmin4/web/pg= admin/feature_tests/view_data_dml_queries.py", line 325, in _veri= fy_row_data
=C2=A0 =C2=A0 self.assertEquals(cells[idx], config_da= ta[str(idx)][1])
AssertionError: u'[null]' !=3D u'1&#= 39;
- [null]
+ 1


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnak= e

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Compa= ny



--
Dave Page
Blog: http://pgsnake.blogspot.= com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The = Enterprise PostgreSQL Company



--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--089e082813045a8c3e0568f1021a--