public inbox for [email protected]  
help / color / mirror / Atom feed
From: Dave Page <[email protected]>
To: Murtuza Zabuawala <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][PATCH] To fix graphical explain for Insert/Update/Delete quries
Date: Mon, 6 Feb 2017 10:01:43 +0000
Message-ID: <CA+OCxowNqi4vk1bwbxVBq=PoW+B1-mNJ-JOF_w5kv56_AYZirg@mail.gmail.com> (raw)
In-Reply-To: <CAKKotZQmA2OEFtTYpeSADrvPb89XDOwyniwfmdu9pg0ChA+zxg@mail.gmail.com>
References: <CAKKotZQmA2OEFtTYpeSADrvPb89XDOwyniwfmdu9pg0ChA+zxg@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hi

On Mon, Feb 6, 2017 at 5:40 AM, Murtuza Zabuawala
<[email protected]> wrote:
> Hi,
>
> PFA patch to fix the issue with Graphical Explain plan functionality which
> was breaking for INSERT/UPDATE/DELETE explain plans.
> RM#2133
>
> Issue: It was due to typo in imageMapper object.
>
> Please review.

It's a definite improvement, but still isn't quite right - see the
attached screenshot for example; the node name should be pem.agent
shouldn't it (or 'Delete' or 'Delete from pem.agent')?


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Attachments:

  [image/png] Screen Shot 2017-02-06 at 09.57.38.png (27.1K, 2-Screen%20Shot%202017-02-06%20at%2009.57.38.png)
  download | view image

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin4][PATCH] To fix graphical explain for Insert/Update/Delete quries
  In-Reply-To: <CA+OCxowNqi4vk1bwbxVBq=PoW+B1-mNJ-JOF_w5kv56_AYZirg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox