Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bNzWq-0007z1-H4 for pgadmin-hackers@arkaria.postgresql.org; Fri, 15 Jul 2016 09:35:28 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bNzWq-0006FL-4Y for pgadmin-hackers@arkaria.postgresql.org; Fri, 15 Jul 2016 09:35:28 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bNzWp-0006FF-Al for pgadmin-hackers@postgresql.org; Fri, 15 Jul 2016 09:35:27 +0000 Received: from mail-io0-x22c.google.com ([2607:f8b0:4001:c06::22c]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bNzWl-0002yn-Uo for pgadmin-hackers@postgresql.org; Fri, 15 Jul 2016 09:35:26 +0000 Received: by mail-io0-x22c.google.com with SMTP id m101so99218372ioi.2 for ; Fri, 15 Jul 2016 02:35:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=EsClljms4CoeZnl2Vfsl6dOQiyEFBuUPpQvFIMFv9xI=; b=j1b1T/pW4TEjt06TNfNhwJvIPRNdHcf2AmEwHvTECCBPuaeGXbk7biVNinQb0ef4MC UtBbzFCfnpOtaMWycByZkiiA5raupW1nu5LkG9DSQ6cEfELfwEMRq4VSFCnXDQEnvgq6 4mmNk62xvy1Xtqqp5ONnMnc2gORKhyQhC1qOgtpsDXTbkk3zan5xcjyYmKEI/4ZXit2z MDFfzXB8UZwjv2WKXr5p9Nsd/wSW/UWNW2WMoHqtJEWdXlGq9HMe6C4j2g/7MMd5dQYc yghn7o0Kw7EFRb70RQQh8Tco1a1dQGHrDoRvl4lsro/OUOMv3siPAsrNXqQJuNyDVR1L 5kMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=EsClljms4CoeZnl2Vfsl6dOQiyEFBuUPpQvFIMFv9xI=; b=QoXxM2h7X22rMZF/7Gxxcg2phCjnU5n9Uqbu8zkme5s8sIHTToc6519rX/gC6BN1/1 XKAbAf3je1uxfnl501zn0fpmqzFXP2PrXbtfpwyMTt2Z/bUiayi9EH6mGw61Rcrg+Nk0 Dvbg7FWkKdTEsDf/ggZqAYwI40WffI/y+yeVcPeX/B0vK5y4V7Ntpc6BazLSlYn7x6TN IhOk8MxdcJJYQWnBDygZpyAtPF//u4STsUF58hrbqNg51lHTORa7oxYooh1eybiROgnB W+jbFQ3ch3ngiJgevm8LV5C01oN82YynwC2NAXAidaX59N1wk01tqv61fBYQDxVrIdjT vAkg== X-Gm-Message-State: ALyK8tJ69drKr6jYw5vbkDGrLPKdmXyjDEm9fO57EOi3vsE/rLc5rtotd+AhlD+kSEVjPJZuUDVBtN/SXG+jtQ== X-Received: by 10.107.205.129 with SMTP id d123mr20269956iog.70.1468575322688; Fri, 15 Jul 2016 02:35:22 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.208.97 with HTTP; Fri, 15 Jul 2016 02:35:21 -0700 (PDT) In-Reply-To: References: <70470862-26C1-4281-838E-F2C755E5C645@enterprisedb.com> <671D8CC8-C1D8-4CC1-BC32-431C496C4C5C@enterprisedb.com> From: Dave Page Date: Fri, 15 Jul 2016 10:35:21 +0100 Message-ID: Subject: Re: PATCH: Fix the issue for saving query output as CSV To: Harshal Dhumal Cc: Akshay Joshi , Murtuza Zabuawala , pgadmin-hackers Content-Type: multipart/alternative; boundary=94eb2c18a9c26f648e0537a95656 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --94eb2c18a9c26f648e0537a95656 Content-Type: text/plain; charset=UTF-8 Hi This seems to break downloads in the runtime. It works in Safari and Chrome, but in the runtime the suggested filename is "6980287?query=SELECT+*+FROM+pem.probe_column%0AORDER+BY+id%0AASC+&filename=probe_column.csv", and after changing that and hitting OK, the "Downloading file" dialogue is shown indefinitely. On Wed, Jul 13, 2016 at 1:16 PM, Harshal Dhumal < harshal.dhumal@enterprisedb.com> wrote: > Hi, > > PFA rebased patch for RM1405 > > -- > *Harshal Dhumal* > *Software Engineer* > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Wed, Jul 13, 2016 at 5:15 PM, Harshal Dhumal < > harshal.dhumal@enterprisedb.com> wrote: > >> Yes sure >> >> -- >> *Harshal Dhumal* >> *Software Engineer* >> >> EnterpriseDB India: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> On Wed, Jul 13, 2016 at 5:10 PM, Dave Page wrote: >> >>> Hi >>> >>> Can you rebase this please? >>> >>> Thanks. >>> >>> On Mon, Jul 11, 2016 at 9:16 AM, Harshal Dhumal < >>> harshal.dhumal@enterprisedb.com> wrote: >>> >>>> Hi, >>>> >>>> PFA patch for RM1405. Also to allow download in runtime we will still >>>> need patch >>>> >>>> sent by Neel. >>>> >>>> Changes: To download query result to CSV directly from server and not >>>> to use download attr. of anchor tag () as it's not support by all of >>>> major browsers (e.g. Safari). >>>> Also it's not feasible to load data in html to download if result set >>>> of query is very huge (in GBs). >>>> >>>> >>>> >>>> >>>> >>>> -- >>>> *Harshal Dhumal* >>>> *Software Engineer* >>>> >>>> EnterpriseDB India: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>>> On Wed, Jun 29, 2016 at 4:53 PM, Akshay Joshi < >>>> akshay.joshi@enterprisedb.com> wrote: >>>> >>>>> >>>>> >>>>> On Wed, Jun 29, 2016 at 3:52 PM, Murtuza Zabuawala >>>> enterprisedb.com> wrote: >>>>> >>>>>> Yes, It will not work in runtime as well but I think Neel is working >>>>>> for fix in run time for this issue, We might able to fix it in run time but >>>>>> issue persists in Safari unless they add support in browser itself. >>>>>> >>>>>> https://webkit.org/status/#feature-download-attribute >>>>>> >>>>>> >>>>>> > On 29-Jun-2016, at 3:40 pm, Dave Page wrote: >>>>>> > >>>>>> > On Tue, Jun 28, 2016 at 10:33 AM, Murtuza Zabuawala >>>>>> > wrote: >>>>>> >> Yes Dave, I agree that downloading files has been supported in >>>>>> browsers since long . >>>>>> >> >>>>>> >> But in general we send request & then receives files from web >>>>>> server but in our case we are fetching our data from Backbone models & then >>>>>> converting it to CSV format for downloading as a file at client side in >>>>>> browser itself. >>>>>> > >>>>>> > If Safari doesn't support client-side saving of files, then I have >>>>>> to >>>>>> > wonder if our runtime will either - both are webkit based. >>>>>> > >>>>>> > So I guess the next question to ask is; why don't we just generate >>>>>> the >>>>>> > CSV on the server side? >>>>>> > >>>>>> >>>>>> @Akshay, >>>>>> Can you please suggest on above? >>>>>> >>>>> >>>>> As we already have complete data in backgrid's full collection, so >>>>> I have used it instead of fetching it again. >>>>> >>>>>> >>>>>> > -- >>>>>> > Dave Page >>>>>> > Blog: http://pgsnake.blogspot.com >>>>>> > Twitter: @pgsnake >>>>>> > >>>>>> > EnterpriseDB UK: http://www.enterprisedb.com >>>>>> > The Enterprise PostgreSQL Company >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org >>>>>> ) >>>>>> To make changes to your subscription: >>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> *Akshay Joshi* >>>>> *Principal Software Engineer * >>>>> >>>>> >>>>> >>>>> *Phone: +91 20-3058-9517 <%2B91%2020-3058-9517>Mobile: +91 >>>>> 976-788-8246* >>>>> >>>> >>>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --94eb2c18a9c26f648e0537a95656 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi

This seems to break downloads in the= runtime. It works in Safari and Chrome, but in the runtime the suggested f= ilename is "6980287?query=3DSELECT+*+FROM+pem.probe_column%0AORDER+BY+= id%0AASC+&filename=3Dprobe_column.csv", and after changing that an= d hitting OK, the "Downloading file" dialogue is shown indefinite= ly.

On= Wed, Jul 13, 2016 at 1:16 PM, Harshal Dhumal <harshal.dhuma= l@enterprisedb.com> wrote:
=
Hi,

PFA rebased patch for RM1405

--=C2=A0
Harshal Dhumal
Softw= are Engineer

EnterpriseDB India:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jul 13= , 2016 at 5:15 PM, Harshal Dhumal <harshal.dhumal@enterprise= db.com> wrote:
Yes sure

=
=
--=C2=A0
Harshal Dhumal
Software Engineer

EnterpriseDB India:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jul 13, 2016 at 5:1= 0 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

Can you rebase this= please?

Thanks.

On Mon, Jul 11, 2016 at 9:1= 6 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com>= ; wrote:
Hi,

PFA patch for RM1405. Also to allow download in runtime = we will still need patch sent by Neel.

Changes: To download = query result to CSV directly from server and not to use download attr. of a= nchor tag (<a>) as it's not support by all of major browsers (e.g= . Safari).
Also it's not feasible to load data in html to download i= f result set of query is very huge (in GBs).<= br>




--= =C2=A0
Harshal Dhumal
Software Engineer

EnterpriseDB India:=C2=A0http://www.enterprisedb.com
The Ente= rprise PostgreSQL Company

On Wed, Jun 29, 2016 at 4:53 PM, Akshay Josh= i <akshay.joshi@enterprisedb.com> wrote:

=
On Wed, Jun 29, 2016 at 3:52 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wro= te:
Yes, It will not work in runtime as w= ell but I think Neel is working for fix in run time for this issue, We migh= t able to fix it in run time but issue persists in Safari unless they add s= upport in browser itself.

https://webkit.org/status/#feature-download-att= ribute


> On 29-Jun-2016, at 3:40 pm, Dave Page <dpage@pgadmin.org> wrote:
>
> On Tue, Jun 28, 2016 at 10:33 AM, Murtuza Zabuawala
> <murtuza.zabuawala@enterprisedb.com> wrote:
>> Yes Dave, I agree that downloading files has been supported in bro= wsers since long .
>>
>> But in general we send request & then receives files from web = server but in our case we are fetching our data from Backbone models & = then converting it to CSV format for downloading as a file at client side i= n browser itself.
>
> If Safari doesn't support client-side saving of files, then I have= to
> wonder if our runtime will either - both are webkit based.
>
> So I guess the next question to ask is; why don't we just generate= the
> CSV on the server side?
>

@Akshay,
Can you please suggest on above?

=C2=A0 =C2=A0As we already have complete data in backgrid's full collection, so I have used it instead of fetching it again. =C2=A0 = =C2=A0

> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company



--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=


--
Akshay Joshi
Principal Software Enginee= r=C2=A0

=

+91 20-3058-9517
Mobile: +91 976-788-8246




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @= pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL= Company





--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--94eb2c18a9c26f648e0537a95656--