public inbox for [email protected]  

help / color / mirror / Atom feed
From: Dave Page <[email protected]>
To: Surinder Kumar <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][Patch]: SYNONYM issue if use all special characters as name
Date: Sat, 15 Oct 2016 00:02:16 +0100
Message-ID: <CA+OCxowOu2rWz7Vy9Q4Z8w3H_7ppm4vV=aFk=tbGT71vo+Bzzw@mail.gmail.com> (raw)
In-Reply-To: <CAM5-9D-zLCt6bBz1UvNpbd9R3ajNrxZNmxH=5j2QwZs0J1fQQg@mail.gmail.com>
References: <CAM5-9D-zLCt6bBz1UvNpbd9R3ajNrxZNmxH=5j2QwZs0J1fQQg@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Thanks, patch applied.

On Friday, October 14, 2016, Surinder Kumar <[email protected]>
wrote:

> Hi
>
> *Issue:*
> If synonym name contains special characters, the request url is be '404
> not found'.
> i.e. It doesn't hit at 'sql' method of synonym.
>
> *Solution:*
> If URL has an identifier containing slash character '/' into the URI, then
> set param type to path.
> like /<path: int>.
> Because if param name contains '/' in synonym name, it gets confused and
> wrong route is formed.
> Reference:- http://flask.pocoo.org/snippets/76/
>
> Please find attached patch and review.
>
> Thanks,
> Surinder Kumar
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


view thread (2+ messages)

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin4][Patch]: SYNONYM issue if use all special characters as name
  In-Reply-To: <CA+OCxowOu2rWz7Vy9Q4Z8w3H_7ppm4vV=aFk=tbGT71vo+Bzzw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox