Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f3eMA-0006r5-Sp for pgadmin-hackers@arkaria.postgresql.org; Wed, 04 Apr 2018 09:05:27 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1f3eM9-0008PP-Ly for pgadmin-hackers@arkaria.postgresql.org; Wed, 04 Apr 2018 09:05:25 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f3eM9-0008PE-F1 for pgadmin-hackers@lists.postgresql.org; Wed, 04 Apr 2018 09:05:25 +0000 Received: from mail-wm0-x230.google.com ([2a00:1450:400c:c09::230]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1f3eM2-0000PP-1x for pgadmin-hackers@postgresql.org; Wed, 04 Apr 2018 09:05:24 +0000 Received: by mail-wm0-x230.google.com with SMTP id r191so8200189wmg.4 for ; Wed, 04 Apr 2018 02:05:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=OHLj2WI2ouRIO24UNjD1lDuy3mgo9hz2nQNlB5z6l4M=; b=fzTKFBgxCVYWUJe6qDoCRPeaD4xUa2KhcGeI580ZyaKpSBnSwVkP7wDLfjJhjf9/Qo xIgRjgSOH2FV8uSVesgd9uehviNyefLJZiB9Y8KaVx0vrVCIT0vkOLKM4OZjgfI2InmF upj6vXy9eS05vbzP64/sB3GCl36vezuFaK6osNnY+TrI1eJC5F0ds1uAm22hmSyHbSFj gnvft7ixOJgldFJw7UrTbQApqmZ3h/7U2W97sSHmFosGnyRxfa1YQm36bCaWdImVBWLP /Slx+VgJGQFsWusbNmDBzeOA21BI3n9bupHw/nCuYsgBuHO7EXqXF0HdDa+aauPnX2x1 nDpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=OHLj2WI2ouRIO24UNjD1lDuy3mgo9hz2nQNlB5z6l4M=; b=F0Rvt9tioRjqi7JTEkMkfE+/j8yKw2qUVDZOHbf4TldIeJQHe74XYaVBNr+mTk5TUl z+t2JXhDzju4Zpi/yZ6XBjth7KoLltO4v3W9P1bXDVA/Dd5zzT5MnZYuV+ekagrge/5+ auuAS3jzwnRzV0KwfWUXMvTRqemNSjPS8RWcult23bo1CIKepelgSo/ujCswc9Tld/P0 dH4clnAJ7ZQqJfZkisYubjnWvozWfJuVRp5lx1VnUtJq+vm7MQSMSRjHdoaGJ9A/8XVh 95CMemQOhBTGB3i+BdSb9YMgSaXeZBvWl64+NveDTogApIQlOJjbrQZqC25FVj8htaT6 QafA== X-Gm-Message-State: ALQs6tDcLz+/3OcJ0wBMT2QKSEW+x05TcFrE3dkqOkPOHuvg8COGD35G 5cOMLngHPLYNO/9/AkecANuUUdhUJEmZCTsX7L4sSA== X-Google-Smtp-Source: AIpwx4831f6lSi0PJINZFKvEB32ieR8KzfAQkUBP1ju4KQOlErsE7mRBZdRZZ2jkpAf/vIT9CBeRZt7SmsS8QPOBaJY= X-Received: by 10.28.98.69 with SMTP id w66mr7284652wmb.64.1522832717269; Wed, 04 Apr 2018 02:05:17 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.69.220 with HTTP; Wed, 4 Apr 2018 02:05:16 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Wed, 4 Apr 2018 10:05:16 +0100 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM #1978 - Add an option to allow user to disable alertifyjs and acitree animations To: Khushboo Vashi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="001a1148e3d22a5b8d0569021f1d" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a1148e3d22a5b8d0569021f1d Content-Type: text/plain; charset="UTF-8" Thanks, applied. On Wed, Apr 4, 2018 at 6:26 AM, Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > Hi Dave, > > On Tue, Apr 3, 2018 at 7:23 PM, Dave Page wrote: > >> Hi >> >> Thanks - I've committed this, however, could you send me an updated >> screenshot for the docs? The one you sent was a different size and colour >> depth from the others (and looked like a different scale). >> >> Please find the attached patch for the same. > >> On Tue, Apr 3, 2018 at 10:42 AM, Khushboo Vashi < >> khushboo.vashi@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find the attached updated patch. >>> >>> On Thu, Mar 29, 2018 at 6:54 PM, Dave Page wrote: >>> >>>> Hi >>>> >>>> On Thu, Mar 29, 2018 at 1:51 PM, Khushboo Vashi < >>>> khushboo.vashi@enterprisedb.com> wrote: >>>> >>>>> >>>>> >>>>> On Mon, Mar 26, 2018 at 6:07 PM, Dave Page wrote: >>>>> >>>>>> Hi >>>>>> >>>>>> On Mon, Mar 26, 2018 at 7:23 AM, Khushboo Vashi < >>>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi, >>>>>>> >>>>>>> Please find the attached patch to fix RM #1978: Add an option to >>>>>>> allow user to disable alertifyjs and acitree animations. >>>>>>> >>>>>> >>>>>> I think these really need to be per-user settings, not >>>>>> per-installation.. Whether or not animations are shown is really a matter >>>>>> of personal taste and circumstance. >>>>>> >>>>>> Right, it should be per-user settings. Please find the attached >>>>> updated patch. >>>>> >>>> >>>> I found some issues I'm afraid: >>>> >>>> - The label "Enable dialogues/notifications animation?" should read >>>> "Enable dialogue/notification animation?" >>>> >>>> Changed. >>> >>>> - Disabling treeview animation only seems to affect the main browser >>>> treeview, and not others in the application (e.g. the one on the >>>> Preferences panel). >>>> >>>> Fixed >>> >>>> - After disabling dialogue/notification animations, I cannot re-enable >>>> notification animations. If I flip the switch back on, dialogue animations >>>> immediately start working again, but notification animations don't even >>>> work following a reload. >>>> >>>> Fixed. >>> >>>> Thanks. >>>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EnterpriseDB UK: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>> >>> Thanks, >>> Khushboo >>> >> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > Thanks, > Khushboo > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a1148e3d22a5b8d0569021f1d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, applied.

On Wed, Apr 4, 2018 at 6:26 AM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi Dave,

On Tue, Apr 3, 2018 a= t 7:23 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

Thanks - I've committed this, however, could you send me an = updated screenshot for the docs? The one you sent was a different size and = colour depth from the others (and looked like a different scale).

Please find the attached patch for the same.=C2=A0
On Tue, Apr 3, 2018 at 10:42 AM, Khushboo = Vashi <khushboo.vashi@enterprisedb.com> w= rote:
Hi,

=
Please find the attached updated patch.
=
On Thu, Mar 29, 2018 at 6:54 PM, Dave = Page <dpage@pgadmin.org> wrote:
Hi

On Thu, Mar 29, 2018 at 1:51 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:


On Mon, Mar 26, 2018 at 6:07 PM, Dave Page <dpage@pgadmin.org>= ; wrote:
Hi

= On Mon, Mar 26, 2018 at 7:23 AM, Khushboo Vashi <= ;khush= boo.vashi@enterprisedb.com> wrote:
Hi,

Pl= ease find the attached patch to fix RM #1978: Add an option to allow user t= o disable alertifyjs and acitree animations.
<= br>
I think these really need to be per-user settings, not= per-installation.. Whether or not animations are shown is really a matter = of personal taste and circumstance.

<= /blockquote>
Right, it should be per-user settings.=C2=A0 Please= find the attached updated patch.=C2=A0

I found some issues I'm afraid:
<= br>
- The label "Enable dialogues/notifications animation?&q= uot; should read "Enable dialogue/notification animation?"
<= div>
Changed.=C2=A0
- Disabling treeview ani= mation only seems to affect the main browser treeview, and not others in th= e application (e.g. the one on the Preferences panel).

=
Fixed=C2=A0
=C2=A0- After disabling dialogue/notifica= tion animations, I cannot re-enable notification animations. If I flip the = switch back on, dialogue animations immediately start working again, but no= tification animations don't even work following a reload.

Fixed.=C2=A0
Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnak= e

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Compa= ny

Thanks= ,
Khushboo



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsn= ake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Co= mpany

Thanks,
Khushboo



--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--001a1148e3d22a5b8d0569021f1d--