Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bQG1C-0004GU-L4 for pgadmin-hackers@arkaria.postgresql.org; Thu, 21 Jul 2016 15:36:10 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bQG1C-00078F-8S for pgadmin-hackers@arkaria.postgresql.org; Thu, 21 Jul 2016 15:36:10 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bQG1B-000787-S4 for pgadmin-hackers@postgresql.org; Thu, 21 Jul 2016 15:36:10 +0000 Received: from mail-io0-x22b.google.com ([2607:f8b0:4001:c06::22b]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bQG18-00057k-TG for pgadmin-hackers@postgresql.org; Thu, 21 Jul 2016 15:36:08 +0000 Received: by mail-io0-x22b.google.com with SMTP id b62so79321283iod.3 for ; Thu, 21 Jul 2016 08:36:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=SlXCVsev0+emg68CnLplDnF3o2v713BrKkrdFDsohd8=; b=U1w+/VRjzPoM9/xFcrCV8A1cQ5TfP3aHeQbq2JIVXK6HR9gEEny6DvZ9fBkBpJlrZS rJ0eGPljO4kNLV2R2Ezr5eu8d37c4ATAqW9bQ98/FsKRHCuFsp74OR0VNzLBWGB+F46c 29+lYxPjS+Wj5fWHRSOO+H3wNj2FY8dU++i7tQPEH4aPVlEMOBJRlPD0bNnbya36Qx0K HMkpNPKSy7Gab6gekoxZODRSpU1OlV1i3YRqTmKvvGEBnxDJSbs7cjd/cayNElbwnBV8 EDMbU+jUNwxfZWoH/p4UNFBls6GtolzMcK9Sr/lPrBr54+RZN0KI3LSyyHpulJvkKKhm /Lfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=SlXCVsev0+emg68CnLplDnF3o2v713BrKkrdFDsohd8=; b=LQoTf2Odtm9J/LPWdDrMBBNvOo9ivc8w/sie2a15CS2/dQ29yF+7hzgwGxcOz6jm65 yzlo3MVgnID6ifrYQbweUy2Vfr6yWPAREdmxCzY/1UE2n8G6nS7flDjYve/4fN7+tGvG 5cRn7lDpBqhQwwNMR7qYNUSbqwDP47kLe8NzLVRyTPiu9PnklwLfp/GyqTs+3M3WoPTN ED7YBdUa3NJomlCO/N2UQjt1BcZGgiItEXjXPTaWiqsSuRrwpEgtU04d+i9mCqrvCeN5 6dONqFjeFyEZvQE74HUNwZup/WbPREn3CPLxG1bPfcm9AVPYxb6LVCShQbKCRQ8OiIC0 puxw== X-Gm-Message-State: ALyK8tJBHTBezs67qIOpi3peh4hZ9XEVtfE2ZX1MgIewiPaO3Gwpo9kMwduOCteGwcyuyHK4b6ZU3End6uwVJw== X-Received: by 10.107.183.85 with SMTP id h82mr52688189iof.63.1469115366067; Thu, 21 Jul 2016 08:36:06 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.208.97 with HTTP; Thu, 21 Jul 2016 08:36:05 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Thu, 21 Jul 2016 16:36:05 +0100 Message-ID: Subject: Re: PATCH: To fix adding/updating Security Labels in various nodes (pgAdmin4) To: Murtuza Zabuawala Cc: pgadmin-hackers Content-Type: text/plain; charset=UTF-8 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org Hi On Tue, Jul 19, 2016 at 3:15 PM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue where user was not able to add/update/drop > security labels in various nodes. > (RM#1457) Thanks, applied (with a minor fix to s/LABLE/LABEL/g) It does need one minor tweak though - the provider field should be optional; see https://www.postgresql.org/docs/9.4/static/sql-security-label.html. Can you fix that when you get a minute please? -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers