MIME-Version: 1.0
In-Reply-To: 
 <CAM5-9D880YxpQeQj7V1uWAP_bg8GNJiQ9vQf=fm0EziiCSW+rw@mail.gmail.com>
References: 
 <CAM5-9D880YxpQeQj7V1uWAP_bg8GNJiQ9vQf=fm0EziiCSW+rw@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Mon, 18 Jul 2016 09:50:57 +0100
Message-ID: 
 <CA+OCxowTD3oWyjvAmUxahF9-aneWD67oL54LnwxOgwNVYrvLeA@mail.gmail.com>
Subject: Re: [pgAdmin4][Patch]: RM#1462- AJAX request do not
 get fired second time
To: Surinder Kumar <surinder.kumar@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: text/plain; charset=UTF-8
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

Hi

On Mon, Jul 18, 2016 at 8:34 AM, Surinder Kumar
<surinder.kumar@enterprisedb.com> wrote:
> Hi
>
> Please find attached patch for the fix:
> Issue:
> This issue is regression of one of the flickering issue of RM#1242.
> "Aside from displaying/hiding the spinner, panes should have their content
> refreshed until and unless the new data differs from the previous, to reduce
> flicker"
>
> Solution:
> Along with caching the node node, we should also keep track of the previous
> node clicked.
> Fetch new data iff previous node and current node clicked differs.

This doesn't fix the issue for me. My test case:

1) Select the SQL tab
2) Click a schema, and the SQL is displayed.
3) Click Schemas, and "-- No SQL could be generated for the selected
object." is displayed.
4) Click the same schema as in step 2 again, and "-- No SQL could be
generated for the selected object." remains displayed.

Note that clicking any other schema in step 4 works fine.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers