Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ewQz4-0005Zo-VL for pgadmin-hackers@arkaria.postgresql.org; Thu, 15 Mar 2018 11:23:47 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ewQz3-0005hh-3P for pgadmin-hackers@arkaria.postgresql.org; Thu, 15 Mar 2018 11:23:45 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ewQz2-0005hX-Tz for pgadmin-hackers@lists.postgresql.org; Thu, 15 Mar 2018 11:23:44 +0000 Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ewQyz-0000vT-Bm for pgadmin-hackers@postgresql.org; Thu, 15 Mar 2018 11:23:44 +0000 Received: by mail-wm0-x243.google.com with SMTP id w128so9783801wmw.0 for ; Thu, 15 Mar 2018 04:23:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=IhteMBJJlW4pdUTsJJMeq2BWwKda1/tVpLXTjhT9GiU=; b=F7L47rI+8hzjxeBNxedzISnLwqWdT42k51FhGwnmxRyyKF642IeJ4qk82RyPXdLMZW OWjpeDp4FeT18XwPq+lsZEFxnrAxB2yI0qnwtYozngz3Zno1adKXohJJAcf+FCoQKCcw 2OfAiaFJQowgmMpqYv4LfLRMrYwgGnfSE7VkcfI6sLyaBhMPZyYeuuPDKHNItRjF8gYi LCMz8zbmmm2+M+FN8psd/K/WW/nawcBPHcSXSP9io5hKB5hr4Gs+5zujhKRolbH2ERZ8 g8VGQ8r21RkfVoF4HDZNgEF8luOqfBCn60rUmNjHfEZSOH9aV3zQYFxW2ou9kBGjroTt P6/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=IhteMBJJlW4pdUTsJJMeq2BWwKda1/tVpLXTjhT9GiU=; b=Pz8mRu3eU/KT4gHNqAINgNcjY7I7tSyYGO7uEbir3E0MLdmc8N9khcUrIemzedFYHy troXTQzWQSrWWMpJYNlIz9CBRdkaPuCbJeYoaEXFPlAm72COxHKPlu5Rbb5acwkKm7my X27S2kdQsxI8OEPK6U7AIqUSHxZ0Ts9Oqt6jMG4To+q+Mc89gY5fXlwbHGnYSl+NDMQ+ G6P5Jy11eTLKTJyzP3c/d1eTjhT3YC8XCUue8aK2GghT9YphTujflRWEsG3e1BWS8JWL lrPk1l7nDG1bZUcphK931jWvZkpPHJYnX+Qkk+dGKUs0lfD7Has5xGgMko/VIFtHuzMZ qFyw== X-Gm-Message-State: AElRT7GXcx6vVnEel0qrqrlJy+NfRUAkh9j6bjfGVrj5SS+F3V0uiFtu K6havFJOAzU3xfE/yGSB0Bye8GMhhOjq6cuQd6XgIg== X-Google-Smtp-Source: AG47ELvhOw2ZhV2oBIx2ausr6pwaVmt5oy0nhvhKbp5ln/Z88xAaWr+NE8bLJLpEG0B1eAmGG6s8yD8yn628vFf4fvU= X-Received: by 10.28.61.65 with SMTP id k62mr4714162wma.140.1521113020359; Thu, 15 Mar 2018 04:23:40 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.109.7 with HTTP; Thu, 15 Mar 2018 04:23:39 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Thu, 15 Mar 2018 07:23:39 -0400 Message-ID: Subject: Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn To: Ashesh Vashi Cc: pgadmin-hackers , Murtuza Zabuawala Content-Type: multipart/alternative; boundary="001a114af6ce3e0bfb056771b94f" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a114af6ce3e0bfb056771b94f Content-Type: text/plain; charset="UTF-8" Hi On Thu, Mar 15, 2018 at 7:14 AM, Ashesh Vashi wrote: > Hi, > > I have just noticed, we're ignoring migrations directory too. > Should we not also check code styling for migrations directory? > Yeah, I was going to ask about that :-). Is there a specific reason why we're ignoring the migrations Murtuza? > > -- > > Thanks & Regards, > > Ashesh Vashi > EnterpriseDB INDIA: Enterprise PostgreSQL Company > > > > *http://www.linkedin.com/in/asheshvashi* > > > On Thu, Mar 15, 2018 at 4:40 PM, Dave Page wrote: > >> Ignore config_local.py and config_distro.py when running PEP-8 checks. >> >> Branch >> ------ >> master >> >> Details >> ------- >> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif >> f;h=53ae960aeba0dde6109b91c171f22758b1b04ebe >> >> Modified Files >> -------------- >> web/.pycodestyle | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a114af6ce3e0bfb056771b94f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

On Thu, Mar 15, 2018 at 7:14 AM, Ashesh Vashi <<= a href=3D"mailto:ashesh.vashi@enterprisedb.com" target=3D"_blank">ashesh.va= shi@enterprisedb.com> wrote:
Hi,

I have just noticed, we're ig= noring migrations directory too.
Should we not also check code st= yling for migrations directory?

=
Yeah, I was going to ask about that :-). Is there a specific reason wh= y we're ignoring the migrations Murtuza?
=C2=A0

--

Thanks & R= egards,

Ashesh Vashi
EnterpriseDB INDIA: <= /span>Enterprise = PostgreSQL Company

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi


On Thu, Mar 15, 2018 at 4:40 PM, Dave Page <= span dir=3D"ltr"><dpage@pgadmin.org> wrote:
= Ignore config_local.py and config_distro.py when running PEP-8 checks.

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=3Dpgadmin4.git;a=3Dcom= mitdiff;h=3D53ae960aeba0dde6109b91c171f22758b1b04ebe

Modified Files
--------------
web/.pycodestyle | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)





--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--001a114af6ce3e0bfb056771b94f--