MIME-Version: 1.0
In-Reply-To: 
 <CANxoLDcZND0pjXtrDKRip2xjddzjWiMgY2AMmrqqFE_Yu4+tHw@mail.gmail.com>
References: 
 <CANxoLDcZND0pjXtrDKRip2xjddzjWiMgY2AMmrqqFE_Yu4+tHw@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Wed, 26 Apr 2017 09:25:41 +0100
Message-ID: 
 <CA+OCxowUuaNRX9jHmEVFpqT7JCbjn6vaxw+JJ6yrvVp69FZscg@mail.gmail.com>
Subject: Re: Declarative partitioning in pgAdmin4
To: Akshay Joshi <akshay.joshi@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary=001a1137949e10405c054e0d96e3
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

--001a1137949e10405c054e0d96e3
Content-Type: text/plain; charset=UTF-8

Hi

[moving to the pgadmin-hackers mailing list as this a pgAdmin feature]

On Wed, Apr 26, 2017 at 8:20 AM, Akshay Joshi <akshay.joshi@enterprisedb.com
> wrote:

> Hi Dave
>
> Murtuza and I started thinking about "How to add Declarative
> Partitioning" support in pgAdmin4. We thought instead of showing Partition
> Table under existing Tables collection, we should add new collection node
> "Partition Tables". Showing table under the table node recursively will
> require lots of code changes in table and it's child nodes (column, index,
> trigger, etc..) which is more complex and error prone.
>

Perhaps, but from the user's perspective, there's no reason to list them
separately - they are just tables with a different structure from others.
We shouldn't confuse the user just because it's more convenient for us.

I really think it should look like this:

- Tables
  - t1
    - Columns
    - Constraints
    - Partitions
      - p1
        - Sub Objects (whatever they may be)
        ...
      - p2
      ...
  - t2
  ...


>
> Below is the design that we can implement:
>
>    - Create new "Partition Tables" collection node. User will be able to
>    create partition table by clicking "Create -> Partition Table" menu that we
>    will add on collection node. We will share the dialog prototype later
>    once we will have complete understanding of it.
>
> Can you share a mock-up of the dialog? The Figma tool that Shirley shared
looks like it'll be good for doing that - I can invite you to the team.

>
>    - Once table is created user will be able to create partitions by
>    clicking "Create -> Partitions" menu will be added on each partitioned
>    table node. We will share the dialog prototype later once we will have
>    complete understanding of it.
>
> I would expect the user to be able to define the partitioning scheme when
they create the table; e.g. on a new tab. It shouldn't be a two step
process.

>
>    - We will have to show sub nodes like (column, index, trigger,
>    constraints, etc..) on main table while some of the sub nodes won't require
>    for partitions like (column and many more again require some more knowledge
>    on partitioning).
>
> OK.


> Apart from above we will have to figure out following:
>
>    - How to remove partitions(table) from existing tables node as value
>    of relkind column is 'r' for partitions.
>    - Partitioning scheme to show in SQL pane for partitions.
>    - Some unknown issue/features of Declarative partitioning.
>
> OK.


> The above implementation may take more time, so it might possible that we
> may not be able to finish it by 14th May (deadline).
>

It would be nice to have it by then, but the true deadline will be a later
beta (TBD, but probably beta 2 which is sufficiently far off).

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--001a1137949e10405c054e0d96e3
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi<div><br></div><div>[moving to the pgadmin-hackers maili=
ng list as this a pgAdmin feature]<br><div class=3D"gmail_extra"><br><div c=
lass=3D"gmail_quote">On Wed, Apr 26, 2017 at 8:20 AM, Akshay Joshi <span di=
r=3D"ltr">&lt;<a href=3D"mailto:akshay.joshi@enterprisedb.com" target=3D"_b=
lank">akshay.joshi@enterprisedb.com</a>&gt;</span> wrote:<br><blockquote cl=
ass=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;p=
adding-left:1ex"><div dir=3D"ltr">Hi Dave<div><br></div><div><span id=3D"m_=
7641220982736118779:2f4.17">Murtuza</span> and I started thinking about &qu=
ot;How to add Declarative Partitioning&quot; support in pgAdmin4. We though=
t instead of showing Partition Table under existing Tables collection, we s=
hould add new collection node &quot;Partition Tables&quot;. Showing table u=
nder the table node recursively will require lots of code changes in table =
and it&#39;s child nodes (column, index, trigger, etc..) which is more comp=
lex and error prone.=C2=A0</div></div></blockquote><div><br></div><div>Perh=
aps, but from the user&#39;s perspective, there&#39;s no reason to list the=
m separately - they are just tables with a different structure from others.=
 We shouldn&#39;t confuse the user just because it&#39;s more convenient fo=
r us.</div><div><br></div><div>I really think it should look like this:</di=
v><div><br></div><div>- Tables</div><div>=C2=A0 - t1</div><div>=C2=A0 =C2=
=A0 - Columns</div><div>=C2=A0 =C2=A0 - Constraints</div><div>=C2=A0 =C2=A0=
 - Partitions</div><div>=C2=A0 =C2=A0 =C2=A0 - p1</div><div>=C2=A0 =C2=A0 =
=C2=A0 =C2=A0 - Sub Objects (whatever they may be)</div><div>=C2=A0 =C2=A0 =
=C2=A0 =C2=A0 ...</div><div>=C2=A0 =C2=A0 =C2=A0 - p2</div><div>=C2=A0 =C2=
=A0 =C2=A0 ...</div><div>=C2=A0 - t2</div><div>=C2=A0 ...</div><div>=C2=A0=
=C2=A0=C2=A0</div><div>=C2=A0</div><blockquote class=3D"gmail_quote" style=
=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir=
=3D"ltr"><div><br></div><div>Below is the design that we can implement:=C2=
=A0</div><div><ul><li>Create new &quot;Partition Tables&quot; collection no=
de. User will be able to create partition table by clicking &quot;Create -&=
gt; Partition Table&quot; menu that we will add on collection node.=C2=A0We=
 will share the <span id=3D"m_7641220982736118779:2f4.18">dialog</span> pro=
totype later once we will have complete understanding of it.</li></ul></div=
></div></blockquote><div>Can you share a mock-up of the dialog? The Figma t=
ool that Shirley shared looks like it&#39;ll be good for doing that - I can=
 invite you to the team.=C2=A0<br></div><blockquote class=3D"gmail_quote" s=
tyle=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div=
 dir=3D"ltr"><div><ul><li>Once table is created user will be able to create=
 partitions by clicking &quot;Create -&gt; Partitions&quot; menu will be ad=
ded on each partitioned table node. We will share the <span id=3D"m_7641220=
982736118779:2f4.19">dialog</span> prototype later once we will have comple=
te understanding of it.</li></ul></div></div></blockquote><div>I would expe=
ct the user to be able to define the partitioning scheme when they create t=
he table; e.g. on a new tab. It shouldn&#39;t be a two step process.=C2=A0<=
/div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-le=
ft:1px #ccc solid;padding-left:1ex"><div dir=3D"ltr"><div><ul><li>We will h=
ave to show sub nodes like (column, index, trigger, constraints, etc..) on =
main table while some of the sub nodes won&#39;t require for partitions lik=
e (column and many more again require some more knowledge on partitioning).=
</li></ul></div></div></blockquote><div>OK.</div><div>=C2=A0<br></div><bloc=
kquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #cc=
c solid;padding-left:1ex"><div dir=3D"ltr"><div>Apart from above we will ha=
ve to figure out following:</div><div><ul><li>How to remove partitions(tabl=
e) from existing tables node as value of <span id=3D"m_7641220982736118779:=
2f4.20">relkind</span> column is &#39;r&#39; for partitions.</li><li>Partit=
ioning scheme to show in <span id=3D"m_7641220982736118779:2f4.21">SQL</spa=
n> pane for partitions.<br></li><li>Some unknown issue/features of Declarat=
ive partitioning.=C2=A0</li></ul></div></div></blockquote><div>OK.</div><di=
v>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;=
border-left:1px #ccc solid;padding-left:1ex"><div dir=3D"ltr"><div><div>The=
 above implementation may take more time, so it might possible that we may =
not be able to finish it by 14th May (deadline).</div></div></div></blockqu=
ote><div><br></div><div>It would be nice to have it by then, but the true d=
eadline will be a later beta (TBD, but probably beta 2 which is sufficientl=
y far off).</div><div><br></div></div>-- <br><div class=3D"gmail_signature"=
 data-smartmail=3D"gmail_signature">Dave Page<br>Blog: <a href=3D"http://pg=
snake.blogspot.com" target=3D"_blank">http://pgsnake.blogspot.com</a><br>Tw=
itter: @pgsnake<br><br>EnterpriseDB UK: <a href=3D"http://www.enterprisedb.=
com" target=3D"_blank">http://www.enterprisedb.com</a><br>The Enterprise Po=
stgreSQL Company<br></div>
</div></div></div>

--001a1137949e10405c054e0d96e3--