MIME-Version: 1.0
References: 
 <CANxoLDcQqS46c+HDFF09Pispnd_p9EfLG-XN5iymv8EwXT4p9w@mail.gmail.com>
In-Reply-To: 
 <CANxoLDcQqS46c+HDFF09Pispnd_p9EfLG-XN5iymv8EwXT4p9w@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Mon, 15 Jul 2019 15:55:06 +0100
Message-ID: 
 <CA+OCxowWPRBb91TwrPvBS_NmhVQFjFyLFxTL8_T4JxF1nV0DcA@mail.gmail.com>
Subject: Re: [pgAdmin4][Patch]: RM 4428 and 4448
To: Akshay Joshi <akshay.joshi@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000d7729d058db972e8"
Precedence: bulk

--000000000000d7729d058db972e8
Content-Type: text/plain; charset="UTF-8"

Thanks, applied.

On Mon, Jul 15, 2019 at 1:32 PM Akshay Joshi <akshay.joshi@enterprisedb.com>
wrote:

> Hi Hackers,
>
> Attached is the patch to fix following issues in pgagent module:
>
>    - RM 4428 "malformed array literal error when updating pgagent job".
>    - RM 4448 "Error when updating connection string in pgagent Jobs."
>    - When user create a schedule using Create->Schedule dialog browser
>    tree is not showing newly created node.
>    - Properties tab showing same properties for all the created schedule.
>    - Added validation in "pga_jobstep.js", throws error on browser when
>    we modify step from the pgagent dialog and select the same node.
>
>
> Added regression test cases to add schedule and step from the pgagent job
> itself.
> Please review it.
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--000000000000d7729d058db972e8
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Thanks, applied.</div><br><div class=3D"gmail_quote"><div =
dir=3D"ltr" class=3D"gmail_attr">On Mon, Jul 15, 2019 at 1:32 PM Akshay Jos=
hi &lt;<a href=3D"mailto:akshay.joshi@enterprisedb.com">akshay.joshi@enterp=
risedb.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=
=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding=
-left:1ex"><div dir=3D"ltr">Hi Hackers,<div><br></div><div>Attached is the =
patch to fix following issues in pgagent module:</div><div><ul><li>RM 4428 =
&quot;malformed array literal error when updating pgagent job&quot;.</li><l=
i>RM 4448 &quot;Error when updating connection string in pgagent Jobs.&quot=
;</li><li>When user create a schedule using Create-&gt;Schedule dialog brow=
ser tree is not showing newly created node.</li><li>Properties tab showing =
same properties for all the created schedule.</li><li>Added validation in &=
quot;pga_jobstep.js&quot;, throws error on browser when we modify step from=
 the pgagent dialog and select the same node.</li></ul></div><div><br></div=
><div>Added regression test cases to add schedule and step from the pgagent=
 job itself.</div><div>Please review it.</div><div><br></div><div>-- <br><d=
iv dir=3D"ltr" class=3D"gmail-m_1105830051972898032gmail_signature"><div di=
r=3D"ltr"><div><div dir=3D"ltr"><div><div dir=3D"ltr"><div dir=3D"ltr"><div=
 dir=3D"ltr"><div><font color=3D"#3333FF"><b><span style=3D"color:rgb(0,0,0=
);font-family:arial,sans-serif;font-size:13px;border-collapse:collapse">Tha=
nks &amp; Regards</span></b></font></div><div><font color=3D"#3333FF"><b><s=
pan style=3D"color:rgb(0,0,0);font-family:arial,sans-serif;font-size:13px;b=
order-collapse:collapse">Akshay Joshi</span></b></font></div><div><font col=
or=3D"#3333FF"><b><span style=3D"color:rgb(0,0,0);font-family:arial,sans-se=
rif;font-size:13px;border-collapse:collapse">Sr. Software Architect<br></sp=
an></b></font></div><div><span style=3D"border-collapse:collapse"><font col=
or=3D"#000000" face=3D"arial, sans-serif"><b>EnterpriseDB Software India Pr=
ivate Limited</b></font><br></span></div><div><b style=3D"color:rgb(51,51,2=
55)"><span style=3D"color:rgb(0,0,0);font-family:arial,sans-serif;font-size=
:13px;border-collapse:collapse">Mobile: +91 976-788-8246</span></b><br></di=
v></div></div></div></div></div></div></div></div></div></div>
</blockquote></div><br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr"=
 class=3D"gmail_signature">Dave Page<br>Blog: <a href=3D"http://pgsnake.blo=
gspot.com" target=3D"_blank">http://pgsnake.blogspot.com</a><br>Twitter: @p=
gsnake<br><br>EnterpriseDB UK: <a href=3D"http://www.enterprisedb.com" targ=
et=3D"_blank">http://www.enterprisedb.com</a><br>The Enterprise PostgreSQL =
Company<br></div>

--000000000000d7729d058db972e8--