Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eribk-0006P9-BP for pgadmin-hackers@arkaria.postgresql.org; Fri, 02 Mar 2018 11:12:12 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1eribj-0007C5-8M for pgadmin-hackers@arkaria.postgresql.org; Fri, 02 Mar 2018 11:12:11 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eribi-0007Bv-NM for pgadmin-hackers@lists.postgresql.org; Fri, 02 Mar 2018 11:12:11 +0000 Received: from mail-wr0-x229.google.com ([2a00:1450:400c:c0c::229]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1eribf-0006my-2G for pgadmin-hackers@postgresql.org; Fri, 02 Mar 2018 11:12:09 +0000 Received: by mail-wr0-x229.google.com with SMTP id f14so9670518wre.8 for ; Fri, 02 Mar 2018 03:12:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=1fvvS9yKbU7vJ0unnxrgbTNQ2q97gu/YQTokglT53dE=; b=PjQKZC5hHvOF8hyKEH9CLAKM6X4KGpAX5eB35qd7KOr0whn2uar3zhAH1VUWZSlarG 4QDYNU+XCQkcm4Zq5tKqVhveYH2CRllEWPpSZdYteTdXaPwPMCFow9XcLguJ/Yzs1j9u 0MfIxr9JQKRF+EYxm3hDo6nJRclCOnMC8nn0naDEchNYE37qSWE/co46dVIo+uoEE9hZ t/gRsrXwrQtuERFr6yXqe/JLN3Xekpso5y+RDh5Eqi+Xuck/CO+IhsCDHjpv0RTfnioZ mVvJNbN7RalnmDwfuMtn6kHkTU64w5OufSmczEM+uq3aP8TlIlipMoPN5nGIU+lipHfH kIkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=1fvvS9yKbU7vJ0unnxrgbTNQ2q97gu/YQTokglT53dE=; b=enqhAzBplSy18ZtODCU6Z+p0CKoe3JHWeILAMBBvuCf4iq4LY/E3VRB7oNj7fNKUw3 g+R5MD+ea7oZCOPOnOC417ExeJztkAaGplM/Iksm4QD86sYpPtFk/6r4uu5wfGgkBiAz fRiXIW1trX/JJhYmywI2HCQFckh918Fs0Hfj7pCqsGswTCuzfbar9KnPDiWHaaQNe3dt XhNcU7mU8L4gjnuM0c6WJDcpg0+tk9++koKS8HSgh23VTisaFs2AAH5HlURhY68I+MSO ARZgmrhIi3P7tjUAPLlib8J6m4BKHzaZpL9fXhhAPpmMKaVS0iubD5uHsQIzlDxxgR3F TTYQ== X-Gm-Message-State: APf1xPDS/LUnEkTDIyGBtwomKmHaUBgs5/iRQtIAFtK3tKMJcRIxHQbu 7ULOyf8sx2Y7TV/dGqKoNYlpamDyKR1igstjMozL6w== X-Google-Smtp-Source: AG47ELvJzXROkUObdBXquhiSvoeG4Ptnm+/lDnjFVL6mY5dOGzBW+yuOmFXHPU+f/MXquvHWBLdJLV4TmQPEUei00UQ= X-Received: by 10.223.196.211 with SMTP id o19mr4461810wrf.256.1519989124319; Fri, 02 Mar 2018 03:12:04 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.109.7 with HTTP; Fri, 2 Mar 2018 03:12:03 -0800 (PST) In-Reply-To: References: From: Dave Page Date: Fri, 2 Mar 2018 11:12:03 +0000 Message-ID: Subject: Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI To: Murtuza Zabuawala Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="f403045f7cc4d168c305666c0b67" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --f403045f7cc4d168c305666c0b67 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks, applied. On Wed, Feb 28, 2018 at 10:35 AM, Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Hi Dave, > > I have found the issue, it was in Backform control itself :) > Issue: We were passing today's date value as minDate option in pgAgent > schedule schema while rendering the control, So when server was sending > previous datetime value it was not displaying it causing sync problem. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > On Tue, Feb 27, 2018 at 8:39 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> =E2=80=8BThanks Dave, I'll look into it. >> =E2=80=8B >> >> >> On Tue, Feb 27, 2018 at 8:37 PM, Dave Page wrote: >> >>> Hi >>> >>> On Tue, Feb 27, 2018 at 12:03 PM, Murtuza Zabuawala < >>> murtuza.zabuawala@enterprisedb.com> wrote: >>> >>>> I'm not able to re-produce the issue, Could you hard refresh and try >>>> again? >>>> >>> >>> I still see it. >>> >>> >>>> >>>> If possible could you please provide exact steps? >>>> >>> >>> Attached is a dump of my test pgagent schema. >>> >>> 1) Load the schema dump into the maintenance database >>> 2) Connect pgAdmin >>> 3) Browse to pgAgent Jobs >>> 4) Right-click Properties, and select the Schedules tab >>> 5) Open the subnode for sched1 >>> >>> >>>> >>>> -- >>>> Regards, >>>> Murtuza Zabuawala >>>> EnterpriseDB: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>>> >>>> On Tue, Feb 27, 2018 at 5:30 PM, Dave Page wrote: >>>> >>>>> Sorry - here it is. >>>>> >>>>> On Tue, Feb 27, 2018 at 11:59 AM, Murtuza Zabuawala < >>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>> >>>>>> Hi Dave, >>>>>> >>>>>> Could you please send screenshot? >>>>>> >>>>>> -- >>>>>> Regards, >>>>>> Murtuza Zabuawala >>>>>> EnterpriseDB: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>>> >>>>>> On Tue, Feb 27, 2018 at 5:24 PM, Dave Page wrote= : >>>>>> >>>>>>> Hi >>>>>>> >>>>>>> Still not quite right - see the attached screenshot which is the >>>>>>> result of simply viewing the properties of an existing job. Note th= at the >>>>>>> start time is shown in the grid but not the subnode control. >>>>>>> >>>>>>> Thanks. >>>>>>> >>>>>>> On Tue, Feb 27, 2018 at 8:26 AM, Murtuza Zabuawala < >>>>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>>>> >>>>>>>> Hi Dave, >>>>>>>> >>>>>>>> As validation related patch was committed with RM#3148 [ Sorry >>>>>>>> about that I forgot to checkout :) ] >>>>>>>> PFA patch to fix the issues you mentioned, I have also removed >>>>>>>> extra error message from sub node collection control and made it o= ptional >>>>>>>> via flag. >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Regards, >>>>>>>> Murtuza Zabuawala >>>>>>>> EnterpriseDB: http://www.enterprisedb.com >>>>>>>> The Enterprise PostgreSQL Company >>>>>>>> >>>>>>>> >>>>>>>> On Mon, Feb 26, 2018 at 10:14 PM, Dave Page >>>>>>>> wrote: >>>>>>>> >>>>>>>>> Hi >>>>>>>>> >>>>>>>>> On Mon, Feb 26, 2018 at 2:46 PM, Murtuza Zabuawala < >>>>>>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>>>>>> >>>>>>>>>> Hi, >>>>>>>>>> >>>>>>>>>> PFA patch to fix the issue where user was not able to create >>>>>>>>>> pgAgent job from UI without entering End date in schedule sectio= n. >>>>>>>>>> >>>>>>>>> >>>>>>>>> Whilst this does resolve the validation issue, there are still a >>>>>>>>> couple of other related problems, as can be seen in the attached >>>>>>>>> screenshots: >>>>>>>>> >>>>>>>>> - The Start date/time in the subnode control doesn't seem to be >>>>>>>>> properly synchronised with the value in the grid. >>>>>>>>> >>>>>>>>> - If you leave the End date/time blank (but maybe click into it >>>>>>>>> first), the grid will show "Invalid date". >>>>>>>>> >>>>>>>>> It's possible there are other oddities as well - please check >>>>>>>>> carefully for anything else. >>>>>>>>> >>>>>>>>> Thanks. >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Dave Page >>>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>>> Twitter: @pgsnake >>>>>>>>> >>>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>>>> The Enterprise PostgreSQL Company >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Dave Page >>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>> Twitter: @pgsnake >>>>>>> >>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>> The Enterprise PostgreSQL Company >>>>>>> >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>> >>>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> > --=20 Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --f403045f7cc4d168c305666c0b67 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, applied.

On Wed, Feb 28, 2018 at 10:35 AM, Murtuza Zabuawala <= span dir=3D"ltr"><murtuza.zabuawala@enterprisedb.com> wrote:<= br>
Hi Dave,
<= div class=3D"gmail_default" style=3D"font-family:verdana,sans-serif;color:#= 444444">
I have found the issue, it was in Backform contr= ol itself :)
Issue: We were passing today's date value as= minDate option in pgAgent schedule schema while rendering the control, So = when server was sending previous datetime value it was not displaying it ca= using sync problem.
=
<= div>
--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Company<= /div>

<= /div>

On Tue, Feb 27= , 2018 at 8:39 PM, Murtuza Zabuawala <murtuza.zabuawala@<= wbr>enterprisedb.com> wrote:
=E2=80=8BThanks Dave, I'll look into it.
=E2=80=8B

=

On Tue, Feb 27, 2018 at 8:37 PM, Dave Page <= span dir=3D"ltr"><dpage@pgadmin.org> wrote:
=
Hi

On Tue, Feb 27, 2018 at 12:03 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
I'm not able to re-produce the issue, Could yo= u hard refresh and try again?

I still see it.
=C2=A0
<= br>
If pos= sible could you please provide exact steps?
Attached is a dump of my test pgagent schema.

1) Load the schema dump into the maintenance database
2)= Connect pgAdmin
3) Browse to pgAgent Jobs
4) Right-cli= ck Properties, and select the Schedules tab
5) Open the subnode f= or sched1
=C2=A0

--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0h= ttp://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Tue, Feb 27, 2018 at 5:= 30 PM, Dave Page <dpage@pgadmin.org> wrote:
Sorry - here it is.

On Tue, Feb 27, 2018 at 11:59 AM= , Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.= com> wrote:
Hi Dave,

Could you please se= nd screenshot?

--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0<= a href=3D"http://www.enterprisedb.com/" rel=3D"noreferrer" target=3D"_blank= ">http://www.enterprisedb.com
The Enterprise PostgreSQL Company=

<= /div>

On Tue, Feb 27, 2018 at 5:24 PM, Dave Page <dpage@pgadmin= .org> wrote:
Hi

Still not quite right - see the attached screensho= t which is the result of simply viewing the properties of an existing job. = Note that the start time is shown in the grid but not the subnode control.<= /div>

Thanks.

=
On Tue, Feb 27, 2018 at 8:26 AM, Murtuza Zabuawa= la <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Dave,

As validation rela= ted patch was committed with RM#3148 [ Sorry about that I forgot to checkou= t :)=C2=A0]
PFA patch to fix the issues you mentioned, I have also removed extr= a error message from sub node collection control and made it optional via f= lag.



--
Regards,
Murtuza Zabua= wala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The E= nterprise PostgreSQL Company

=

On Mon, Feb 26, 2018 at 10:14 PM, Dave Page = <dpage@pgadmin.org> wrote:
Hi

On Mon, Feb 26, 2018 at 2:46 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to fix the issue where user was not able to create = pgAgent job from UI without entering End date in schedule section.

=C2=A0Whilst this does resolve the vali= dation issue, there are still a couple of other related problems, as can be= seen in the attached screenshots:

- The Start dat= e/time in the subnode control doesn't seem to be properly synchronised = with the value in the grid.

- If you leave the End= date/time blank (but maybe click into it first), the grid will show "= Invalid date".

It'= s possible there are other oddities as well - please check carefully for an= ything else.

Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pg= snake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL C= ompany

=



= --
Dave = Page
Blog: htt= p://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: <= a href=3D"http://www.enterprisedb.com" target=3D"_blank">http://www.enterpr= isedb.com
The Enterprise PostgreSQL Company




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

E= nterpriseDB UK: h= ttp://www.enterprisedb.com
The Enterprise PostgreSQL Company




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseD= B UK: http://www.= enterprisedb.com
The Enterprise PostgreSQL Company




--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--f403045f7cc4d168c305666c0b67--