Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1etZT3-0002Lc-8y for pgadmin-hackers@arkaria.postgresql.org; Wed, 07 Mar 2018 13:50:53 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1etZT1-0002Rf-NN for pgadmin-hackers@arkaria.postgresql.org; Wed, 07 Mar 2018 13:50:51 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1etZT1-0002RU-HU for pgadmin-hackers@lists.postgresql.org; Wed, 07 Mar 2018 13:50:51 +0000 Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1etZSy-0000NW-BE for pgadmin-hackers@postgresql.org; Wed, 07 Mar 2018 13:50:51 +0000 Received: by mail-wm0-x243.google.com with SMTP id z9so4818754wmb.3 for ; Wed, 07 Mar 2018 05:50:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=kvn+RCvcPXUx+5hyt7/OrIMTodcvH4qumXNVd8MLCtA=; b=bi+mW+h7h3FjwzsSa6iBRz2NGoZermgs9HZ+1/1/4LH5+dQvW7qSSQ2dnuWPLv+yU1 SVy4zKqRUSIkMNkTLOzA6mLmobQq53ho2TYFot8TA1XGGQDZ+Qs9RVArpGKpoWinNdDr bvNpHWam9b9qghUGlx1GHVT+mocsMB9J3Oy4sYcSjf5TJXyO1gmFM6j1jtq9M4K5PqIh S8IMTCMHX9Gzl5VOKA2lwtoThTNZQ6A3Ga2XLJdq7tnduf8ucn8RV3739jAOAX8UDLjY Wzlek4GVoWUHoQzy0B3Jhx6LahhAh7PC1kD7TtUkVjIUeWZ0/j80aHmU7CqCvfA5wXHz PfIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=kvn+RCvcPXUx+5hyt7/OrIMTodcvH4qumXNVd8MLCtA=; b=YN4j8lk19hAaxeuv4avkj9ggjBn+CBXpMMeH9pwOVaRPNuC1WDUQ5n1a/rPD1ZlXm2 pSlwK+Rdeh17bq/xMG45ReK2PAyfU7D+QETzNTHZRDQYup2pqYbVZk5KcZJyYm7PvQ2i 8by8uG4Rx+o825u2TlXcQs7PfMZ9vz/Kwu/WBw3QXkPy5sOaWSk/KacZ2OkorKHyBj/b Q5v8BZ0lFIS5iZIeaWQ/9Qi0Y/yofGymGxBaJA709E6pPLFoi6a7ZK4WfobwZ5ChMKAx uSBbW8XBSh0fk6uCzGu/h7Fnh6O+tRVWbqxyGpmAXxF7TLyZtqmjKzVSP8v7JDsDinN8 MTJQ== X-Gm-Message-State: AElRT7H009d+2swYjnKpXL7RG4kHtMo1ITAY3ekzCWhEbZEC3YeH2yT3 iLyd1cxkzTtDDTjrRq4Lcqg1yHNilk9gubgDDl6jyw== X-Google-Smtp-Source: AG47ELuI2h4k31we0/KQ560EPVnrTqi7GpRIpPEc1T5XmvwxTY63ZOq92XW6jIbwSRcZBrEF/dSea2Li8olDKrDyj9c= X-Received: by 10.28.61.65 with SMTP id k62mr14881154wma.140.1520430647470; Wed, 07 Mar 2018 05:50:47 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.109.7 with HTTP; Wed, 7 Mar 2018 05:50:46 -0800 (PST) In-Reply-To: References: From: Dave Page Date: Wed, 7 Mar 2018 13:50:46 +0000 Message-ID: Subject: Re: [pgAdmin4][RM#3037] Allow user to disable Gravatar image To: Murtuza Zabuawala Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="001a114af6cea602150566d2d89a" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a114af6cea602150566d2d89a Content-Type: text/plain; charset="UTF-8" Hi On Mon, Mar 5, 2018 at 8:12 AM, Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Hi, > > PFA patch to disable Gravatar image in Server mode. > > Requirments & Issues: > - For security reasons. > - For systems which do not have internet access. > - Hangs pgAdmin4 while loading the page if connection has no internet > access (as described in the ticket) > If I run with the Gravatar disabled, then I get the following regression failure: ====================================================================== FAIL: runTest (pgadmin.browser.tests.test_login.LoginTestCase) Valid_Credentials ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/tests/test_login.py", line 93, in runTest self.assertTrue(self.respdata in response.data.decode('utf8')) AssertionError: False is not true ---------------------------------------------------------------------- It's fine when Gravatar is enabled (and the rest of the patch does too). -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a114af6cea602150566d2d89a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

On Mon, Mar 5, 2018 at 8:12 AM, Murtuza Zabuawala <<= a href=3D"mailto:murtuza.zabuawala@enterprisedb.com" target=3D"_blank">murt= uza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to disable Gravatar ima= ge in Server mode.

Requirments & Issues:
- For security reasons.
- For systems which do not have internet acces= s.
- Hangs pgAdmin4 while loading the page if connection has no intern= et access (as described in the ticket)

If I run with the Gravatar disabled, then I get the following regre= ssion failure:

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D
FAIL: runTest (pgadmin.browser.tests.= test_login.LoginTestCase)
Valid_Credentials
-----------= -----------------------------------------------------------
Trace= back (most recent call last):
=C2=A0 File "/Users/dpage/git/= pgadmin4/web/pgadmin/browser/tests/test_login.py", line 93, in runTest=
=C2=A0 =C2=A0 self.assertTrue(self.respdata in response.data.dec= ode('utf8'))
AssertionError: False is not true
=
------------------------------------------------------------= ----------=C2=A0

It's fine when Gravatar is en= abled (and the rest of the patch does too).

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitt= er: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Postg= reSQL Company
--001a114af6cea602150566d2d89a--