Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bSPYZ-0001D6-LD for pgadmin-hackers@arkaria.postgresql.org; Wed, 27 Jul 2016 14:11:31 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bSPYZ-0004qy-66 for pgadmin-hackers@arkaria.postgresql.org; Wed, 27 Jul 2016 14:11:31 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bSPYY-0004ow-Av for pgadmin-hackers@postgresql.org; Wed, 27 Jul 2016 14:11:30 +0000 Received: from mail-it0-x22b.google.com ([2607:f8b0:4001:c0b::22b]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bSPYV-0002dS-29 for pgadmin-hackers@postgresql.org; Wed, 27 Jul 2016 14:11:29 +0000 Received: by mail-it0-x22b.google.com with SMTP id j124so50964035ith.1 for ; Wed, 27 Jul 2016 07:11:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=+yOcAUA14gCuIZzHh5NbTF3Q98ZIMWyMP8pCYgf9Xwk=; b=xmvsjmNVxqVqIauC9ArwUf6bMJRdiRUQTjPz/+E3WLBCjuuBLzBXdhkRIJBzh/AAZs LrUFzm3yR3378BLn7JbcLwlChkwTNM3D7uhW8ORja8FfCkOx47P2Q2QuJJktRiGvs5XF YSgVv2+cQxNYCAd3PDutGpTrsPV3kWQUF96wtC4I4oL4dS6llkF0eOgWzvNmAlf+NYpa 7X99dKRpI/15dlH/0hTq1lIg8xjmwSu2kuGfrqfL1AvylKXU346N7ICNiDlo7yW+Azg/ SRCUqLoFY5b9US3n0jo37U+eQ1Ut/uwdiN7/dL/CVx4yHkgw/Q03PZIe7asYJAKTfxmc wpJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=+yOcAUA14gCuIZzHh5NbTF3Q98ZIMWyMP8pCYgf9Xwk=; b=A3H4POFlCHhTv8Xo36TV8AMODqnKwxfG4C7f9qfko5WjEoI54ZBgmxsm8RQlx3kgpH 54TDizPrWhQ7cwCOExUZUetGMp2a0sY3xBCgCegJs+TsJQHtex8UDNO+RIBefC58ShNB h+2R3bofGIFw1sce332EldDQe7qvuiqPbBH3FUSwLPAk9DTO0XsnpRaWlvgtc/r9X2ba 7UVyIxcU5xCfluUMd9dQwDfuDwzcxdUOnxsG1abglHQEiCYRoSOPhUGWysT3etrbKnoi incIVhWpjzjx+T7yRe3BIm26Vb7IO0akxmaSjLATenzGcNE44EcBhDV0yF9MCZonkiAM cw8Q== X-Gm-Message-State: AEkoouslBS+2HRtkah/iZZB87g38qklWTxAmfpJ0BCkLh6g0Garm9jueUCiMmkJRcoP9MMv7aYjzP/kvHTZm4A== X-Received: by 10.36.16.197 with SMTP id 188mr33805547ity.88.1469628686185; Wed, 27 Jul 2016 07:11:26 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.25.136 with HTTP; Wed, 27 Jul 2016 07:11:24 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Wed, 27 Jul 2016 15:11:24 +0100 Message-ID: Subject: Re: patch for issue RM1260 [pgAdmin4] To: Harshal Dhumal Cc: Ashesh Vashi , pgadmin-hackers Content-Type: multipart/alternative; boundary=001a1144405acae93e05389e9741 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1144405acae93e05389e9741 Content-Type: text/plain; charset=UTF-8 Ashesh; please review and commit this. Thanks. On Wed, Jul 27, 2016 at 3:07 PM, Harshal Dhumal < harshal.dhumal@enterprisedb.com> wrote: > Hi, > > PFA updated patch for RM1260 (V4). > > Fixed create and delete operations for foreign table. > > > -- > *Harshal Dhumal* > *Software Engineer* > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Wed, Jul 27, 2016 at 6:53 PM, Ashesh Vashi < > ashesh.vashi@enterprisedb.com> wrote: > >> Hi Harshal, >> >> During testing, I found that create, and delete operation on foreign >> table is not working. >> Foreign table node uses, it's own version of Select2 Control, which >> should have used maximum functionalities from the original >> NodeAjaxOptionsControl for consistency reason. >> Hence - I have made the changes. >> >> Can you please take a look at the create, and delete operations, and >> submit combined patch for all those problems? >> >> -- >> >> Thanks & Regards, >> >> Ashesh Vashi >> EnterpriseDB INDIA: Enterprise PostgreSQL Company >> >> >> >> *http://www.linkedin.com/in/asheshvashi* >> >> >> On Wed, Jul 27, 2016 at 3:54 PM, Harshal Dhumal < >> harshal.dhumal@enterprisedb.com> wrote: >> >>> and patch file >>> >>> -- >>> *Harshal Dhumal* >>> *Software Engineer* >>> >>> EnterpriseDB India: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> On Wed, Jul 27, 2016 at 3:49 PM, Harshal Dhumal < >>> harshal.dhumal@enterprisedb.com> wrote: >>> >>>> Hi, >>>> >>>> PFA updated patch for RM1260. >>>> >>>> In addition to RM1260 issue I have added following changes in this >>>> patch. >>>> 1] datamodel.js: Added option check against undefined. >>>> 2] foreign key: fixed first empty option issue. >>>> >>>> -- >>>> *Harshal Dhumal* >>>> *Software Engineer* >>>> >>>> EnterpriseDB India: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>>> On Thu, Jul 7, 2016 at 5:08 PM, Ashesh Vashi < >>>> ashesh.vashi@enterprisedb.com> wrote: >>>> >>>>> Sure - I will do. >>>>> >>>>> -- >>>>> >>>>> Thanks & Regards, >>>>> >>>>> Ashesh Vashi >>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>>>> >>>>> >>>>> >>>>> *http://www.linkedin.com/in/asheshvashi* >>>>> >>>>> >>>>> On Thu, Jul 7, 2016 at 2:33 PM, Dave Page wrote: >>>>> >>>>>> Ashesh, can you review/commit please? >>>>>> >>>>>> Thanks. >>>>>> >>>>>> On Thu, Jul 7, 2016 at 7:50 AM, Harshal Dhumal < >>>>>> harshal.dhumal@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi, >>>>>>> >>>>>>> By mistake I deleted a line which was not supposed to be deleted, >>>>>>> and that line of code was initialization of select2. >>>>>>> >>>>>>> -- >>>>>>> *Harshal Dhumal* >>>>>>> *Software Engineer* >>>>>>> >>>>>>> EnterpriseDB India: http://www.enterprisedb.com >>>>>>> The Enterprise PostgreSQL Company >>>>>>> >>>>>>> On Thu, Jul 7, 2016 at 12:13 PM, Ashesh Vashi < >>>>>>> ashesh.vashi@enterprisedb.com> wrote: >>>>>>> >>>>>>>> Hi Harshal, >>>>>>>> >>>>>>>> Can you please explain - what was missing in the last patch? >>>>>>>> >>>>>>>> -- >>>>>>>> >>>>>>>> Thanks & Regards, >>>>>>>> >>>>>>>> Ashesh Vashi >>>>>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> *http://www.linkedin.com/in/asheshvashi* >>>>>>>> >>>>>>>> >>>>>>>> On Thu, Jul 7, 2016 at 12:12 PM, Harshal Dhumal < >>>>>>>> harshal.dhumal@enterprisedb.com> wrote: >>>>>>>> >>>>>>>>> Hi, >>>>>>>>> >>>>>>>>> PFA updated patch for issue RM1260 >>>>>>>>> >>>>>>>>> -- >>>>>>>>> *Harshal Dhumal* >>>>>>>>> *Software Engineer* >>>>>>>>> >>>>>>>>> EnterpriseDB India: http://www.enterprisedb.com >>>>>>>>> The Enterprise PostgreSQL Company >>>>>>>>> >>>>>>>>> On Thu, Jul 7, 2016 at 12:04 PM, Harshal Dhumal < >>>>>>>>> harshal.dhumal@enterprisedb.com> wrote: >>>>>>>>> >>>>>>>>>> Hi, >>>>>>>>>> Please ignore this patch as this has some minor issue. I'll sent >>>>>>>>>> updated one. >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> *Harshal Dhumal* >>>>>>>>>> *Software Engineer* >>>>>>>>>> >>>>>>>>>> EnterpriseDB India: http://www.enterprisedb.com >>>>>>>>>> The Enterprise PostgreSQL Company >>>>>>>>>> >>>>>>>>>> On Wed, Jul 6, 2016 at 5:30 PM, Harshal Dhumal < >>>>>>>>>> harshal.dhumal@enterprisedb.com> wrote: >>>>>>>>>> >>>>>>>>>>> Hi, >>>>>>>>>>> >>>>>>>>>>> PFA patch for issue RM1260. >>>>>>>>>>> >>>>>>>>>>> Changes: Issue wasn't related to foreign table but was due the >>>>>>>>>>> Select2 control. Now I have improved select2 control to handle null value >>>>>>>>>>> in multi-select mode. Initial it was returning "null" instead it should >>>>>>>>>>> return [] (empty array). >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> *Harshal Dhumal* >>>>>>>>>>> *Software Engineer* >>>>>>>>>>> >>>>>>>>>>> EnterpriseDB India: http://www.enterprisedb.com >>>>>>>>>>> The Enterprise PostgreSQL Company >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Sent via pgadmin-hackers mailing list ( >>>>>>>>> pgadmin-hackers@postgresql.org) >>>>>>>>> To make changes to your subscription: >>>>>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Dave Page >>>>>> Blog: http://pgsnake.blogspot.com >>>>>> Twitter: @pgsnake >>>>>> >>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>> >>>>> >>>> >>> >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a1144405acae93e05389e9741 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Ashesh; please review and commit this.

= Thanks.

On Wed, Jul 27, 2016 at 3:07 PM, Harshal Dhumal <harshal.d= humal@enterprisedb.com> wrote:
Hi,

PFA updated patch for RM1260 (V4).
=
Fixed create and delete operations for foreign table.

=
=
--=C2=A0
Harshal Dhumal
Software Engineer

EnterpriseDB India:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jul 27= , 2016 at 6:53 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com= > wrote:
H= i Harshal,

During testing, I found that create, and dele= te operation on foreign table is not working.
Foreign table node = uses, it's own version of Select2 Control, which should have used maxim= um functionalities from the original NodeAjaxOptionsControl for consistency= reason.
Hence - I have made the changes.

Can you please take a look at the create, and delete operations, and subm= it combined patch for all those problems?

<= div dir=3D"ltr">

<= span style=3D"font-family:courier new,monospace">--

<= span>Thanks & Regards,
Ashesh Vashi=
En= terpriseDB INDIA: Enterprise PostgreSQL Company

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi


On Wed, Jul 27, 2016 at 3:5= 4 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com>= ; wrote:
and patc= h file

--=C2=A0
Harshal Dhumal
So= ftware Engineer

EnterpriseDB India:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Company
=

On Wed, Jul 27, 2016 at 3:4= 9 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com>= ; wrote:
Hi,

PFA updated patch for RM1260.

In = addition to RM1260 issue I have added following changes in this patch.
<= /div>1] datamodel.js: Added option check against undefined.
2] for= eign key: fixed first empty option issue.

--=C2=A0
Harshal Dhumal
Software Engineer

Enterpr= iseDB India:=C2=A0http://www.enterpr= isedb.com
The Enterprise PostgreSQL C= ompany

On Thu, Jul 7, 2016 at 5:08= PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Sure - I will d= o.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi


On Thu, Jul 7, 2016 at 2:33= PM, Dave Page <dpage@pgadmin.org> wrote:
Ashesh, can you review/commit please?
=
Thanks.

=
On Thu, Jul 7, 2016 at 7:50 AM, Harshal Dhumal <= span dir=3D"ltr"><harshal.dhumal@enterprisedb.com> wrote:
Hi,

By mista= ke I deleted a line which was not supposed to be deleted, and that line of = code was initialization of select2.

=
--=C2=A0
Hars= hal Dhumal
Software Engineer

EnterpriseDB= India:=C2=A0http://www.enterprisedb= .com
The Enterprise PostgreSQL Comp= any
<= /div>

On Thu, Jul 7, 2016 at 12:1= 3 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Harshal,
Can you please explain - what was missing in the last patc= h?

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi


On Thu, Jul 7, 2016 at 12:12 PM, H= arshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

PFA updated patch for issue RM1260
=

=
--=C2=A0
Harshal Dhumal
Software Enginee= r

EnterpriseDB India:=C2=A0http://www.enterprisedb.com
T= he Enterprise PostgreSQL Company

On Thu, Jul 7, 2016 at 12:04 PM= , Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,
Plea= se ignore this patch as this has some minor issue. I'll sent updated on= e.

<= div>
--=C2=A0
Harshal Dhumal
Soft= ware Engineer

EnterpriseDB India:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jul 6, 2016 at 5:30= PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com>= wrote:
Hi,

PFA patch for issue RM1260.

Changes: Issue w= asn't related to foreign table but was due the Select2 control. Now I h= ave improved select2 control to handle null value in multi-select mode. Ini= tial it was returning "null" instead it should return [] (empty a= rray).


--=C2=A0
Harshal Dhumal
=
Software Engineer

EnterpriseDB India:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Company




--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=






<= font color=3D"#888888">--
Dave = Page
Blog: htt= p://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: <= a href=3D"http://www.enterprisedb.com" target=3D"_blank">http://www.enterpr= isedb.com
The Enterprise PostgreSQL Company








--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--001a1144405acae93e05389e9741--