Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f6CUC-00072e-Qh for pgadmin-hackers@arkaria.postgresql.org; Wed, 11 Apr 2018 09:56:17 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1f6CUB-0006YQ-G8 for pgadmin-hackers@arkaria.postgresql.org; Wed, 11 Apr 2018 09:56:15 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f6CUB-0006YG-2u for pgadmin-hackers@lists.postgresql.org; Wed, 11 Apr 2018 09:56:15 +0000 Received: from mail-wr0-x232.google.com ([2a00:1450:400c:c0c::232]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1f6CU2-0003Mg-Rb for pgadmin-hackers@postgresql.org; Wed, 11 Apr 2018 09:56:13 +0000 Received: by mail-wr0-x232.google.com with SMTP id z73so1145278wrb.0 for ; Wed, 11 Apr 2018 02:56:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=B29kOmf7IFjtcOWs2aBcePiwsuvmgbzk+7J8T3UCQhA=; b=ggQW/E7Awd9qzrzQWZ7gE91sHX07h0xsOgft5BoK7sWa3D1IA4Cl1B8UEPkGfDv4qj gsA7xKfdiq5drtSbNn0JzjM+buo9GA5/XBjmM6vmOUUA3Bmkf8FNydf9voQ5bR3dO+Gh VhuKwlGJWX3Ck7f/adoQ7o3d14WXtz8PCy0ucECu925Vsos8Aw9AfpvNUU5P9OsRmh1I QarQiSpa2NItX5V2bVQ4ZzmxMneFrnwy6ihZ/BmZeGbGeW52KOeA5lsKG83KjfQNAPkx jfyJJIbqfdSyRq/Q2li93gD96EX5hBrllKr8cL+mIhe/PpNMwSe25SA7+kaSo/eH5mx+ V+dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=B29kOmf7IFjtcOWs2aBcePiwsuvmgbzk+7J8T3UCQhA=; b=gknwD8+kYc+sJpiS5WmS/2pGNdurUDKTHiTc81OaC0zO4OLXNjIcNDWS3InOIZ4K04 njjPlymlEn4WJWo95xFzdy0oi8yDgbj0pIHAJQ/DwBMoa+AMlnEKOB3qRurLCPBRNFqo uYEXuTy57KDrs2s78QJNA9Q70L8D/Ey1favytchXbFG9I9rnPEdDjtx/qm0c46KWJaSD 6Tpd/pXeQIIqHGjpTL8Whpl3yGSvSIHZG6yIRF1hg/tmjHtpgWzI5gMhMA+vJ1uibX/K NYeSje12mevLIiD9tq00rawZc1/qTcmw+d+trHmTxL6sZaaPUzoTrIqXO8qr1WKFgX2k 1liQ== X-Gm-Message-State: ALQs6tDiQ+XRP6mUQT5Rloqv3MkMyhOx4kgCrcTHDWZGwD8rBfbBNKNa OTeIR7cpURqInwCXrZzVqu6CPBGqj6n7qs6NFYKnvQ== X-Google-Smtp-Source: AIpwx49cSS7jiXbPUUBB5kEv6knF6YT+eG6yjCc/rqyP0//9uDIEGVVvJ9jMSAX+HodSginMERN23ZS/6aWowxJYAQY= X-Received: by 10.223.196.212 with SMTP id o20mr2832395wrf.144.1523440565391; Wed, 11 Apr 2018 02:56:05 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.69.220 with HTTP; Wed, 11 Apr 2018 02:56:04 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Wed, 11 Apr 2018 10:56:04 +0100 Message-ID: Subject: Re: Bug #3083 fix To: Harshal Dhumal Cc: Joao De Almeida Pereira , Akshay Joshi , Neethu Mariya Joy , pgadmin-hackers Content-Type: multipart/alternative; boundary="f403045f7dbcbcdd6b05698fa53c" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --f403045f7dbcbcdd6b05698fa53c Content-Type: text/plain; charset="UTF-8" Joao, are you looking at this? On Tue, Apr 3, 2018 at 2:03 PM, Harshal Dhumal < harshal.dhumal@enterprisedb.com> wrote: > > > -- > *Harshal Dhumal* > *Sr. Software Engineer* > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Tue, Apr 3, 2018 at 6:10 PM, Dave Page wrote: > >> Argh, managed to send before I finished typing... >> >> On Tue, Apr 3, 2018 at 1:38 PM, Dave Page wrote: >> >>> Hi >>> >>> On Thu, Mar 29, 2018 at 4:29 PM, Joao De Almeida Pereira < >>> jdealmeidapereira@pivotal.io> wrote: >>> >>>> Hi Dave, >>>> That looks like in the surrounding area of the change. We run our >>>> pipeline and everything was green. >>>> Can you provide more details, which python version are you using? OS? >>>> >>> >>> That was on my travel laptop, which is macOS Sierra with the Apple >>> supplied Python 2.7. >>> >>> Interestingly, I'm on my dev laptop today (same OS and Python) and it's >>> working just fine. The difference is that the travel machine is a 12" >>> Macbook, whilst the dev machine is >>> >> >> a 15" MacBook Pro with 2 24" external monitors. That makes me wonder if >> the small screen size is causing a problem with this test, something we >> have seen before. >> >> > > Yes, screen size does cause problem. Slick grid does not render all > columns if viewport is not wide enough (like it does for rows). > Remaining columns would render when user scrolls right. > > To avoid similar problem in datatype feature test (commit: > 88bcd3b5129db88975421e26c1bf188daf4892f9 > ) > I have executed > queries in batch to limit number of columns in single query result. > > > >> >>> >>>> >>>> Thanks >>>> Joao >>>> >>>> On Thu, Mar 29, 2018 at 9:03 AM Dave Page wrote: >>>> >>>>> Hi >>>>> >>>>> On Wed, Mar 28, 2018 at 7:06 PM, Joao De Almeida Pereira < >>>>> jdealmeidapereira@pivotal.io> wrote: >>>>> >>>>>> Hey Akshay and Neethu >>>>>> >>>>>> We refactored the patch to add tests for the resize feature. We were >>>>>> able to write test cases for the drag event by using spies and setting the >>>>>> rect dimensions. In cases like this, we can just test some components in >>>>>> order to have enough confidence in the code. So we isolated the function >>>>>> that implements the behavior of this feature and tested that it was >>>>>> performing as expected. >>>>>> >>>>>> We ran the patch through the pipelines and all of the tests passed. >>>>>> >>>>> >>>>> I'm consistently seeing the feature test failure below with this patch >>>>> applied: >>>>> >>>>> ====================================================================== >>>>> FAIL: runTest (pgadmin.feature_tests.view_da >>>>> ta_dml_queries.CheckForViewDataTest) >>>>> Validate Insert, Update operations in View/Edit data with given test >>>>> data >>>>> ---------------------------------------------------------------------- >>>>> Traceback (most recent call last): >>>>> File "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py", >>>>> line 125, in runTest >>>>> self._verify_row_data(True) >>>>> File "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py", >>>>> line 325, in _verify_row_data >>>>> self.assertEquals(cells[idx], config_data[str(idx)][1]) >>>>> AssertionError: u'[null]' != u'1' >>>>> - [null] >>>>> + 1 >>>>> >>>>> >>>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --f403045f7dbcbcdd6b05698fa53c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Joao, are you looking at this?

On Tue, Apr 3, 2018 at 2:03 PM, Harshal= Dhumal <harshal.dhumal@enterprisedb.com> wrot= e:


=
--=C2=A0
Hars= hal Dhumal
Sr. Software Engineer

=
Enterpri= seDB India:=C2=A0http://www.ent= erprisedb.com
The Enterprise PostgreS= QL Company
=

On Tue, Apr 3, 2018 at 6:10= PM, Dave Page <dpage@pgadmin.org> wrote:
Argh, managed to send before I finished ty= ping...

= On Tue, Apr 3, 2018 at 1:38 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Thu,= Mar 29, 2018 at 4:29 PM, Joao De Almeida Pereira <jdealmeidape= reira@pivotal.io> wrote:
Hi Dave,
That looks like in the surrounding area of the = change. We run our pipeline and everything was green.
Can you pro= vide more details, which python version are you using? OS?

That was on my travel laptop, which is m= acOS Sierra with the Apple supplied Python 2.7.

In= terestingly, I'm on my dev laptop today (same OS and Python) and it'= ;s working just fine. The difference is that the travel machine is a 12&quo= t; Macbook, whilst the dev machine is=C2=A0
<= /blockquote>

a 15" MacBook Pro with 2 24" exte= rnal monitors. That makes me wonder if the small screen size is causing a p= roblem with this test, something we have seen before.
=C2=A0

Yes, screen size does cause p= roblem. Slick grid does not render all columns if viewport is not wide enou= gh (like it does for rows).
Remaining columns would render wh= en user scrolls right.

To avoid similar problem in dataty= pe feature test (commit: 88bcd3b5129db88975421e26c1bf188daf4892f9) I have = executed
queries in batch to limit number of columns in single query res= ult.

=C2=A0
=C2=A0
Thanks
Joao

On Thu, Mar 29, 2018 at 9:03 AM Dave Page <dpage@pgadmin.org> wrote:
<= /div>
Hi

On Wed, Mar 28, 201= 8 at 7:06 PM, Joao De Almeida Pereira <jdealmeidapereira@pivota= l.io> wrote:
Hey Akshay and Neethu

We refactore= d the patch to add tests for the resize feature.=C2=A0 We were able to writ= e test cases for the drag event by using spies and setting the rect dimensi= ons.=C2=A0 In cases like this, we can just test some components in order to= have enough confidence in the code.=C2=A0 So we isolated the function that= implements the behavior of this feature and tested that it was performing = as expected.

We ran the patch through the pipeline= s and all of the tests passed.

I'm consistently seeing the feature test failure below wi= th this patch applied:

=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
FAIL: runTest = (pgadmin.feature_tests.view_data_dml_queries.CheckForViewDataTest= )
Validate Insert, Update operations in View/Edit data with given= test data
-------------------------------------------------= ---------------------
Traceback (most recent call last):
=C2=A0 File "/Users/dpage/git/pgadmin4/web/pgadmin/feature= _tests/view_data_dml_queries.py", line 125, in runTest
= =C2=A0 =C2=A0 self._verify_row_data(True)
=C2=A0 File "/User= s/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_quer= ies.py", line 325, in _verify_row_data
=C2=A0 =C2=A0 self.as= sertEquals(cells[idx], config_data[str(idx)][1])
AssertionError: = u'[null]' !=3D u'1'
- [null]
+ 1
<= /div>


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake<= br>
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company=



--
Dave Page
Blog:= http://pgsnake.b= logspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com=
The Enterprise PostgreSQL Company
=


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseD= B UK: http://www.= enterprisedb.com
The Enterprise PostgreSQL Company




--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--f403045f7dbcbcdd6b05698fa53c--