MIME-Version: 1.0
In-Reply-To: 
 <CAKKotZQVJPRkHKzhix+s9zc+QnwUfWfOj+sVFfk6c7abKuyECg@mail.gmail.com>
References: 
 <CAKKotZSda6+wgyzckDJPXKK3dc8U-UXho9hmaaBp+LwZzdnhaQ@mail.gmail.com>
	<CA+OCxoxNx3ghQZ+YnWeNpyVs_BaJE+yL7C6H-PUFh6ddpr061Q@mail.gmail.com>
	<CA+OCxozEyaxygwg4KKNWKjKcLw=a-s6R64Tij9Z2JSVzzEKLrg@mail.gmail.com>
	<CAKKotZTGn2aUnkrotK5u=9hh+nD4gUC9mvKWo2FcDVuEhH5oyA@mail.gmail.com>
	<CA+OCxoyeSbbyKFm236agok7DNr4iRt16On9Kea+Z3tUj_iXa_g@mail.gmail.com>
	<CAKKotZQVJPRkHKzhix+s9zc+QnwUfWfOj+sVFfk6c7abKuyECg@mail.gmail.com>
Date: Thu, 17 Mar 2016 10:43:01 +0000
Message-ID: 
 <CA+OCxowYVt2V-sr5YQm-YDxhmNiam-4iSudNSmydu_e2_T3eMA@mail.gmail.com>
Subject: Re: PATCH: Added Node Type & Catalog objects [pgAdmin4]
From: Dave Page <dpage@pgadmin.org>
To: Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

Hi

On Thu, Mar 17, 2016 at 10:08 AM, Murtuza Zabuawala
<murtuza.zabuawala@enterprisedb.com> wrote:
>
> - When editing a type, I cannot select a Grantee on the Privileges tab.
>
> This is general issue with privilege control.
> [We will add it in TODO list]

OK.

> - When adding a composite type, I cannot type/select directly in the
> grid, I have to expand the row.
>
> Because currently in Backgrid we do not have functionality like if I edit
> one cell second cell re-renders according the value of first cell,
> If we expand and select the type the other two fields (length &
> precision)are dependent on the value of type for composite types they bec=
ome
> enable/disable accordingly.

That's must-have functionality. Please add a TODO for it.

> - If I click ADD to add a new member to a composite type whilst the
> previous row is expanded, the new row is added, but the expanded panel
> remains linked to the first row.
>
> - If I then click on the Edit button on the new row, I see two
> expanded panels, neither of which is attached to their row (and
> they're in the wrong order). I would only expect to see one panel at a
> time.
>
> This is general with sub-node collection control.
> [We will add it in TODO list]

OK.

> - When creating an External type, the Input, Output, Send, Receive and
> Analyze function lists are all blank. Is this expected? I would have
> thought there would be system functions listed as there are for Typmod
> in/out.
>
> Dave, I was not able to test External type functionality completely becau=
se
> it requires external type which is not inbuilt in postgres.
> Once you create that custom type using C/C++ code, it will be listed in
> those combobox by sql we are using to fetch external function types added=
 by
> user in postgres.

I wonder if installing PostGIS would allow that testing to be done.

> - Why does "Range" type have a frame around it?
>
> So that we can make visible/hide all the control/elements related to Range
> type as whole instead having separate code for each control/element.
> That frame is because we used =E2=80=98FieldsetControl=E2=80=99 of backfo=
rm to group all the
> elements of Range type.

Can you make it a plain div with no border/title? That would fit in
better with the existing styling, assuming the columns line up
properly.

Thanks.

--=20
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--=20
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers