Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1snbBh-004jqP-1g for pgadmin-hackers@arkaria.postgresql.org; Mon, 09 Sep 2024 10:00:02 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1snbBg-009j7p-DJ for pgadmin-hackers@arkaria.postgresql.org; Mon, 09 Sep 2024 10:00:00 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1snbBf-009j7h-U4 for pgadmin-hackers@lists.postgresql.org; Mon, 09 Sep 2024 10:00:00 +0000 Received: from mail-lj1-x22a.google.com ([2a00:1450:4864:20::22a]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1snbBb-000Hg3-Nn for pgadmin-hackers@postgresql.org; Mon, 09 Sep 2024 09:59:59 +0000 Received: by mail-lj1-x22a.google.com with SMTP id 38308e7fff4ca-2f74e613a10so23565291fa.1 for ; Mon, 09 Sep 2024 02:59:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; t=1725875995; x=1726480795; darn=postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=gvXxgT562irqfU1qcvus719w3axsujZJxi4Hq9y1oFo=; b=oDBcsKOVRPTvkGclts86z/l3nrpk8PsOZIQ8Uz9OL6JV328Lv/yceIVqk9AccnOYNm Fbw84pL7n9urCMVXWc7oLrMDUPFyOUoCushHfRg7Ktsy0b3aJnmOgwXExqE+nx94CEsK ShTULfZz9/4bbikN+kqTRVY1sFiEawljxMLJoaqXKBKuIGH8aJaFNKlSOQuFl0muQWXj pM9+Cc9NVGu0DL5UlIhLwYNz4RqzH4q6YPpTO3PAc65Uamkg5JjsPDgwsUKLVLMvJHll bCjH+OLGAdM52MfHLGkVUO35EceMCUJmqtnM8fIQxqyibe91AyFzVrblYon9llnB98N4 G0IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725875995; x=1726480795; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gvXxgT562irqfU1qcvus719w3axsujZJxi4Hq9y1oFo=; b=m37YsKHLuzoOgxCxCG8RliLeBpv0rUPAq+9l0jdTyaA+gm0KFjfnaEltMSHu9jBuBo KnOwqMYrXya76HMUuZeCEQy4P/bynAJdE0MSd0C+Z+jzBz0ngOai1hrCKKTyma/Nn3EL F6DsxLXYQPFrlBbswMJGvJZ2yw1oB2IonHYApyQrztVY5nDYqd/NwkkaUMJg0nzr2fhK Hnmw2SeTAA1V2ayx302YC15c3E9i31Ox+DBmPGLqj1Orls32tVW9qTWvSg8Aa98zj9zy gC7/nofTm0drMxrePuFDfq1jAKQgXSGfiimKnGQ0CkL+OOmhZ/WqhYSOY91BtvBwdBz9 V3ew== X-Gm-Message-State: AOJu0YxsPQ7zuDh3658zjgDXlONyreJczNiQI+PRoWgtw5wXUKHw+Inz 23GputdAqhkE2UhtPeaDlKYfZ8vqxbmM1U9QDbj6Mgz9ueh9WwcrtBpHt71GazABewniQ+d98kH S2oCI6TVyqD+UqJEctQHdRvlS48WP/WhGr4RH X-Google-Smtp-Source: AGHT+IECAuTYo/UyN0nIlgNHJKFFu2oAvmAvPEJwJqyaMNqUoxvoLXBFvsLS6tQrZDQOwSzYgnMMS43/IDBUVxRgUC4= X-Received: by 2002:a05:6512:4003:b0:536:5821:e415 with SMTP id 2adb3069b0e04-536587c650cmr9384765e87.30.1725875994837; Mon, 09 Sep 2024 02:59:54 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Mon, 9 Sep 2024 10:59:43 +0100 Message-ID: Subject: Re: Require suggestions for Issue #2874 To: Rohit Bhati Cc: pgadmin-hackers@postgresql.org Content-Type: multipart/alternative; boundary="0000000000009961ce0621acd125" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --0000000000009961ce0621acd125 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi On Mon, 9 Sept 2024 at 10:18, Rohit Bhati wrote: > Hi Dave, > > I have made changes as per your suggestions. > I have attached screenshots showing how the updates look across all theme= s > for your reference. > > If the current changes does not fit well with the theme or if you have an= y > suggestions for improvements, please let me know. > The colours etc. look correct now (ie. there are no weird borders), but I still don't think the row number looks visually distinct from the rest of the data. The bold text simply isn't very bold - I think it still needs more weight. > > Thanks > Rohit Bhati > EnterpriseDB > > > On Fri, Sep 6, 2024 at 2:01=E2=80=AFPM Dave Page wrot= e: > >> >> >> On Fri, 6 Sept 2024 at 09:25, Rohit Bhati >> wrote: >> >>> I have made some more changes with changing background color. >>> >> >> Yeah, that looks weird again, specifically on the selected rows. I >> believe the issue is that we should not highlight the row number column >> when a row is selected at all. That makes sense, as we should only be >> highlighting the columns that would get copied in a copy/paste operation >> anyway. >> >> Also, the bold still doesn't look bold. I think the weight needs to be >> increased. >> >> >>> >>> I have attached screenshots showing how the updates look across all >>> themes. >>> >>> On Fri, Sep 6, 2024 at 1:51=E2=80=AFPM Dave Page wr= ote: >>> >>>> Hi >>>> >>>> On Fri, 6 Sept 2024 at 09:19, Rohit Bhati >>>> wrote: >>>> >>>>> Hi, >>>>> >>>>> I have removed the border and background color, just made the row >>>>> numbers bold. >>>>> >>>>> I have attached screenshots showing how the updates look across all >>>>> themes. >>>>> >>>> >>>> That doesn't look bold at all to me - and I think we still need some >>>> other visual distinction, such as the column background colour. >>>> >>>> >>>>> >>>>> >>>>> On Fri, Sep 6, 2024 at 12:35=E2=80=AFPM Khushboo Vashi < >>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>> >>>>>> >>>>>> >>>>>> On Thu, Sep 5, 2024 at 7:11=E2=80=AFPM Dave Page = wrote: >>>>>> >>>>>>> Hi >>>>>>> >>>>>>> On Thu, 5 Sept 2024 at 14:38, Rohit Bhati < >>>>>>> rohit.bhati@enterprisedb.com> wrote: >>>>>>> >>>>>>>> Hi, >>>>>>>> >>>>>>>> I have made changes for issue #7863 >>>>>>>> based on >>>>>>>> theme requirements. >>>>>>>> >>>>>>>> I have attached screenshots showing how the updates look across al= l >>>>>>>> themes for your reference. >>>>>>>> >>>>>>>> If the current color does not fit well with the theme or if you >>>>>>>> have any suggestions for improvements, please let me know. >>>>>>>> >>>>>>> >>>>>>> Is the colour contrast high enough on the row numbers for selected >>>>>>> rows in the high contrast theme? The black on grey seems like it mi= ght not >>>>>>> be to me, but I haven't tested. >>>>>>> >>>>>>> I wonder also if we should make the row numbers bold all the time. >>>>>>> Thoughts? >>>>>>> >>>>>> We can check how it looks. Also the cell border doesn't look good to >>>>>> me. >>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Dave Page >>>>>>> pgAdmin: https://www.pgadmin.org >>>>>>> PostgreSQL: https://www.postgresql.org >>>>>>> EDB: https://www.enterprisedb.com >>>>>>> >>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/ >>>>>>> >>>>>>> >>>> >>>> -- >>>> Dave Page >>>> pgAdmin: https://www.pgadmin.org >>>> PostgreSQL: https://www.postgresql.org >>>> EDB: https://www.enterprisedb.com >>>> >>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/ >>>> >>>> >> >> -- >> Dave Page >> pgAdmin: https://www.pgadmin.org >> PostgreSQL: https://www.postgresql.org >> EDB: https://www.enterprisedb.com >> >> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/ >> >> --=20 Dave Page pgAdmin: https://www.pgadmin.org PostgreSQL: https://www.postgresql.org EDB: https://www.enterprisedb.com PGDay UK 2024, 11th September, London: https://2024.pgday.uk/ --0000000000009961ce0621acd125 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

On Mon, 9 Sept 2024 at 10:18, Rohit Bhati <rohit.bhati@enterprisedb.com= > wrote:
Hi Dave,

I ha= ve made changes as per your suggestions.
I have attached screenshots sho= wing how the updates look across all themes for your reference.

If t= he current changes does not fit well with the theme or if you have any sugg= estions for improvements, please let me=C2=A0know.

The colours etc. look correct now (ie. there are no weird= borders), but I still don't think the row number looks visually distin= ct from the rest of the data. The bold text simply isn't very bold - I = think it still needs more weight.

=C2=A0

Thanks
Rohit Bhati
EnterpriseDB
=

On Fri, Sep 6, 2024 at 2:01=E2=80=AFPM Dave Page <dpage@pgadmin.org> wrote:


On Fri, 6 Sept 2= 024 at 09:25, Rohit Bhati <rohit.bhati@enterprisedb.com> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);pa= dding-left:1ex">
I have made some more changes with changin= g background color.

Yeah, that lo= oks weird again, specifically=C2=A0on the selected rows. I believe the issu= e is that we should not highlight the row number column when a row is selec= ted at all. That makes sense, as we should only be highlighting the columns= that would get copied in a copy/paste operation anyway.

Also, the bold still doesn't look bold. I think the weight needs= to be increased.
=C2=A0
<= br>I have attached screenshots showing h= ow the updates look across all themes.

On Fri, Sep 6, 2024 at 1:51=E2=80=AFPM Dave Page <dpage@pgadmin.org> = wrote:
Hi

On Fri, 6 Sept 202= 4 at 09:19, Rohit Bhati <rohit.bhati@enterprisedb.com> wrote:
Hi,

I have removed the border and bac= kground color, just=C2=A0made the=C2=A0<= /span>row numbers bold.

I have attached screenshots showing how th= e updates look across all themes.=

That doesn't look bol= d at all to me - and I think we still need some other visual distinction, s= uch as the column background colour.
=C2=A0


<= div class=3D"gmail_quote">
On Fri, Sep= 6, 2024 at 12:35=E2=80=AFPM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:

On Thu, Sep 5, 2024 at 7:11=E2=80=AFPM Dave Page <dpage@pgadmin.org> wrote:


--
Dave Page
PostgreSQL: https://www.postgresql.or= g

PGDay UK = 2024, 11th September, London: https://2024.pgday.uk/



--
Dave Page
PostgreSQL: https://www.postgresql.or= g

PGDay UK = 2024, 11th September, London: https://2024.pgday.uk/



--
Dave Page
PostgreSQL: https://www.postgresql.or= g

PGDay UK = 2024, 11th September, London: https://2024.pgday.uk/

--0000000000009961ce0621acd125--