Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hWQTl-00089e-Js for pgadmin-hackers@arkaria.postgresql.org; Thu, 30 May 2019 19:12:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hWQTk-0005Xi-2N for pgadmin-hackers@arkaria.postgresql.org; Thu, 30 May 2019 19:12:44 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hWQTj-0005Xb-RN for pgadmin-hackers@lists.postgresql.org; Thu, 30 May 2019 19:12:43 +0000 Received: from mail-it1-x142.google.com ([2607:f8b0:4864:20::142]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hWQTh-0007mM-6X for pgadmin-hackers@postgresql.org; Thu, 30 May 2019 19:12:43 +0000 Received: by mail-it1-x142.google.com with SMTP id m141so11774024ita.3 for ; Thu, 30 May 2019 12:12:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Nyzw0g6TU/+Gq+ONwVS++LxfDL0anb6s2krEDzf7ZkY=; b=OjP1DvYsFycPZzb81smjwIkePiCAzNhXjR+BpYBdKGU7BKlDpX/Asm9RgS4/XIkKkF 5rcaJihYklGm1hnswaf0bxtZsN4YZlzIX7vb4B0wnp3107rEeB7cNAspeOQhPty39YVv V+fqhObUqIg8G0QXFKtSJVGtsu7/mDv1QPCe45YpVctwjsbRrJhkyErOf3BGtxoPMlW4 7UNihVh+EoJdOsi1ITiabVqHM4I0oBdq/NGC4N6utHow8qnaLgxV84jzInrQEWSBr7DS 2T/xLwiAx1RcJPDWgo1XE1yPCQjV9OMt2j7ogZRXQg596iQY+1K3D3BfAvXEnJ92wbyS fIIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Nyzw0g6TU/+Gq+ONwVS++LxfDL0anb6s2krEDzf7ZkY=; b=j/2bYN9AL6Tpo+t8eMgbv3KelDMnisrkKDbCpkHTXRretn9m6hqE7sCfb2GZOwZefZ qtIttsGoX3xjMza4bl6snvEivYiMBhmD+qfCh9bqC5gblLSLa2VUIfqMKx1BGoDMHmO7 Tx8BGpNMmmayVoOT9/TQzLyG4Dt/bvDDt7a6fHad31SFy2RfIlq2kcXuAhTcj3oay2Gj r1NXMDw2SdllaNjMx2XARbLOiyYnR9iMJ4JRZ31kz5W8a2lzVq+eZ6ZjBzeM8gLodTMP VEZaGHJqiryWJWDC6r3p2EFsH3hOHVtAK62p3Q5z27a1c+GcpfIcSAdJzPUc83wpQm1h JEEw== X-Gm-Message-State: APjAAAWSq/FnFSXmyhXe5EzD3mNV/pL7cuwfYA1KXjMIOZvqF2sfosm4 L/QzjUVWjzTqWO3RybTJ57CvzUm1Gc2DyKzVWD6IaEI2f+qJNwdm X-Google-Smtp-Source: APXvYqygwqHyNrldyZVw/0tw5/O3nRi/CECRpNUyQR4R6xXo6TIGjwfAEsAB8VQZDK0rZnpivLRfe8/7/v73taL5Umg= X-Received: by 2002:a24:9d94:: with SMTP id f142mr3902972itd.179.1559243559554; Thu, 30 May 2019 12:12:39 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Thu, 30 May 2019 15:12:28 -0400 Message-ID: Subject: Re: [pgAdmin][RM2653] Lock layout To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000007c6020058a1fae35" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000007c6020058a1fae35 Content-Type: text/plain; charset="UTF-8" Hi Can you rebase please? (pgadmin4) dpage@orac:*~/git/pgadmin4*$ git apply ~/Downloads/RM2653.patch error: patch failed: web/pgadmin/browser/static/js/browser.js:15 error: web/pgadmin/browser/static/js/browser.js: patch does not apply On Thu, May 30, 2019 at 6:15 AM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to introduce feature to lock the layout with three > different levels: > 1) None - No locking > 2) Prevent docking - The docking/undocking of panels will be disabled > 3) Full lock - The resizing along with docking/undocking of panels will be > disabled > > - This can be changed from new menu under File->Lock layout-> > or from Preferences->Browser->Display->Lock Layout > - JS test cases added. > > With this patch I have also changed below: > 1) Moved the maintenance dialog button group control to new common control > named RadioModern, which I have re-used in preferences for lock layout > levels. > 2) Added main nav bar menu with check feature, the menus which can checked. > 3) Ability to add submenus from existing get_own_menuitems in python code > which is not possible currently. > 3) Separated all the layout related functions from browser.js to new file > layout.js to help JS testing. > > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --0000000000007c6020058a1fae35 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

Can you rebase please?

(pgadmin4) dpage@= orac:~/git/pgadm= in4$ git apply ~/Downloads/RM2653.patch=C2=A0

error: patch failed: web/pgadmin/browser/static/js/browser.js:15

error: web/pgadmin/browser/static/js/browser.js: patch does not appl= y


On Thu, May 30, 2019 at 6:15 AM Aditya Toshniwal <aditya.toshniwal@enterpris= edb.com> wrote:
Hi Hackers,

Attached is the patch to introduce feat= ure to lock the layout with three different levels:
1) None - No locking
2)= Prevent docking - The docking/undocking of panels will be disabled
3) Full= lock - The resizing along with docking/undocking of panels will be disable= d

- This can be changed from new menu under File->Lock layout->&= lt;The level> or from Preferences->Browser->Display->Lock Layou= t
- JS test cases added.

With this patch I have also changed below:
1)= Moved the maintenance dialog button group control to new common control na= med RadioModern, which I have re-used in preferences for lock layout levels= .
2) Added main nav bar menu with check feature, the menus which can c= hecked.
3) Separated all the layout r= elated functions from browser.js to new file layout.js to help JS testing.<= /div>
=
Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0Enterpris= eDB India |=C2=A0Pune=
"Don't Complain about Heat, Plant a TREE"
=


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @p= gsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL = Company
--0000000000007c6020058a1fae35--