Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hs0zV-0006r2-Ut for pgadmin-hackers@arkaria.postgresql.org; Mon, 29 Jul 2019 08:26:46 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hs0zU-0005TS-BU for pgadmin-hackers@arkaria.postgresql.org; Mon, 29 Jul 2019 08:26:44 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hs0zT-0005TL-Rs for pgadmin-hackers@lists.postgresql.org; Mon, 29 Jul 2019 08:26:44 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hs0zQ-0004FX-G4 for pgadmin-hackers@postgresql.org; Mon, 29 Jul 2019 08:26:42 +0000 Received: by mail-wr1-x442.google.com with SMTP id z1so60767026wru.13 for ; Mon, 29 Jul 2019 01:26:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=n0EPUmuCSDj1FVzakUe2KHNuLiD0rs6WB1OijFZGdt4=; b=hb6xmLv1HYEBHStRAAU0+v2bXCKGMOox986tO07AeDsS8L8IDvhFcGfXIWa9dl6KvK YruDC06I9JMup+AeO6MB4ylzq/NB1s+Q0zUIS5qNJ06nP1TmK1heuw154SqS8aa5Olwm FpUIW4tjJlkePD0IjDCZbnxPKIhnzPfRNau4Dzw2dnx5ROx9xFluFnmy8iv06HaclhIQ lpCTt8m9K0NUPoDkcq7GGqAxqgWQsoXVUwDZz8jgmOoIH/mzMPuXSUJJShAfxIGiFJ+5 dCkuA6foLImibxE0tPLpRmnJvzQQCTyuusZaHyYFln2pKIdJWDdnE5+w91MQhj9QZ/V2 5g/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=n0EPUmuCSDj1FVzakUe2KHNuLiD0rs6WB1OijFZGdt4=; b=FMF/cLMwlZr3W80XHLR1H1O2Tdhi0yKWaPuMrhzYG5Mf86WUar7448w0MJh1ghrrLI HmAtvGI/tDRYI5LQLhjsTzX/xRnL7NtLzH2LaSYQ9mZiiy/jx2jrVu5vVquNl/6FDKgv BjqpdS0IR1qeFeaT2QAWsBa7bxr53e/E/YLQ+wlt4Ski47DXR7ZwtViox3QygHLqLllD EmG+MbdtyKkbuCCXaoT3rU6QNS1wPXyTM8jdkxn+StJY39a2b3Q0yjvTBoFIj7Fq9qG3 Ja+mH2QAK6hG4D4Zql8eatYuyAUhCqjdgr9bS18jqOPzSZRX+LWINrgC2ZRH+y8znT2M Elrg== X-Gm-Message-State: APjAAAU4LUqIfrwCr7hZvj2+adBx/An5Aa2WV+mDkt4XNWUw+2mWHMTU aXkx0Aqz9N9/pG0m1yf0w0ZQMBuxidh6zqvgfJJSrQ== X-Google-Smtp-Source: APXvYqy7T0b5YF0RG4HhXwKuZUf28AwRD108jQWdOJI9CfeSFBk70UOE1bErW6Ay9W1y1hH82NKRvDG65FJa3V+j9Dk= X-Received: by 2002:a5d:53c1:: with SMTP id a1mr16741793wrw.185.1564388797074; Mon, 29 Jul 2019 01:26:37 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Mon, 29 Jul 2019 09:26:24 +0100 Message-ID: Subject: Re: [GSoC] Support editing resultsets from tables with OIDs To: Yosry Muhammad , Akshay Joshi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000008a6816058ecda6ed" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000008a6816058ecda6ed Content-Type: text/plain; charset="UTF-8" Hi Yosry and Akshay On Fri, Jul 26, 2019 at 1:02 PM Dave Page wrote: > Akshay; can you take a look at this and commit if appropriate please? I'm > somewhat busy at the moment :-( > > On the subject of the regression test - I assume at one point the messages > window was including the command tags in it's output. This failure would > indicate we broken that. Anyone got any ideas how that happened? > Based on the number of tickets being logged about the lack of command tags in the messages panel since we released 4.11, it's clear this was broken and the test was valid all along. Can you look into that ASAP please Yosry? Akshay; let's talk later today about the feature tests. Can you schedule a call with Navnath (I think he was working on them?). We need to prioritise stabilising these tests so we can automate them. > > On Thu, Jul 25, 2019 at 1:01 PM Yosry Muhammad wrote: > >> Hi, >> Please find a patch attached to add supporting of resultsets from tables >> with OIDs as updatable resultsets (with updated test cases and docs) - this >> is a part of a GSoC project. Please review ! >> This patch also includes a small refactor of the previous patch and a >> small bug fix that occurred when the query resultset had no rows but was >> updatable (row additions were not permitted, although they should be). >> >> >> On a different note, one of the feature tests fails (on master), probably >> due to a small typo. In query_tool_tests.py this function call: >> >> self.page.find_by_xpath( >> '//div[contains(@class, "sql-editor-message") and ' >> 'contains(string(), "CREATE TABLE")]' >> ) >> >> on lines 371-374 produces an exception that the element cannot be found, >> this is probably due to the fact that the message returned by the query >> executed before this call does not contain the string "CREATE TABLE". Just >> letting you know about this. >> >> Thanks and regards! >> -- >> >> *Yosry Muhammad Yosry* >> >> Computer Engineering student, >> The Faculty of Engineering, >> Cairo University (2021). >> Class representative of CMP 2021. >> https://www.linkedin.com/in/yosrym93/ >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --0000000000008a6816058ecda6ed Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Yosry and Akshay

On Fri, Jul 26, 2019 at 1:02 PM Da= ve Page <dpage@pgadmin.org> = wrote:
Akshay; can you take a look at this and commit if appropriate plea= se? I'm somewhat busy at the moment :-(

On the subje= ct of the regression test - I assume at one point the messages window was i= ncluding the command tags in it's output. This failure would indicate w= e broken that. Anyone got any ideas how that happened?

Based on the number of tickets being logged about t= he lack of command tags in the messages panel since we released 4.11, it= 9;s clear this was broken and the test was valid all along. Can you look in= to that ASAP please Yosry?

Akshay; let's talk = later today about the feature tests. Can you schedule a call with Navnath (= I think he was working on them?). We need to prioritise stabilising these t= ests so we can automate them.
=C2=A0

On Thu, Jul 25, 2019 at 1:01 PM Yosry Muhammad <yosrym93@gmail.com= > wrote:
Hi,
Please find a patch attached to add support= ing of resultsets from tables with OIDs as updatable resultsets (with updat= ed test cases and docs) - this is a part of a GSoC project. Please review !=
This patch also includes a small refactor of the previous patch = and a small bug fix that occurred when the query resultset had no rows but = was updatable (row additions were not permitted, although they should be).<= br>


On a different note, one of the= feature tests fails (on master), probably due to a small typo. In query_to= ol_tests.py this function call:
self.page.find=
_by_xpath(
    =
9;//div[contains(@class, "sql-editor-message") and '
    'contains(s=
tring(), "CREATE TABLE")]'
)
on lin= es 371-374 produces an exception that the element cannot be found, this is = probably due to the fact that the message returned by the query executed be= fore this call does not contain the string "CREATE TABLE". Just l= etting you know about this.

Thanks and regards!
--=C2=A0

Yosry Muhammad Yosry

Computer Engineering student,
The Faculty of Engineering,
C= airo University (2021).
Class represent= ative of CMP 2021.


--
Dave Page
Blog: http://pgsnake.blog= spot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.comThe Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @p= gsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL = Company
--0000000000008a6816058ecda6ed--