Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZami-0004ym-GZ for pgadmin-hackers@arkaria.postgresql.org; Fri, 03 Feb 2017 10:08:04 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1cZami-00040e-3h for pgadmin-hackers@arkaria.postgresql.org; Fri, 03 Feb 2017 10:08:04 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cZamT-0003ll-MC for pgadmin-hackers@postgresql.org; Fri, 03 Feb 2017 10:07:49 +0000 Received: from mail-io0-x22b.google.com ([2607:f8b0:4001:c06::22b]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1cZamQ-0000j1-BB for pgadmin-hackers@postgresql.org; Fri, 03 Feb 2017 10:07:48 +0000 Received: by mail-io0-x22b.google.com with SMTP id v96so14055056ioi.0 for ; Fri, 03 Feb 2017 02:07:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=5hhzPPX8UHTJs+YsYlQXEJfjRsxZY8XV7kQam8ACFVc=; b=kwU6+S9nBtfgerFAIfZKlYXJMPlFOrN0Wdle4PzIXBtQXFouvHIgi23PYC3bchA9RG H1plGSC1LkqKKBRcj/ez1egznpeiA/ysak057pj3d5uvtuPhbOiSk4ZVGFTRObq419+8 gbyzULCtuOSsURcOEVRalHmq/smzkKPexODrOO20jc9edhA1Ix8TvCkLLIVrb8BEp2dr RGOrt1Ty9IJ2or0FocjaWS1q1sBtl9Vui2OfEgL84xRNuPMr9/KBpDym0lfluyrNiELD msqEP+GAKmGTCJh9rLDeeQjhgQSzxsojUWZ7th01l8qVhJ5l0Ek9RpurIQzJNyx26edj Fvhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=5hhzPPX8UHTJs+YsYlQXEJfjRsxZY8XV7kQam8ACFVc=; b=P1Dy+0K0kK0yXw1Mhe64V5biORVfwznAOFVIbUgQPPqflkVcU9wcrIb92FVJiB8T+c +sD+LuB9JON2pvz6dGTinLmLTk5jePLDbZcS/W9r6DR46zs8ZD8vMfvnlEpcyaTjXuOs Q8zRdmhB4b3/3nh/T9n+cpqBqohrt2zBK1FFdqtGQwbh7WzRyJPkbgBb4B6D/CDQ0blB ofTIJD4twdCEqw2Q6wuk8HgM/PGPrAMWPxZUymyKH0oQRTJXgvd0fYfD36lPaNgzyay3 I1DXY61hoUd3l6ETysZSybyEjsIZEkEe4ct34Dfbi2vAfoWcDSv29BRPf0B/a4wJagTT sGlg== X-Gm-Message-State: AIkVDXLEZO7ocBYln0LBdrAQ+IBoMvg9ndfLroBX0VFc23PlHUL8qe9yZRg/SzyAJ0mKwkFiYZepDoYcVMnmPg== X-Received: by 10.107.11.27 with SMTP id v27mr9902800ioi.145.1486116465137; Fri, 03 Feb 2017 02:07:45 -0800 (PST) MIME-Version: 1.0 Received: by 10.64.224.198 with HTTP; Fri, 3 Feb 2017 02:07:44 -0800 (PST) In-Reply-To: References: From: Dave Page Date: Fri, 3 Feb 2017 10:07:44 +0000 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM 2069 - Wrong tablespace displayed in table properties To: Akshay Joshi Cc: Khushboo Vashi , pgadmin-hackers Content-Type: multipart/alternative; boundary=001a113f8288ffec2a05479d731c X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a113f8288ffec2a05479d731c Content-Type: text/plain; charset=UTF-8 On Fri, Feb 3, 2017 at 9:59 AM, Akshay Joshi wrote: > Hi Dave > > On Fri, Feb 3, 2017 at 3:10 PM, Dave Page wrote: > >> Akshay, I'll leave you to review/commit this. Please ensure that any >> tickets that patches close have the target version set to 1.2 (if they >> don't, please update them). That way the roadmap will reflect all the >> changes in the release. >> > > In pgAdmin3 for default tablespace we have one entry(* tablespace>*) in combo box while in pgAdmin4 we don't have such entry. > Please refer the attached screenshot. Is this the expected behaviour for > pgAdmin4? > I think that was just because you couldn't have an empty option in the control in pgAdmin 3. I think it's fine to just be optional in pgAdmin4 (or, just at the option everywhere if you think it's better - I really don't have a preference!) > >> Thanks. >> >> On Fri, Feb 3, 2017 at 7:47 AM, Khushboo Vashi < >> khushboo.vashi@enterprisedb.com> wrote: >> >>> Hi Akshay, >>> >>> Please find the attached updated patch. >>> >>> Thanks, >>> Khushboo >>> >>> On Fri, Feb 3, 2017 at 1:08 PM, Akshay Joshi < >>> akshay.joshi@enterprisedb.com> wrote: >>> >>>> Hi Khushboo >>>> >>>> After applying latest patch I found one error(refer attached >>>> screenshot) when clicking on "Materialized Views" collection node. >>>> >>>> Fixed >>> >>>> On Fri, Feb 3, 2017 at 12:14 PM, Khushboo Vashi < >>>> khushboo.vashi@enterprisedb.com> wrote: >>>> >>>>> Hi, >>>>> >>>>> On Fri, Feb 3, 2017 at 11:53 AM, Khushboo Vashi < >>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> Please find the attached rebased patch. >>>>>> >>>>>> This patch also include fix for RM 2139: Message (Connection to the >>>>> server has been lost.) displayed with Materialized view and view under sql >>>>> tab >>>>> >>>>> >>>>> >>>>>> Thanks, >>>>>> Khushboo >>>>>> >>>>>> On Mon, Jan 30, 2017 at 6:20 PM, Dave Page wrote: >>>>>> >>>>>>> Hi >>>>>>> >>>>>>> Can you rebase this please? >>>>>>> >>>>>>> Thanks. >>>>>>> >>>>>>> On Fri, Jan 27, 2017 at 11:53 AM, Khushboo Vashi >>>>>>> wrote: >>>>>>> > Hi, >>>>>>> > >>>>>>> > Please find the attached updated patch. >>>>>>> > >>>>>>> > Thanks, >>>>>>> > Khushboo >>>>>>> > >>>>>>> > On Fri, Jan 20, 2017 at 5:31 PM, Dave Page >>>>>>> wrote: >>>>>>> >> >>>>>>> >> On Fri, Jan 13, 2017 at 6:41 AM, Khushboo Vashi >>>>>>> >> wrote: >>>>>>> >> > Hi, >>>>>>> >> > >>>>>>> >> > Please find the attached patch to fix the RM 2069 - Wrong >>>>>>> tablespace >>>>>>> >> > displayed in table properties. >>>>>>> >> > >>>>>>> >> > When the table is created without a tablespace, the "pg_default" >>>>>>> >> > tablespace >>>>>>> >> > gets selected rather than the default tablespace (the current >>>>>>> database >>>>>>> >> > tablespace). >>>>>>> >> > So, this issue has been fixed. >>>>>>> >> >>>>>>> >> Unfortunately more work is required. I started hacking on it (see >>>>>>> >> attached), but there is more effort needed and I'm out of time. >>>>>>> >> Specifically: >>>>>>> >> >>>>>>> >> - We need to remove 'pg_default' as the default tablespace when >>>>>>> >> creating objects. Let's have no default, and let PG automatically >>>>>>> pick >>>>>>> >> the right tablespace, unless the user specifically overrides it. >>>>>>> My >>>>>>> >> updated patch removes that default, and fixes some of the SQL to >>>>>>> >> handle it. >>>>>>> >> >>>>>>> > Done >>>>>>> >> >>>>>>> >> - Matviews don't list the correct tablespace in their properties >>>>>>> list. >>>>>>> >> >>>>>>> > Done >>>>>>> >> >>>>>>> >> - Unique constraints ignore the tablespace option if the user >>>>>>> selects >>>>>>> >> pg_default, even if the database's default is something different. >>>>>>> >> >>>>>>> > Done >>>>>>> >> >>>>>>> >> So I think to complete this we need to review all objects that use >>>>>>> >> tablespaces (databases, tables, matviews, indexes, index-backed >>>>>>> >> constraints) and ensure: >>>>>>> >> >>>>>>> > Done >>>>>>> >> >>>>>>> >> - No default tablespace is selected when creating an object. >>>>>>> >> >>>>>>> > Done >>>>>>> >> >>>>>>> >> - If the user selects a tablespace, the CREATE SQL must handle it >>>>>>> >> properly. Similarly, if they leave it to the default. >>>>>>> >> >>>>>>> > Done >>>>>>> >> >>>>>>> >> - The Properties views must display the actual tablespace in use, >>>>>>> >> whether it is specific to the object, or the database default. >>>>>>> >> >>>>>>> > Done >>>>>>> >> >>>>>>> >> Thanks. >>>>>>> >> >>>>>>> >> -- >>>>>>> >> Dave Page >>>>>>> >> Blog: http://pgsnake.blogspot.com >>>>>>> >> Twitter: @pgsnake >>>>>>> >> >>>>>>> >> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>> >> The Enterprise PostgreSQL Company >>>>>>> > >>>>>>> > >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Dave Page >>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>> Twitter: @pgsnake >>>>>>> >>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>> The Enterprise PostgreSQL Company >>>>>>> >>>>>> >>>>>> >>>>> >>>> >>>> >>>> -- >>>> *Akshay Joshi* >>>> *Principal Software Engineer * >>>> >>>> >>>> >>>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 >>>> 976-788-8246 <+91%2097678%2088246>* >>>> >>> >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > > -- > *Akshay Joshi* > *Principal Software Engineer * > > > > *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246 > <+91%2097678%2088246>* > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a113f8288ffec2a05479d731c Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On Fri, Feb 3, 2017 at 9:59 AM, Akshay Joshi <akshay.joshi= @enterprisedb.com> wrote:
<= div dir=3D"ltr">Hi Dave=C2=A0

On Fri, Feb 3, 2017 at 3:10 PM, Dave Page <dpage@pgadmin.org> wrote:
Akshay, I'll leave you to review/com= mit this. Please ensure that any tickets that patches close have the target= version set to 1.2 (if they don't, please update them). That way the r= oadmap will reflect all the changes in the release.
=
=C2=A0 =C2=A0In pgAdmin3 for default tablespace we have one entry(<default= tablespace>) in com= bo box while in pgAdmin4 we don't have such entry. Please refer the att= ached screenshot. Is this the expected behaviour for pgAdmin4?
<= /div>

I think that was just because y= ou couldn't have an empty option in the control in pgAdmin 3. I think i= t's fine to just be optional in pgAdmin4 (or, just at the <default t= ablespace> option everywhere if you think it's better - I really don= 't have a preference!)
=C2=A0

Thanks.

<= div class=3D"gmail_quote">On Fri, Feb 3, 2017 at 7:47 AM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi Akshay,

<= /div>
Please find the attached updated patch.

= Thanks,
Khushboo

On Fri, Feb 3, 2017 at 1:08 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi
<= br>
Fixed=C2=A0
O= n Fri, Feb 3, 2017 at 12:14 PM, Khushboo Vashi <khushboo.vas= hi@enterprisedb.com> wrote:
Hi,

On Fri, Feb 3, 2017 at 11:53 AM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,
Please find the attached rebased patch.

This patch also include fix for RM 2139:=C2=A0Mes= sage (Connection to the server has been lost.) displayed with Materialized = view and view under sql tab

<= /div>
=C2=A0
Thanks,
Khushboo

On Mon, Jan 30, 2017 at 6:20 PM, Dave Page <dpage@pgadmin= .org> wrote:
Hi

Can you rebase this please?

Thanks.

On Fri, Jan 27, 2017 at 11:53 AM, Khushboo Vashi
<khushboo.vashi@enterprisedb.com> wrote:
> Hi,
>
> Please find the attached updated patch.
>
> Thanks,
> Khushboo
>
> On Fri, Jan 20, 2017 at 5:31 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> On Fri, Jan 13, 2017 at 6:41 AM, Khushboo Vashi
>> <khushboo.vashi@enterprisedb.com> wrote:
>> > Hi,
>> >
>> > Please find the attached patch to fix the RM 2069 - Wrong tab= lespace
>> > displayed in table properties.
>> >
>> > When the table is created without a tablespace, the "pg_= default"
>> > tablespace
>> > gets selected rather than the default tablespace (the current= database
>> > tablespace).
>> > So, this issue has been fixed.
>>
>> Unfortunately more work is required. I started hacking on it (see<= br> >> attached), but there is more effort needed and I'm out of time= .
>> Specifically:
>>
>> - We need to remove 'pg_default' as the default tablespace= when
>> creating objects. Let's have no default, and let PG automatica= lly pick
>> the right tablespace, unless the user specifically overrides it. M= y
>> updated patch removes that default, and fixes some of the SQL to >> handle it.
>>
> Done
>>
>> - Matviews don't list the correct tablespace in their properti= es list.
>>
> Done
>>
>> - Unique constraints ignore the tablespace option if the user sele= cts
>> pg_default, even if the database's default is something differ= ent.
>>
> Done
>>
>> So I think to complete this we need to review all objects that use=
>> tablespaces (databases, tables, matviews, indexes, index-backed >> constraints) and ensure:
>>
> Done
>>
>> - No default tablespace is selected when creating an object.
>>
> Done
>>
>> - If the user selects a tablespace, the CREATE SQL must handle it<= br> >> properly. Similarly, if they leave it to the default.
>>
> Done
>>
>> - The Properties views must display the actual tablespace in use,<= br> >> whether it is specific to the object, or the database default.
>>
> Done
>>
>> Thanks.
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company





--
Akshay Joshi
Principal Software = Engineer=C2=A0

<= /font>

=




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsna= ke

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Co= mpany



--
Akshay Joshi<= /span>
Principal Software Engineer=C2=A0





--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--001a113f8288ffec2a05479d731c--